[Opensc-commits] [OpenSC/OpenSC] b2a84f: Fix LGTM.com warning: Comparison result is always ...

[Dimitri P. O. <no...@gi...>]

  Branch: refs/heads/master
  Home:   https://github.com/OpenSC/OpenSC
  Commit: b2a84f2e1ec15bd38e410811544685d91189e778
      https://github.com/OpenSC/OpenSC/commit/b2a84f2e1ec15bd38e410811544685d91189e778
  Author: Dimitri Papadopoulos <323...@us...>
  Date:   2021-09-22 (Wed, 22 Sep 2021)

  Changed paths:
    M src/libopensc/card-piv.c

  Log Message:
  -----------
  Fix LGTM.com warning: Comparison result is always the same

Comparison is always true because r <= -1.

Indeed in this branch:
	!(r > 0) && !(r== 0) => r < 0


  Commit: e585fa079d7ca9bf9bf96dc325be25dec5e1fded
      https://github.com/OpenSC/OpenSC/commit/e585fa079d7ca9bf9bf96dc325be25dec5e1fded
  Author: Dimitri Papadopoulos <323...@us...>
  Date:   2021-09-22 (Wed, 22 Sep 2021)

  Changed paths:
    M src/pkcs15init/pkcs15-isoApplet.c

  Log Message:
  -----------
  Fix LGTM.com warning: Comparison result is always the same

Comparison is always true because r <= -1.

Indeed in this branch we already have:
	r < 0


Compare: https://github.com/OpenSC/OpenSC/compare/2c526d65face...e585fa079d7c