Menu
▾
▴
[Opensc-commits] [OpenSC/OpenSC] 29d3b6: github actions: Improve PIV testing
|
From: Jakub J. <no...@gi...> - 2021-09-08 12:46:31
|
Branch: refs/heads/master Home: https://github.com/OpenSC/OpenSC Commit: 29d3b69e0538dea61be04f5ae25e76361c121bf6 https://github.com/OpenSC/OpenSC/commit/29d3b69e0538dea61be04f5ae25e76361c121bf6 Author: Jakub Jelen <jj...@re...> Date: 2021-09-08 (Wed, 08 Sep 2021) Changed paths: M .github/test-piv.sh Log Message: ----------- github actions: Improve PIV testing Current test using PivApplet/bin/:jcardsim/target/jcardsim-3.0.5 only creates 2 private keys. These are never seen by a PIV client, as the way private keys are found is via a certificate which contains the public key (SPKI) which contains the type of key, RSA or ECC and the size or curve OID. This change creates the public key and self signed certificate for the two keys so pkcs11-tool can list and test the crypto. Based on a change from Doug Engert in https://github.com/OpenSC/OpenSC/pull/2053 Broken into separate steps to prevent concurrency issue in yubico-piv-tool and make potential debugging easier Commit: 60cd9355d30ba673451374517e5b91ce9464acb2 https://github.com/OpenSC/OpenSC/commit/60cd9355d30ba673451374517e5b91ce9464acb2 Author: Jakub Jelen <jj...@re...> Date: 2021-09-08 (Wed, 08 Sep 2021) Changed paths: M .github/build.sh M .github/setup-linux.sh M .github/workflows/linux.yml Log Message: ----------- github actions: Add ix86 compilation target to catch 32bit issues Commit: 73d4760ce0068200ed3ffcfba150ca60c4b864ef https://github.com/OpenSC/OpenSC/commit/73d4760ce0068200ed3ffcfba150ca60c4b864ef Author: Jakub Jelen <jj...@re...> Date: 2021-09-08 (Wed, 08 Sep 2021) Changed paths: M .github/build.sh M .github/setup-linux.sh M tests/common.sh Log Message: ----------- github actions: Install 32b softhsm Commit: 4e5552fb3bab80f6ca7356fdc14a63574c627416 https://github.com/OpenSC/OpenSC/commit/4e5552fb3bab80f6ca7356fdc14a63574c627416 Author: Jakub Jelen <jj...@re...> Date: 2021-09-08 (Wed, 08 Sep 2021) Changed paths: A .github/restart-pcscd.sh M .github/test-cac.sh M .github/test-gidsapplet.sh M .github/test-isoapplet.sh M .github/test-openpgp.sh M .github/test-piv.sh Log Message: ----------- .github: Share code handling pcscd restarts and cleanup Commit: 5888a2703c5e87d945db2a9e7a592bc59a1c3e86 https://github.com/OpenSC/OpenSC/commit/5888a2703c5e87d945db2a9e7a592bc59a1c3e86 Author: Jakub Jelen <jj...@re...> Date: 2021-09-08 (Wed, 08 Sep 2021) Changed paths: M .github/restart-pcscd.sh Log Message: ----------- .github: Try to wait for pcscd up to 30 seconds Commit: defc0c8320082d171b07b81432eb6b9c2ec9e933 https://github.com/OpenSC/OpenSC/commit/defc0c8320082d171b07b81432eb6b9c2ec9e933 Author: Jakub Jelen <jj...@re...> Date: 2021-09-08 (Wed, 08 Sep 2021) Changed paths: M .github/test-openpgp.sh Log Message: ----------- .github: Fix directory structure Commit: 54392313321bc236d6502787a990b148121e51b7 https://github.com/OpenSC/OpenSC/commit/54392313321bc236d6502787a990b148121e51b7 Author: Jakub Jelen <jj...@re...> Date: 2021-09-08 (Wed, 08 Sep 2021) Changed paths: M .github/test-cac.sh M src/tests/p11test/virt_cacard_ref.json Log Message: ----------- tests: Simplify CAC setup to prevent hangs Commit: 93eeb603a4e99dfcc2b9937862a5a1d1f00f78be https://github.com/OpenSC/OpenSC/commit/93eeb603a4e99dfcc2b9937862a5a1d1f00f78be Author: Jakub Jelen <jj...@re...> Date: 2021-09-08 (Wed, 08 Sep 2021) Changed paths: M .github/restart-pcscd.sh Log Message: ----------- tests: Avoid calling systemctl comands when the systemd is not handling the system (for example in containers) Commit: 1e7c36a5c9347d3a1eaac8afb0f11cafc8c21d2f https://github.com/OpenSC/OpenSC/commit/1e7c36a5c9347d3a1eaac8afb0f11cafc8c21d2f Author: Jakub Jelen <jj...@re...> Date: 2021-09-08 (Wed, 08 Sep 2021) Changed paths: M .github/setup-linux.sh Log Message: ----------- .github: Add missing dependency Commit: 646b1d0baedf9af456278905f5e18ab8bb05ebef https://github.com/OpenSC/OpenSC/commit/646b1d0baedf9af456278905f5e18ab8bb05ebef Author: Jakub Jelen <jj...@re...> Date: 2021-09-08 (Wed, 08 Sep 2021) Changed paths: M .github/setup-linux.sh Log Message: ----------- .github: Try harder to prevent interactive prompts Commit: bf4c83886d6eff48d1c9e2e8ef3666eabe8404f4 https://github.com/OpenSC/OpenSC/commit/bf4c83886d6eff48d1c9e2e8ef3666eabe8404f4 Author: Jakub Jelen <jj...@re...> Date: 2021-09-08 (Wed, 08 Sep 2021) Changed paths: M .github/setup-java.sh M .github/test-piv.sh Log Message: ----------- .github: Do not fail on existing directories Commit: 7b39f3cac99fbc23b4640cdf8e0487f3f24f61a3 https://github.com/OpenSC/OpenSC/commit/7b39f3cac99fbc23b4640cdf8e0487f3f24f61a3 Author: Jakub Jelen <jj...@re...> Date: 2021-09-08 (Wed, 08 Sep 2021) Changed paths: M .github/test-piv.sh Log Message: ----------- .github: Clarify comment Commit: a97c9077a0c28f245d9d0bbb215ba96962eb52ce https://github.com/OpenSC/OpenSC/commit/a97c9077a0c28f245d9d0bbb215ba96962eb52ce Author: Jakub Jelen <jj...@re...> Date: 2021-09-08 (Wed, 08 Sep 2021) Changed paths: M .github/workflows/linux.yml Log Message: ----------- .github: openpgp works now Commit: 053420fc55cf134ca1ded687e572f755d28eaf44 https://github.com/OpenSC/OpenSC/commit/053420fc55cf134ca1ded687e572f755d28eaf44 Author: Jakub Jelen <jj...@re...> Date: 2021-09-08 (Wed, 08 Sep 2021) Changed paths: M .github/setup-java.sh Log Message: ----------- .github: Try my jcardsim fork with fix for tests https://github.com/licel/jcardsim/pull/174 Commit: 8fc650e71089a64f4df1c0a3a919ab53c2ec515d https://github.com/OpenSC/OpenSC/commit/8fc650e71089a64f4df1c0a3a919ab53c2ec515d Author: Jakub Jelen <jj...@re...> Date: 2021-09-08 (Wed, 08 Sep 2021) Changed paths: R .gitlab-ci.yml R .travis.yml Log Message: ----------- Removed unused CI configurations Commit: c1be55aabf0ff9618b2230790f5e5c0bc0803eb2 https://github.com/OpenSC/OpenSC/commit/c1be55aabf0ff9618b2230790f5e5c0bc0803eb2 Author: Jakub Jelen <jj...@re...> Date: 2021-09-08 (Wed, 08 Sep 2021) Changed paths: M src/tools/pkcs11-tool.c Log Message: ----------- pkcs11-tool: Fix typo in the comment Commit: eb34f61d144f02f1bcf02e33803b580c08fed59d https://github.com/OpenSC/OpenSC/commit/eb34f61d144f02f1bcf02e33803b580c08fed59d Author: Jakub Jelen <jj...@re...> Date: 2021-09-08 (Wed, 08 Sep 2021) Changed paths: M src/tools/opensc-explorer.c Log Message: ----------- tools: Avoid maybe-uninitialized warnings from gcc11 Fixes: #2382 Commit: 53aa0f65a45171806100577cf5038646a0db63f6 https://github.com/OpenSC/OpenSC/commit/53aa0f65a45171806100577cf5038646a0db63f6 Author: Jakub Jelen <jj...@re...> Date: 2021-09-08 (Wed, 08 Sep 2021) Changed paths: M tests/test-pkcs11-tool-test-threads.sh Log Message: ----------- tests: Use explicit pkcs11 library in thread test Previously, the system-installed opensc was used, but there is no guarantee that it exists when running tests. Use the locally built library, even though there will probably not be any slots. Using softhsm causes a lot of failures as it looks like this is not well handled in there. Commit: 3127ad2431071dcd2bbdd6cf5f1faf50baa855a9 https://github.com/OpenSC/OpenSC/commit/3127ad2431071dcd2bbdd6cf5f1faf50baa855a9 Author: Jakub Jelen <jj...@re...> Date: 2021-09-08 (Wed, 08 Sep 2021) Changed paths: M src/tests/p11test/p11test.c M src/tests/p11test/p11test_case_pss_oaep.c Log Message: ----------- p11test: Fix invalid format string on 32b architectures Commit: 8bdd7595718cf733dc9abcff11bbfcef32b65e4c https://github.com/OpenSC/OpenSC/commit/8bdd7595718cf733dc9abcff11bbfcef32b65e4c Author: Jakub Jelen <jj...@re...> Date: 2021-09-08 (Wed, 08 Sep 2021) Changed paths: M src/tools/pkcs11-tool.c Log Message: ----------- pkcs11-tool: Add SHA256 test Commit: 8fc822aedca2f837c072f65bc16a73deeacc13c5 https://github.com/OpenSC/OpenSC/commit/8fc822aedca2f837c072f65bc16a73deeacc13c5 Author: Jakub Jelen <jj...@re...> Date: 2021-09-08 (Wed, 08 Sep 2021) Changed paths: M src/pkcs11/framework-pkcs15.c M src/pkcs11/openssl.c Log Message: ----------- pkcs11: Do not add MD5 and RIPEMD160 algorithms in FIPS mode With OpenSSL in FIPS mode, they will fail later, causing unexpected issues. Commit: eb8a381cd87dd91ad5e9cf66cc709325c52ab9bb https://github.com/OpenSC/OpenSC/commit/eb8a381cd87dd91ad5e9cf66cc709325c52ab9bb Author: Jakub Jelen <jj...@re...> Date: 2021-09-08 (Wed, 08 Sep 2021) Changed paths: M src/tools/pkcs11-tool.c Log Message: ----------- pkcs11-tool: Skip unsupported digests in FIPS mode Commit: 465d0d776dcec7a1ca54d017331bd7170fab0b80 https://github.com/OpenSC/OpenSC/commit/465d0d776dcec7a1ca54d017331bd7170fab0b80 Author: Jakub Jelen <jj...@re...> Date: 2021-09-08 (Wed, 08 Sep 2021) Changed paths: M src/tools/pkcs11-tool.c Log Message: ----------- pkcs11-tool: Support extractable and private flags when generating secret keys Fixes: #2393 Commit: a6e9488cd523d1c8e5fd81a858d2e0e7e64537a7 https://github.com/OpenSC/OpenSC/commit/a6e9488cd523d1c8e5fd81a858d2e0e7e64537a7 Author: Jakub Jelen <jj...@re...> Date: 2021-09-08 (Wed, 08 Sep 2021) Changed paths: M .gitignore Log Message: ----------- Ignore test artifacts Commit: 2a4a609cdec6d6bae8603e291a7f5b00de4f4242 https://github.com/OpenSC/OpenSC/commit/2a4a609cdec6d6bae8603e291a7f5b00de4f4242 Author: Jakub Jelen <jj...@re...> Date: 2021-09-08 (Wed, 08 Sep 2021) Changed paths: M src/sm/sm-common.c Log Message: ----------- sm: Avoid memory leaks on errors of OpenSSL 3.0 code Commit: de75600fd2fc955972727f8c496a6e5221fd1382 https://github.com/OpenSC/OpenSC/commit/de75600fd2fc955972727f8c496a6e5221fd1382 Author: Jakub Jelen <jj...@re...> Date: 2021-09-08 (Wed, 08 Sep 2021) Changed paths: M src/sm/sm-common.c Log Message: ----------- sm: Initialize tmplen Commit: 134f6dd5da58ccadde4a66087b3c257d151aec31 https://github.com/OpenSC/OpenSC/commit/134f6dd5da58ccadde4a66087b3c257d151aec31 Author: Jakub Jelen <jj...@re...> Date: 2021-09-08 (Wed, 08 Sep 2021) Changed paths: M src/libopensc/card-openpgp.c Log Message: ----------- openpgp: Avoid memory leak Commit: e8c07dc2b31e735d984131cfca7199aedb750da5 https://github.com/OpenSC/OpenSC/commit/e8c07dc2b31e735d984131cfca7199aedb750da5 Author: Jakub Jelen <jj...@re...> Date: 2021-09-08 (Wed, 08 Sep 2021) Changed paths: M src/tests/p11test/p11test_case_common.c Log Message: ----------- p11test: Fix copy&paste error Commit: c486755f558978bf13cb9e9106da20902bafe711 https://github.com/OpenSC/OpenSC/commit/c486755f558978bf13cb9e9106da20902bafe711 Author: Jakub Jelen <jj...@re...> Date: 2021-09-08 (Wed, 08 Sep 2021) Changed paths: M src/libopensc/card-idprime.c Log Message: ----------- idprime: Avoid uninitialized key_reference on unknown card versions Commit: 6556e25c1522f3d542f07072164e8476590df342 https://github.com/OpenSC/OpenSC/commit/6556e25c1522f3d542f07072164e8476590df342 Author: Jakub Jelen <jj...@re...> Date: 2021-09-08 (Wed, 08 Sep 2021) Changed paths: M src/pkcs11/pkcs11-spy.c Log Message: ----------- pkcs11-spy: Avoid NULL pointer dereference Commit: dc9a152aa855c4dd5e6786ea36463bd24e1fe761 https://github.com/OpenSC/OpenSC/commit/dc9a152aa855c4dd5e6786ea36463bd24e1fe761 Author: Jakub Jelen <jj...@re...> Date: 2021-09-08 (Wed, 08 Sep 2021) Changed paths: M src/libopensc/sec.c Log Message: ----------- libopensc: Avoid NULL pointer dereference with wrong arguments Commit: 3983eb55a69d67ba07aa9b11d1ee9ee98ea57235 https://github.com/OpenSC/OpenSC/commit/3983eb55a69d67ba07aa9b11d1ee9ee98ea57235 Author: Jakub Jelen <jj...@re...> Date: 2021-09-08 (Wed, 08 Sep 2021) Changed paths: M src/tools/pkcs11-tool.c Log Message: ----------- pkcs11-tool: Avoid referencing variable in a structure that goes out of scope Commit: 5f9d04acd0c5830cfe4908d40444e4540eee6df4 https://github.com/OpenSC/OpenSC/commit/5f9d04acd0c5830cfe4908d40444e4540eee6df4 Author: Jakub Jelen <jj...@re...> Date: 2021-09-08 (Wed, 08 Sep 2021) Changed paths: M src/tests/p11test/p11test_case_readonly.c Log Message: ----------- p11test: Avoid double free on error Commit: 2495e90d752aadc56efca2da299626b9cf150133 https://github.com/OpenSC/OpenSC/commit/2495e90d752aadc56efca2da299626b9cf150133 Author: Jakub Jelen <jj...@re...> Date: 2021-09-08 (Wed, 08 Sep 2021) Changed paths: M src/tests/unittests/asn1.c Log Message: ----------- tests: Avoid memory leak from tests Commit: 1a8c5beef12f80be473283513de2d9ba67c98bee https://github.com/OpenSC/OpenSC/commit/1a8c5beef12f80be473283513de2d9ba67c98bee Author: Jakub Jelen <jj...@re...> Date: 2021-09-08 (Wed, 08 Sep 2021) Changed paths: M src/tests/p11test/p11test_case_ec_derive.c Log Message: ----------- p11test: Avoid memory leak on error Commit: e963651c59b1ea7ae01408c4e7e763c2feaf3a50 https://github.com/OpenSC/OpenSC/commit/e963651c59b1ea7ae01408c4e7e763c2feaf3a50 Author: Mladen Milinkovic <ma...@sm...> Date: 2021-09-08 (Wed, 08 Sep 2021) Changed paths: M src/libopensc/card-idprime.c Log Message: ----------- idprime: idprime_process_index() will read objects bigger than 256 bytes Commit: 08ab1b747cceb1f46730481cced3141dc7018bc5 https://github.com/OpenSC/OpenSC/commit/08ab1b747cceb1f46730481cced3141dc7018bc5 Author: Mladen Milinkovic <ma...@sm...> Date: 2021-09-08 (Wed, 08 Sep 2021) Changed paths: M src/libopensc/card-idprime.c Log Message: ----------- idprime: implement get_challenge and flag RNG support Commit: 683cbe004ce6469839e33f225d1f0b0b04f7c538 https://github.com/OpenSC/OpenSC/commit/683cbe004ce6469839e33f225d1f0b0b04f7c538 Author: Jakub Jelen <jj...@re...> Date: 2021-09-08 (Wed, 08 Sep 2021) Changed paths: M src/libopensc/reader-pcsc.c M src/tools/util.c Log Message: ----------- Detect hotplug events for both reader and card The tools util_connect_reader() with wait option worked only for readers inserted without the card and then the code would wait for separate card insert event. This is not always handy as USB tokens are getting more common and there is no distinction between reader and card (and no possibility to remove the card from reader. The code is adjusted in pscs driver to emit both reader & card events in case the card is present in the hotplug reader and this is handled in the tools. Commit: 097acbc72b538911a2da30d50817edbfdd4c56f7 https://github.com/OpenSC/OpenSC/commit/097acbc72b538911a2da30d50817edbfdd4c56f7 Author: Jakub Jelen <jj...@re...> Date: 2021-09-08 (Wed, 08 Sep 2021) Changed paths: M src/tests/p11test/p11test.c Log Message: ----------- p11test: Add missing switch to the usage Commit: dbd49bc9867d6c6f8ef54109adb428c8ca92614d https://github.com/OpenSC/OpenSC/commit/dbd49bc9867d6c6f8ef54109adb428c8ca92614d Author: Jakub Jelen <jj...@re...> Date: 2021-09-08 (Wed, 08 Sep 2021) Changed paths: M src/tools/pkcs11-tool.c Log Message: ----------- pkcs11-tool: Print human-redable profile names Commit: cf042ef6d37800cf54ab7c1db35776964d0cc512 https://github.com/OpenSC/OpenSC/commit/cf042ef6d37800cf54ab7c1db35776964d0cc512 Author: Jakub Jelen <jj...@re...> Date: 2021-09-08 (Wed, 08 Sep 2021) Changed paths: M src/tests/p11test/p11test_case_ec_sign.c M src/tests/p11test/p11test_case_readonly.c Log Message: ----------- p11test: Test also longer messages for EdDSA Commit: 0531499d0e8f05e8c842d2689b701530483a25e0 https://github.com/OpenSC/OpenSC/commit/0531499d0e8f05e8c842d2689b701530483a25e0 Author: Jakub Jelen <jj...@re...> Date: 2021-09-08 (Wed, 08 Sep 2021) Changed paths: A CONTRIBUTING.md A containers/README.md A containers/opensc-build/Containerfile A containers/opensc-test-cac/Containerfile A containers/opensc-test-piv/Containerfile Log Message: ----------- Describe how to run tests in container environment closest to Github Actions Commit: 82588d8f45edcf41053202d3b9ae59ec49fe95f1 https://github.com/OpenSC/OpenSC/commit/82588d8f45edcf41053202d3b9ae59ec49fe95f1 Author: Jakub Jelen <jj...@re...> Date: 2021-09-08 (Wed, 08 Sep 2021) Changed paths: M src/pkcs11/framework-pkcs15.c Log Message: ----------- pkcs11: Add a todo note Commit: a6a44721daeb20ee5e35087c2451940b189b4331 https://github.com/OpenSC/OpenSC/commit/a6a44721daeb20ee5e35087c2451940b189b4331 Author: Jakub Jelen <jj...@re...> Date: 2021-09-08 (Wed, 08 Sep 2021) Changed paths: M CONTRIBUTING.md Log Message: ----------- CONTRIBUTING: Use relative link Commit: 876898bff82f352ec3cdd7ef83a29ce1666ad94d https://github.com/OpenSC/OpenSC/commit/876898bff82f352ec3cdd7ef83a29ce1666ad94d Author: Jakub Jelen <jj...@re...> Date: 2021-09-08 (Wed, 08 Sep 2021) Changed paths: A containers/opensc-mingw/Containerfile Log Message: ----------- Add mingw container for testing Commit: f0afd1711d8c83f3460269ea6f30cc321f19130b https://github.com/OpenSC/OpenSC/commit/f0afd1711d8c83f3460269ea6f30cc321f19130b Author: Jakub Jelen <jj...@re...> Date: 2021-09-08 (Wed, 08 Sep 2021) Changed paths: M .github/build.sh Log Message: ----------- .github: Default to verbose make Commit: a00ead5bcaeef9761287572f7b62065d62c211d9 https://github.com/OpenSC/OpenSC/commit/a00ead5bcaeef9761287572f7b62065d62c211d9 Author: Jakub Jelen <jj...@re...> Date: 2021-09-08 (Wed, 08 Sep 2021) Changed paths: M src/libopensc/Makefile.am M src/pkcs11/Makefile.am M src/tools/Makefile.am Log Message: ----------- libopensc: Unbreak build with mingw Related to #2294 Compare: https://github.com/OpenSC/OpenSC/compare/25668451389d...a00ead5bcaee |
