[Opensc-commits] [OpenSC/OpenSC] 456ac5: PIV Improved parsing of data from the card

[Doug E. <no...@gi...>]

  Branch: refs/heads/master
  Home:   https://github.com/OpenSC/OpenSC
  Commit: 456ac566938a1da774db06126a2fa6c0cba514b3
      https://github.com/OpenSC/OpenSC/commit/456ac566938a1da774db06126a2fa6c0cba514b3
  Author: Doug Engert <dee...@gm...>
  Date:   2021-08-04 (Wed, 04 Aug 2021)

  Changed paths:
    M src/libopensc/card-piv.c

  Log Message:
  -----------
  PIV Improved parsing of data from the card

Based on Fuzz testing, many of the calls to sc_asn1_find_tag were replaced
with sc_asn1_read_tag. The input is also tested that the
expected tag is  the first byte. Additional tests are also add.

sc_asn1_find_tag will skip 0X00 or 0Xff if found. NIST sp800-73-x specs
do not allow these extra bytes.

 On branch PIV-improved-parsing
 Changes to be committed:
	modified:   card-piv.c


  Commit: 445a6324de8bcca4de6787875efe1052472704ac
      https://github.com/OpenSC/OpenSC/commit/445a6324de8bcca4de6787875efe1052472704ac
  Author: Doug Engert <dee...@gm...>
  Date:   2021-08-04 (Wed, 04 Aug 2021)

  Changed paths:
    M src/libopensc/card-piv.c

  Log Message:
  -----------
  Remove unused code

two lines that are never executed are removed for the code.
The LOG_TEST_GOTO_ERR before these lines will goto err.

 On branch PIV-improved-parsing
 Changes to be committed:
	modified:   src/libopensc/card-piv.c


  Commit: c6a9b5699a39835147a5097044ba63627638b93a
      https://github.com/OpenSC/OpenSC/commit/c6a9b5699a39835147a5097044ba63627638b93a
  Author: Doug Engert <dee...@gm...>
  Date:   2021-08-04 (Wed, 04 Aug 2021)

  Changed paths:
    M src/libopensc/card-piv.c

  Log Message:
  -----------
  PIV-improved parsing - fix two whilhspace nits

 On branch PIV-improved-parsing
 Changes to be committed:
	modified:   card-piv.c


Compare: https://github.com/OpenSC/OpenSC/compare/8453c0d99a49...c6a9b5699a39