[Opensc-commits] [OpenSC/OpenSC] 0df0f8: IASECC: log any APDU Incorrect parameters

[Vincent J. <no...@gi...>]

  Branch: refs/heads/master
  Home:   https://github.com/OpenSC/OpenSC
  Commit: 0df0f80b552d99e42082121035281b8c70fad2dd
      https://github.com/OpenSC/OpenSC/commit/0df0f80b552d99e42082121035281b8c70fad2dd
  Author: Vincent JARDIN <vj...@fr...>
  Date:   2021-04-01 (Thu, 01 Apr 2021)

  Changed paths:
    M src/libopensc/card-iasecc.c

  Log Message:
  -----------
  IASECC: log any APDU Incorrect parameters

>From the logs, we can detect many 6A 86 (Incorrect P1 or P2 paremeters).
A deeper analysis will be required, but the best option to check them
is to start emitting any Warning for such events.


  Commit: 1a3666364dc434f4bbfd4154012c5d4e4dc23cb2
      https://github.com/OpenSC/OpenSC/commit/1a3666364dc434f4bbfd4154012c5d4e4dc23cb2
  Author: Vincent JARDIN <vj...@fr...>
  Date:   2021-04-01 (Thu, 01 Apr 2021)

  Changed paths:
    M src/libopensc/card-iasecc.c

  Log Message:
  -----------
  IASECC/CPX: Avoid APDU Incorrect Parameters

Without this patch, we would get from the logs:
Outgoing APDU (18 bytes):
00 A4 04 00 0D E8 28 BD 08 0F 80 25 00 00 01 FF ......(....%....
00 10                                           ..
 [opensc-pkcs11] reader-pcsc.c:242:pcsc_internal_transmit: called
 [opensc-pkcs11] reader-pcsc.c:333:pcsc_transmit:
Incoming APDU (2 bytes):
6A 86 j.
 [opensc-pkcs11] apdu.c:382:sc_single_transmit: returning with: 0 (Success)
 [opensc-pkcs11] apdu.c:537:sc_transmit: returning with: 0 (Success)
 [opensc-pkcs11] card.c:523:sc_unlock: called
 [opensc-pkcs11] iso7816.c:128:iso7816_check_sw: Incorrect parameters P1-P2
 [opensc-pkcs11] card-iasecc.c:1064:iasecc_select_file: Warning: SC_ERROR_INCORRECT_PARAMETERS for SC_PATH_TYPE_DF_NAME, try again with P2=0x0C
 [opensc-pkcs11] apdu.c:548:sc_transmit_apdu: called
 [opensc-pkcs11] card.c:473:sc_lock: called
 [opensc-pkcs11] card.c:513:sc_lock: returning with: 0 (Success)
 [opensc-pkcs11] apdu.c:515:sc_transmit: called
 [opensc-pkcs11] apdu.c:363:sc_single_transmit: called
 [opensc-pkcs11] apdu.c:367:sc_single_transmit: CLA:0, INS:A4, P1:4, P2:C, data(13) 0x7fff4b339b20
 [opensc-pkcs11] reader-pcsc.c:323:pcsc_transmit: reader 'Ingenico TL TELIUM (25005334) 00 02'
 [opensc-pkcs11] reader-pcsc.c:324:pcsc_transmit:
Outgoing APDU (18 bytes):
00 A4 04 0C 0D E8 28 BD 08 0F 80 25 00 00 01 FF ......(....%....
00 10                                           ..
 [opensc-pkcs11] reader-pcsc.c:242:pcsc_internal_transmit: called
 [opensc-pkcs11] reader-pcsc.c:333:pcsc_transmit:
Incoming APDU (2 bytes):
90 00 ..

Let's align it with the behaviour of the other IASECC cards.


Compare: https://github.com/OpenSC/OpenSC/compare/b9c0addf882e...1a3666364dc4