[Opensc-commits] [OpenSC/OpenSC] f726d4: Improve logging mostly in opengpg

SourceForge Headquarters 225 Broadway Suite 1600 San Diego, CA 92101 +1 (858) 422-6466

  Branch: refs/heads/master
  Home:   https://github.com/OpenSC/OpenSC
  Commit: f726d4f20121d034b22927f6085a263f9a317b8c
      https://github.com/OpenSC/OpenSC/commit/f726d4f20121d034b22927f6085a263f9a317b8c
  Author: Jakub Jelen <jj...@re...>
  Date:   2021-03-01 (Mon, 01 Mar 2021)

  Changed paths:
    M src/libopensc/card-openpgp.c
    M src/libopensc/pkcs15-openpgp.c
    M src/libopensc/pkcs15-sec.c
    M src/libopensc/sec.c

  Log Message:
  -----------
  Improve logging mostly in opengpg

  Commit: 86e01d7c47644cd33fc8a71cc9bbf236f1b37f34
      https://github.com/OpenSC/OpenSC/commit/86e01d7c47644cd33fc8a71cc9bbf236f1b37f34
  Author: Jakub Jelen <jj...@re...>
  Date:   2021-03-01 (Mon, 01 Mar 2021)

  Changed paths:
    M src/pkcs11/debug.c

  Log Message:
  -----------
  pkcs11: Prefer CKA_EC_PARAMS over deprecated CKA_ECDSA_PARAMS by listing it first in the list

  Commit: e82f8750476947452fb47fca42c0fca9ed237ac0
      https://github.com/OpenSC/OpenSC/commit/e82f8750476947452fb47fca42c0fca9ed237ac0
  Author: Jakub Jelen <jj...@re...>
  Date:   2021-03-01 (Mon, 01 Mar 2021)

  Changed paths:
    M src/pkcs11/pkcs11-spy.c

  Log Message:
  -----------
  pkcs11-spy: Systematize output of C_GetMechanismInfo

  Commit: a5a6757d1002126ed67aac71402c43ff2dae976c
      https://github.com/OpenSC/OpenSC/commit/a5a6757d1002126ed67aac71402c43ff2dae976c
  Author: Jakub Jelen <jj...@re...>
  Date:   2021-03-01 (Mon, 01 Mar 2021)

  Changed paths:
    M src/tools/pkcs11-tool.c

  Log Message:
  -----------
  pkcs11-tool: Add CKA_KEY_TYPE attribute for keygen as recommeneded in specification

  Commit: a30bf95eed1686416111ffa27dc4ff8947790d15
      https://github.com/OpenSC/OpenSC/commit/a30bf95eed1686416111ffa27dc4ff8947790d15
  Author: Jakub Jelen <jj...@re...>
  Date:   2021-03-01 (Mon, 01 Mar 2021)

  Changed paths:
    M src/libopensc/card-openpgp.c

  Log Message:
  -----------
  openpgp: Fix typo in the card name

  Commit: c78fa164c9e27b82b50cc54453cd5063583718f0
      https://github.com/OpenSC/OpenSC/commit/c78fa164c9e27b82b50cc54453cd5063583718f0
  Author: Jakub Jelen <jj...@re...>
  Date:   2021-03-01 (Mon, 01 Mar 2021)

  Changed paths:
    M src/tools/openpgp-tool.c

  Log Message:
  -----------
  openpgp-tool: Fix typos OpenGPG -> OpenPGP

  Commit: 0455a5665e6ea17cb8c255df9585a6c210597ac1
      https://github.com/OpenSC/OpenSC/commit/0455a5665e6ea17cb8c255df9585a6c210597ac1
  Author: Jakub Jelen <jj...@re...>
  Date:   2021-03-01 (Mon, 01 Mar 2021)

  Changed paths:
    M src/libopensc/internal-winscard.h

  Log Message:
  -----------
  winscard: Add missing constant define

  Commit: 095c28e3726a96a49342c7b341049372b80225b8
      https://github.com/OpenSC/OpenSC/commit/095c28e3726a96a49342c7b341049372b80225b8
  Author: Jakub Jelen <jj...@re...>
  Date:   2021-03-01 (Mon, 01 Mar 2021)

  Changed paths:
    M src/pkcs11/pkcs11.h

  Log Message:
  -----------
  pkcs11: Add new (X)EDDSA identifiers

  Commit: 80f80317d1ea60c3c2417853ce4f21090f4c0905
      https://github.com/OpenSC/OpenSC/commit/80f80317d1ea60c3c2417853ce4f21090f4c0905
  Author: Jakub Jelen <jj...@re...>
  Date:   2021-03-01 (Mon, 01 Mar 2021)

  Changed paths:
    M src/pkcs11/pkcs11.h

  Log Message:
  -----------
  pkcs11: Add new SHA3 identifiers

  Commit: caae75758c6b556d12c2753a9ce6ebeb977a9089
      https://github.com/OpenSC/OpenSC/commit/caae75758c6b556d12c2753a9ce6ebeb977a9089
  Author: Jakub Jelen <jj...@re...>
  Date:   2021-03-01 (Mon, 01 Mar 2021)

  Changed paths:
    M src/libopensc/card.c
    M src/libopensc/cardctl.h
    M src/libopensc/internal.h
    M src/libopensc/libopensc.exports
    M src/libopensc/opensc.h
    M src/libopensc/pkcs15-algo.c
    M src/libopensc/pkcs15-prkey.c
    M src/libopensc/pkcs15-pubkey.c
    M src/libopensc/pkcs15-sec.c
    M src/libopensc/pkcs15-syn.c
    M src/libopensc/pkcs15.h
    M src/pkcs11/debug.c
    M src/pkcs11/framework-pkcs15.c
    M src/pkcs11/mechanism.c
    M src/pkcs11/pkcs11-display.c
    M src/pkcs11/pkcs11-object.c
    M src/pkcs11/pkcs11.h

  Log Message:
  -----------
  Add internal support for (X)EdDSA keys

  Commit: b351bf5ea4c0004ef444a7a7147b57fd5a715c23
      https://github.com/OpenSC/OpenSC/commit/b351bf5ea4c0004ef444a7a7147b57fd5a715c23
  Author: Jakub Jelen <jj...@re...>
  Date:   2021-03-01 (Mon, 01 Mar 2021)

  Changed paths:
    M src/libopensc/card-openpgp.c
    M src/libopensc/card-openpgp.h
    M src/libopensc/pkcs15-openpgp.c
    M src/pkcs15init/pkcs15-openpgp.c

  Log Message:
  -----------
  openpgp: Initial support for (X)EdDSA keys

  Commit: 2fb688683e284fadcac782da68907a87beb3adee
      https://github.com/OpenSC/OpenSC/commit/2fb688683e284fadcac782da68907a87beb3adee
  Author: Jakub Jelen <jj...@re...>
  Date:   2021-03-01 (Mon, 01 Mar 2021)

  Changed paths:
    M src/tools/pkcs15-tool.c

  Log Message:
  -----------
  pkcs15-tool: Support for new (X)EdDSA keys

  Commit: 5178e74e1b45098671f972c1471a97b104655686
      https://github.com/OpenSC/OpenSC/commit/5178e74e1b45098671f972c1471a97b104655686
  Author: Jakub Jelen <jj...@re...>
  Date:   2021-03-01 (Mon, 01 Mar 2021)

  Changed paths:
    M src/tools/pkcs11-tool.c

  Log Message:
  -----------
  pkcs11-tool: Support for new (X)EdDSA keys

  Commit: 5d5c39179377da4d2994afb1079b523f498bfaba
      https://github.com/OpenSC/OpenSC/commit/5d5c39179377da4d2994afb1079b523f498bfaba
  Author: Jakub Jelen <jj...@re...>
  Date:   2021-03-01 (Mon, 01 Mar 2021)

  Changed paths:
    M src/tools/opensc-tool.c

  Log Message:
  -----------
  opensc-tool: Support for new (X)EdDSA keys

  Commit: a965829f526f4abb4f33687c4f6f682b7fa27c92
      https://github.com/OpenSC/OpenSC/commit/a965829f526f4abb4f33687c4f6f682b7fa27c92
  Author: Jakub Jelen <jj...@re...>
  Date:   2021-03-01 (Mon, 01 Mar 2021)

  Changed paths:
    M src/libopensc/card-openpgp.c

  Log Message:
  -----------
  openpgp: Use only Derive mechanism for curve25519 keys

  Commit: e7d390f9dd4cda46f589f674c34f61ff69dff2c0
      https://github.com/OpenSC/OpenSC/commit/e7d390f9dd4cda46f589f674c34f61ff69dff2c0
  Author: Jakub Jelen <jj...@re...>
  Date:   2021-03-01 (Mon, 01 Mar 2021)

  Changed paths:
    M src/libopensc/card-openpgp.c

  Log Message:
  -----------
  openpgp: Unbreak EC algorithms for GNUK

Since 09a594d bringing ECC support to openPGP card, it did not count
with GNUK. This adds exception for GNUK to unbreak ECC signatures
as GNUK presents BCD version < 3.

  Commit: 32ec1f92b9f1ff134ee74677a449d87c68d1c01d
      https://github.com/OpenSC/OpenSC/commit/32ec1f92b9f1ff134ee74677a449d87c68d1c01d
  Author: Jakub Jelen <jj...@re...>
  Date:   2021-03-01 (Mon, 01 Mar 2021)

  Changed paths:
    M src/libopensc/card-openpgp.c
    M src/libopensc/pkcs15-openpgp.c

  Log Message:
  -----------
  openpgp: Set reasonable usage for (X)EdDSA keys

  Commit: 485b6cff44a9fd3094b6644a5f800fa91a8221f7
      https://github.com/OpenSC/OpenSC/commit/485b6cff44a9fd3094b6644a5f800fa91a8221f7
  Author: Jakub Jelen <jj...@re...>
  Date:   2021-03-01 (Mon, 01 Mar 2021)

  Changed paths:
    M src/tests/p11test/p11test_case_common.c
    M src/tests/p11test/p11test_case_common.h
    M src/tests/p11test/p11test_case_ec_derive.c
    M src/tests/p11test/p11test_case_mechs.c
    M src/tests/p11test/p11test_case_multipart.c
    M src/tests/p11test/p11test_case_readonly.c
    M src/tests/p11test/p11test_case_usage.c
    M src/tests/p11test/p11test_common.h

  Log Message:
  -----------
  p11test: Add support for EdDSA keys

  Commit: 35cfc291ce950c02ba2e700dd4159b1b162fa2a4
      https://github.com/OpenSC/OpenSC/commit/35cfc291ce950c02ba2e700dd4159b1b162fa2a4
  Author: Jakub Jelen <jj...@re...>
  Date:   2021-03-01 (Mon, 01 Mar 2021)

  Changed paths:
    M src/tools/pkcs11-tool.c

  Log Message:
  -----------
  pkcs11-tool: Add support for (X)EDDSA key generation

  Commit: 091b7670ebfc3c2aab379777cc02d44255fb4a09
      https://github.com/OpenSC/OpenSC/commit/091b7670ebfc3c2aab379777cc02d44255fb4a09
  Author: Jakub Jelen <jj...@re...>
  Date:   2021-03-01 (Mon, 01 Mar 2021)

  Changed paths:
    M src/tests/p11test/runtest.sh

  Log Message:
  -----------
  p11test: Reformat the script and allow running against softhsm ed25519 keys (with few tweaks)

The Ed25519 implementation in SoftHSM is now broken /non-interoperable. After fixing that,
the interoperability tests should work with this script:

 * SoftHSMv2#528: Avoid creating duplicate mechanisms
 * SoftHSMv2#522: Fix advertised min and max mechanism sizes according to final PKCS#11 3.0 specification
 * SoftHSMv2#526: Adjust EDDSA code to return valid EC_PARAMS according to the final PKCS #11 3.0 specification

  Commit: 0380142482c9a4dd77c2c3d1c5c5216b65b8d912
      https://github.com/OpenSC/OpenSC/commit/0380142482c9a4dd77c2c3d1c5c5216b65b8d912
  Author: Doug Engert <dee...@gm...>
  Date:   2021-03-01 (Mon, 01 Mar 2021)

  Changed paths:
    M src/libopensc/card.c
    M src/libopensc/pkcs15-openpgp.c

  Log Message:
  -----------
  Fix obtaining key_length i.e. field_length pkcs15-openpgp

card-opennpgp.c and pkcs15-openpgp.c have a strang way of
using sc_object_id_t to store what they call a binary_oid
or oid_binary.  It is used to convert the EC curve asn1
returned in the cxdata.

This code uses asn1_decode_object_id to use sc_object_id_t
as used in the rest of the code.

The code and ec_curve tabes in card-openpgp.c where not changed.

pkcs15-openpgp.c was channge si to can use:
algorithm_info = sc_card_find_ec_alg(card, 0, &oid);
to retried the key_length to add to the pubkey and prkey entries.
The EC and EDDSA needs (i.e. field_length)  to run.

 On branch eddsa
 Your branch is up to date with 'Jakuje/eddsa'.

 Changes to be committed:
	modified:   card.c
	modified:   pkcs15-openpgp.c

  Commit: 8c4d3255762d770dbbedb65c5c09846ddf3b339a
      https://github.com/OpenSC/OpenSC/commit/8c4d3255762d770dbbedb65c5c09846ddf3b339a
  Author: Jakub Jelen <jj...@re...>
  Date:   2021-03-01 (Mon, 01 Mar 2021)

  Changed paths:
    M src/pkcs11/framework-pkcs15.c

  Log Message:
  -----------
  framework-pkcs15: Fix typo in comment

  Commit: 9bd139d1e49096d3c20642cb9f51b9bcd0222def
      https://github.com/OpenSC/OpenSC/commit/9bd139d1e49096d3c20642cb9f51b9bcd0222def
  Author: Jakub Jelen <jj...@re...>
  Date:   2021-03-01 (Mon, 01 Mar 2021)

  Changed paths:
    M src/libopensc/pkcs15-openpgp.c

  Log Message:
  -----------
  openpgp: Check return code of OID decoding from ASN1

  Commit: 64b61a755693044e197aaeff35ec99abc41d87d9
      https://github.com/OpenSC/OpenSC/commit/64b61a755693044e197aaeff35ec99abc41d87d9
  Author: Jakub Jelen <jj...@re...>
  Date:   2021-03-01 (Mon, 01 Mar 2021)

  Changed paths:
    M src/libopensc/pkcs15-openpgp.c

  Log Message:
  -----------
  openpgp: Do not fail hard if unknown algorithm is encountered and fix typo

  Commit: 73e283b4b1c57c9a556c24b4f8f17a19b04312c9
      https://github.com/OpenSC/OpenSC/commit/73e283b4b1c57c9a556c24b4f8f17a19b04312c9
  Author: Jakub Jelen <jj...@re...>
  Date:   2021-03-01 (Mon, 01 Mar 2021)

  Changed paths:
    M src/libopensc/card.c
    M src/libopensc/pkcs15-openpgp.c

  Log Message:
  -----------
  openpgp: Correctly handle curve25519 keys

  Commit: a020b85d943bd1c1a892b31a27b3c41e15727f97
      https://github.com/OpenSC/OpenSC/commit/a020b85d943bd1c1a892b31a27b3c41e15727f97
  Author: Jakub Jelen <jj...@re...>
  Date:   2021-03-01 (Mon, 01 Mar 2021)

  Changed paths:
    M src/tests/unittests/asn1.c

  Log Message:
  -----------
  unittests: Briefly test asn1_encode

  Commit: cb8c7647ca4381273765ea6d5de750940e2ab248
      https://github.com/OpenSC/OpenSC/commit/cb8c7647ca4381273765ea6d5de750940e2ab248
  Author: Jakub Jelen <jj...@re...>
  Date:   2021-03-01 (Mon, 01 Mar 2021)

  Changed paths:
    M src/libopensc/asn1.c

  Log Message:
  -----------
  asn1: Do not crash on invalid arguments

  Commit: ae771a135f921f18905a5d9cda8fb6700a5f0be4
      https://github.com/OpenSC/OpenSC/commit/ae771a135f921f18905a5d9cda8fb6700a5f0be4
  Author: Jakub Jelen <jj...@re...>
  Date:   2021-03-01 (Mon, 01 Mar 2021)

  Changed paths:
    M src/libopensc/card-openpgp.c

  Log Message:
  -----------
  openpgp: Rewrite decipher/derive to use asn1 functions

  Commit: c39e31b274b8325d6ce6cd57aaa5eb73f869c635
      https://github.com/OpenSC/OpenSC/commit/c39e31b274b8325d6ce6cd57aaa5eb73f869c635
  Author: Jakub Jelen <jj...@re...>
  Date:   2021-03-01 (Mon, 01 Mar 2021)

  Changed paths:
    M src/pkcs11/framework-pkcs15.c

  Log Message:
  -----------
  pkcs11: Rewrite ec params to use sc_asn1_put_tag()

  Commit: 56af7de137fbae073c6b71a9707aa2e22bd961a1
      https://github.com/OpenSC/OpenSC/commit/56af7de137fbae073c6b71a9707aa2e22bd961a1
  Author: Jakub Jelen <jj...@re...>
  Date:   2021-03-01 (Mon, 01 Mar 2021)

  Changed paths:
    M src/pkcs11/framework-pkcs15.c
    M src/tests/p11test/p11test_case_common.c
    M src/tools/pkcs11-tool.c

  Log Message:
  -----------
  Change (X)EDDSA EC_PARAMS encoding to OID

This is the current interpretation of the specs after talking with
several members of PKCS #11 TC.

  Commit: 0ce245a41187c399c15e56be3010d5d8b20484c9
      https://github.com/OpenSC/OpenSC/commit/0ce245a41187c399c15e56be3010d5d8b20484c9
  Author: Jakub Jelen <jj...@re...>
  Date:   2021-03-01 (Mon, 01 Mar 2021)

  Changed paths:
    M src/tests/p11test/p11test_case_common.c

  Log Message:
  -----------
  p11test: Fix one-off comparison

  Commit: b8266a4c86e06bec9e3d150e688efcd96b0721e1
      https://github.com/OpenSC/OpenSC/commit/b8266a4c86e06bec9e3d150e688efcd96b0721e1
  Author: Jakub Jelen <jj...@re...>
  Date:   2021-03-01 (Mon, 01 Mar 2021)

  Changed paths:
    M src/libopensc/card-openpgp.c
    M win32/customactions.cpp

  Log Message:
  -----------
  Revert "fixed atrmask for gnuk"

This reverts commit 98beb86a389f9186b2bf9a0f18350a988ad64f1b.

  Commit: 5f9085fedb5fba3695f90da4efdbdec7a136a4e8
      https://github.com/OpenSC/OpenSC/commit/5f9085fedb5fba3695f90da4efdbdec7a136a4e8
  Author: Frank Morgner <fra...@gm...>
  Date:   2021-03-22 (Mon, 22 Mar 2021)

  Changed paths:
    M src/libopensc/asn1.c
    M src/libopensc/card-openpgp.c
    M src/libopensc/card-openpgp.h
    M src/libopensc/card.c
    M src/libopensc/cardctl.h
    M src/libopensc/internal-winscard.h
    M src/libopensc/internal.h
    M src/libopensc/libopensc.exports
    M src/libopensc/opensc.h
    M src/libopensc/pkcs15-algo.c
    M src/libopensc/pkcs15-openpgp.c
    M src/libopensc/pkcs15-prkey.c
    M src/libopensc/pkcs15-pubkey.c
    M src/libopensc/pkcs15-sec.c
    M src/libopensc/pkcs15-syn.c
    M src/libopensc/pkcs15.h
    M src/libopensc/sec.c
    M src/pkcs11/debug.c
    M src/pkcs11/framework-pkcs15.c
    M src/pkcs11/mechanism.c
    M src/pkcs11/pkcs11-display.c
    M src/pkcs11/pkcs11-object.c
    M src/pkcs11/pkcs11-spy.c
    M src/pkcs11/pkcs11.h
    M src/pkcs15init/pkcs15-openpgp.c
    M src/tests/p11test/p11test_case_common.c
    M src/tests/p11test/p11test_case_common.h
    M src/tests/p11test/p11test_case_ec_derive.c
    M src/tests/p11test/p11test_case_mechs.c
    M src/tests/p11test/p11test_case_multipart.c
    M src/tests/p11test/p11test_case_readonly.c
    M src/tests/p11test/p11test_case_usage.c
    M src/tests/p11test/p11test_common.h
    M src/tests/p11test/runtest.sh
    M src/tests/unittests/asn1.c
    M src/tools/openpgp-tool.c
    M src/tools/opensc-tool.c
    M src/tools/pkcs11-tool.c
    M src/tools/pkcs15-tool.c
    M win32/customactions.cpp

  Log Message:
  -----------
  Merge pull request #1960 from Jakuje/eddsa

Add support for (X)EdDSA keys in OpenPGP driver

Compare: https://github.com/OpenSC/OpenSC/compare/845eac425093...5f9085fedb5f

[Opensc-commits] [OpenSC/OpenSC] f726d4: Improve logging mostly in opengpg

OpenSC - tools and libraries for smart cards

[Opensc-commits] [OpenSC/OpenSC] f726d4: Improve logging mostly in opengpg