[Opensc-commits] [OpenSC/OpenSC] 304455: openpgp: fix DO deletion

[alt3r 3. <no...@gi...>]

  Branch: refs/heads/master
  Home:   https://github.com/OpenSC/OpenSC
  Commit: 3044557299a1524251bed74b8ab6a8bcdd98b2c2
      https://github.com/OpenSC/OpenSC/commit/3044557299a1524251bed74b8ab6a8bcdd98b2c2
  Author: alt3r 3go <alt...@pr...>
  Date:   2021-02-16 (Tue, 16 Feb 2021)

  Changed paths:
    M src/libopensc/card-openpgp.c

  Log Message:
  -----------
  openpgp: fix DO deletion

This fixes a problem reported in Nitrokey forum at

https://support.nitrokey.com/t/veracrypt-encryption-with-nitrokey-error/2872

as inability to save the VeraCrypt's keyfile onto the token
after deleting an existing one, unless the PKCS11 is reinitialized.

Reason: commit cbc53b9 "OpenPGP: Support write certificate for Gnuk"
introduced a condition on getting the blob handle, which is surplus
(the pgp_find_blob() function actually does that) and prevents
the blob refresh upon deletion, breaking the logic introduced
earlier in commit 9e04ae4 and causing the higher-level effect reported.

While at it, corrected comments to actually reflect the flow logic.

Tested on Fedora 33 using the repro steps from the forum and Nitrokey Pro.

Signed-off-by: alt3r 3go <alt...@pr...>