[Opensc-commits] [OpenSC/OpenSC] f7b0ce: Remove duplicate symbols from libopensc.exports

[Jakub J. <no...@gi...>]

  Branch: refs/heads/master
  Home:   https://github.com/OpenSC/OpenSC
  Commit: f7b0ce3dacb0fb3feca7f3065b126af84c26c100
      https://github.com/OpenSC/OpenSC/commit/f7b0ce3dacb0fb3feca7f3065b126af84c26c100
  Author: Jakub Jelen <jj...@re...>
  Date:   2021-01-06 (Wed, 06 Jan 2021)

  Changed paths:
    M src/libopensc/libopensc.exports

  Log Message:
  -----------
  Remove duplicate symbols from libopensc.exports


  Commit: 88543529a20cb3b95b0b8dfcf366957ea3b80596
      https://github.com/OpenSC/OpenSC/commit/88543529a20cb3b95b0b8dfcf366957ea3b80596
  Author: Jakub Jelen <jj...@re...>
  Date:   2021-01-06 (Wed, 06 Jan 2021)

  Changed paths:
    M src/pkcs11/pkcs11.exports

  Log Message:
  -----------
  pkcs11.exports: Remove duplicate symbols


  Commit: b48696539dc58ccf98db461c67aa4559329c8603
      https://github.com/OpenSC/OpenSC/commit/b48696539dc58ccf98db461c67aa4559329c8603
  Author: Jakub Jelen <jj...@re...>
  Date:   2021-01-06 (Wed, 06 Jan 2021)

  Changed paths:
    M tests/Makefile.am
    A tests/test-duplicate-symbols.sh

  Log Message:
  -----------
  tests: Verify there are no duplicate symbols exported


  Commit: 66f274dcaf2826295f98d6e212bf12ffef8b9162
      https://github.com/OpenSC/OpenSC/commit/66f274dcaf2826295f98d6e212bf12ffef8b9162
  Author: Jakub Jelen <jj...@re...>
  Date:   2021-01-06 (Wed, 06 Jan 2021)

  Changed paths:
    M src/pkcs15init/pkcs15-authentic.c

  Log Message:
  -----------
  authentic: Fix copy&paste error in log message


  Commit: 049b2a87543b48cd119341637c8c0529aa511903
      https://github.com/OpenSC/OpenSC/commit/049b2a87543b48cd119341637c8c0529aa511903
  Author: Jakub Jelen <jj...@re...>
  Date:   2021-01-06 (Wed, 06 Jan 2021)

  Changed paths:
    M src/libopensc/pkcs15.c

  Log Message:
  -----------
  pkcs15: Do not override tokeninfo in bind_internal

Thanks oss-fuzz

https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=28550


  Commit: 3135fccdca3e45934e99534dc270113451e03f3c
      https://github.com/OpenSC/OpenSC/commit/3135fccdca3e45934e99534dc270113451e03f3c
  Author: Jakub Jelen <jj...@re...>
  Date:   2021-01-06 (Wed, 06 Jan 2021)

  Changed paths:
    M src/libopensc/card-itacns.c

  Log Message:
  -----------
  itacns: Correctly free allocated memory

Thanks oss-fuzz

https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=28510


  Commit: d25009cde6f6d624bfbee8203db779142cd8cd78
      https://github.com/OpenSC/OpenSC/commit/d25009cde6f6d624bfbee8203db779142cd8cd78
  Author: Jakub Jelen <jj...@re...>
  Date:   2021-01-06 (Wed, 06 Jan 2021)

  Changed paths:
    M src/libopensc/card-belpic.c

  Log Message:
  -----------
  belpic: Remove unused variable

Thanks clang

/src/libopensc/card-belpic.c:230:7: warning: Although the value stored to 'r' is used in the enclosing expression, the value is never actually read from 'r' [clang-analyzer-deadcode.DeadStores]
                if((r = get_carddata(card, carddata, sizeof(carddata))) < 0) {
                    ^
/src/libopensc/card-belpic.c:230:7: note: Although the value stored to 'r' is used in the enclosing expression, the value is never actually read from 'r'


  Commit: 9cda87e200bbe95e78055b3d2254878307cb12a7
      https://github.com/OpenSC/OpenSC/commit/9cda87e200bbe95e78055b3d2254878307cb12a7
  Author: Jakub Jelen <jj...@re...>
  Date:   2021-01-06 (Wed, 06 Jan 2021)

  Changed paths:
    M src/libopensc/card-authentic.c

  Log Message:
  -----------
  authentic: Initialize structure to avoid comparison against garbage

Thanks clang:

/src/libopensc/card-authentic.c:1564:47: warning: The left operand of '==' is a garbage value [clang-analyzer-core.UndefinedBinaryOperatorResult]
        if (acls[AUTHENTIC_ACL_NUM_PIN_RESET].method == SC_AC_CHV)   {
                                                     ^


  Commit: 910020aeecf8f991be4dcd399ffbcc054b97fd2d
      https://github.com/OpenSC/OpenSC/commit/910020aeecf8f991be4dcd399ffbcc054b97fd2d
  Author: Jakub Jelen <jj...@re...>
  Date:   2021-01-06 (Wed, 06 Jan 2021)

  Changed paths:
    M configure.ac
    M src/common/Makefile.am
    M src/libopensc/Makefile.am
    M src/pkcs11/Makefile.am

  Log Message:
  -----------
  Ignore non-useful check in clang-tidy as we have ton of memset/memcpy


  Commit: c7c689c74d7a4731032f913aabd79e33aa41e4bd
      https://github.com/OpenSC/OpenSC/commit/c7c689c74d7a4731032f913aabd79e33aa41e4bd
  Author: Jakub Jelen <jj...@re...>
  Date:   2021-01-06 (Wed, 06 Jan 2021)

  Changed paths:
    M .travis.yml

  Log Message:
  -----------
  .travis.yml: Install clang-tidy to run some static code analysis early


  Commit: 23eb606d862328f4293fd890d5528216a4bb10c1
      https://github.com/OpenSC/OpenSC/commit/23eb606d862328f4293fd890d5528216a4bb10c1
  Author: Jakub Jelen <jj...@re...>
  Date:   2021-01-06 (Wed, 06 Jan 2021)

  Changed paths:
    M .travis.yml

  Log Message:
  -----------
  Print testsuite logs on error


Compare: https://github.com/OpenSC/OpenSC/compare/f443c391b03d...23eb606d8623