[Opensc-commits] [OpenSC/OpenSC] fea08d: coolkey: Avoid memory leak

[Jakub J. <no...@gi...>]

  Branch: refs/heads/master
  Home:   https://github.com/OpenSC/OpenSC
  Commit: fea08d749d256a3974185d191878cb369296d8a3
      https://github.com/OpenSC/OpenSC/commit/fea08d749d256a3974185d191878cb369296d8a3
  Author: Jakub Jelen <jj...@re...>
  Date:   2020-07-07 (Tue, 07 Jul 2020)

  Changed paths:
    M src/libopensc/card-coolkey.c

  Log Message:
  -----------
  coolkey: Avoid memory leak

Thanks oss-fuzz

https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=23251


  Commit: 3696331d5c97b39e3a2ee642f5ae0a2ae33bc6c1
      https://github.com/OpenSC/OpenSC/commit/3696331d5c97b39e3a2ee642f5ae0a2ae33bc6c1
  Author: Jakub Jelen <jj...@re...>
  Date:   2020-07-07 (Tue, 07 Jul 2020)

  Changed paths:
    M src/libopensc/pkcs15-atrust-acos.c
    M src/libopensc/pkcs15-esinit.c
    M src/libopensc/pkcs15-gemsafeV1.c
    M src/libopensc/pkcs15-starcert.c
    M src/libopensc/pkcs15-westcos.c

  Log Message:
  -----------
  Remove more needless checks for NULL before free


  Commit: 56f4c6c34acef42237d68da8836639d9a5eea7e9
      https://github.com/OpenSC/OpenSC/commit/56f4c6c34acef42237d68da8836639d9a5eea7e9
  Author: Jakub Jelen <jj...@re...>
  Date:   2020-07-07 (Tue, 07 Jul 2020)

  Changed paths:
    M src/libopensc/pkcs15-piv.c

  Log Message:
  -----------
  piv: Free pubkey on error

Thanks oss-fuzz

https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=22297


  Commit: e759b17b66bcc8d116a8fbdcde66434c575bf4fb
      https://github.com/OpenSC/OpenSC/commit/e759b17b66bcc8d116a8fbdcde66434c575bf4fb
  Author: Jakub Jelen <jj...@re...>
  Date:   2020-07-07 (Tue, 07 Jul 2020)

  Changed paths:
    M src/libopensc/pkcs15-pubkey.c

  Log Message:
  -----------
  pkcs15-pubkey: Avoid memory leaks when spki parsing fails

Thanks oss-fuzz

https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=22189


  Commit: 0cda376dba46b6719d82174255360a2ac2475092
      https://github.com/OpenSC/OpenSC/commit/0cda376dba46b6719d82174255360a2ac2475092
  Author: Jakub Jelen <jj...@re...>
  Date:   2020-07-07 (Tue, 07 Jul 2020)

  Changed paths:
    M src/libopensc/pkcs15-pubkey.c

  Log Message:
  -----------
  pkcs15-pubkey: Make sc_pkcs15_pubkey_from_spki_fields more robust against errors

Original patch from Douglas E Engert <dee...@gm...>


  Commit: 43379b3b22f65f97a83de422f6a3b37fdfb2b138
      https://github.com/OpenSC/OpenSC/commit/43379b3b22f65f97a83de422f6a3b37fdfb2b138
  Author: Jakub Jelen <jj...@re...>
  Date:   2020-07-07 (Tue, 07 Jul 2020)

  Changed paths:
    M src/libopensc/card-coolkey.c

  Log Message:
  -----------
  coolkey: Rewrite coolkey_rsa_op() for better readability


  Commit: c4d7bb1a7ba80d155021f7a311b7fa6b1ce54e15
      https://github.com/OpenSC/OpenSC/commit/c4d7bb1a7ba80d155021f7a311b7fa6b1ce54e15
  Author: Jakub Jelen <jj...@re...>
  Date:   2020-07-07 (Tue, 07 Jul 2020)

  Changed paths:
    M src/libopensc/pkcs15-sc-hsm.c

  Log Message:
  -----------
  Do not crash on if private certificate is ignored (#2057)


  Commit: 7cf8087351c821aa1e617282db93ecb33d53d918
      https://github.com/OpenSC/OpenSC/commit/7cf8087351c821aa1e617282db93ecb33d53d918
  Author: Jakub Jelen <jj...@re...>
  Date:   2020-07-07 (Tue, 07 Jul 2020)

  Changed paths:
    M src/libopensc/card-asepcos.c

  Log Message:
  -----------
  asepcos: Avoid heap-buffer-overflow

Thanks oss-fuzz

https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=23529


  Commit: 5098cfdb4034eb2b901edb0373fb8ecf866a42cd
      https://github.com/OpenSC/OpenSC/commit/5098cfdb4034eb2b901edb0373fb8ecf866a42cd
  Author: Jakub Jelen <jj...@re...>
  Date:   2020-07-07 (Tue, 07 Jul 2020)

  Changed paths:
    M src/libopensc/card-authentic.c

  Log Message:
  -----------
  authentic: Do not leak memory on fail path

Thanks oss-fuzz

https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=23788


  Commit: 05dcde508b8f5884242c6832cc2a4521fedd626f
      https://github.com/OpenSC/OpenSC/commit/05dcde508b8f5884242c6832cc2a4521fedd626f
  Author: Jakub Jelen <jj...@re...>
  Date:   2020-07-07 (Tue, 07 Jul 2020)

  Changed paths:
    M src/libopensc/card-authentic.c

  Log Message:
  -----------
  authentic: Use memmove as the memory can overlap (if path is > 2B)

Thanks oss-fuzz

https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=23787


  Commit: 4c473fba29d0c7c674fc06c92b0076d0642f10ed
      https://github.com/OpenSC/OpenSC/commit/4c473fba29d0c7c674fc06c92b0076d0642f10ed
  Author: Jakub Jelen <jj...@re...>
  Date:   2020-07-07 (Tue, 07 Jul 2020)

  Changed paths:
    M src/libopensc/card-authentic.c

  Log Message:
  -----------
  authentic: Clean private data on error

Thanks oss-fuzz

https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=23786


  Commit: 2d6de2510c2d8427a6e7f63593fe05285b6ab068
      https://github.com/OpenSC/OpenSC/commit/2d6de2510c2d8427a6e7f63593fe05285b6ab068
  Author: Jakub Jelen <jj...@re...>
  Date:   2020-07-07 (Tue, 07 Jul 2020)

  Changed paths:
    M src/libopensc/pkcs15.c

  Log Message:
  -----------
  pkcs15: Drop bogus checks


  Commit: c82aa926879842fa5725ff8956f41dd1420f8fa1
      https://github.com/OpenSC/OpenSC/commit/c82aa926879842fa5725ff8956f41dd1420f8fa1
  Author: Jakub Jelen <jj...@re...>
  Date:   2020-07-07 (Tue, 07 Jul 2020)

  Changed paths:
    M src/libopensc/pkcs15.c

  Log Message:
  -----------
  pkcs15: Clean memory on alocation failure


  Commit: b16a5cbee03202aa122a7ae840335450eeee5a9a
      https://github.com/OpenSC/OpenSC/commit/b16a5cbee03202aa122a7ae840335450eeee5a9a
  Author: Jakub Jelen <jj...@re...>
  Date:   2020-07-07 (Tue, 07 Jul 2020)

  Changed paths:
    M src/libopensc/pkcs15.c

  Log Message:
  -----------
  pkcs15: Free app info when allocating new and in cleanup

Thanks oss-fuzz

https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=23746


Compare: https://github.com/OpenSC/OpenSC/compare/054cb08c90c9...b16a5cbee032