Menu
▾
▴
[Opensc-commits] [OpenSC/OpenSC] 78c79c: opensc-explorer: refactor arg_to_path()
|
From: Peter M. <no...@gi...> - 2020-03-04 20:59:49
|
Branch: refs/heads/master Home: https://github.com/OpenSC/OpenSC Commit: 78c79c0efbffe98716130a12c5b29bb091d53bfe https://github.com/OpenSC/OpenSC/commit/78c79c0efbffe98716130a12c5b29bb091d53bfe Author: Peter Marschall <pe...@ad...> Date: 2020-03-04 (Wed, 04 Mar 2020) Changed paths: M src/tools/opensc-explorer.c Log Message: ----------- opensc-explorer: refactor arg_to_path() * fix indentation * fix spaces before opening curly braces Commit: f20b646a97f1f791b73c7a23f5e6a68be44d0605 https://github.com/OpenSC/OpenSC/commit/f20b646a97f1f791b73c7a23f5e6a68be44d0605 Author: Peter Marschall <pe...@ad...> Date: 2020-03-04 (Wed, 04 Mar 2020) Changed paths: M src/tools/opensc-explorer.c Log Message: ----------- opensc-explorer: re-factor do_cd() * do not fail on SC_FILE_TYPE_UNKNOWN: be more flexible w.r.t accepting unknown file types when the preceding card operations succeeded * fix spaces before opening curly braces Commit: 4abacbf5c1648aa69296679042fa7a1b057a910c https://github.com/OpenSC/OpenSC/commit/4abacbf5c1648aa69296679042fa7a1b057a910c Author: Peter Marschall <pe...@ad...> Date: 2020-03-04 (Wed, 04 Mar 2020) Changed paths: M src/tools/opensc-explorer.c Log Message: ----------- opensc-explorer: re-factor read_and_print_binary_file() * rename from read_and_util_print_binary_file(); adapt callers * use large enough buffer size SC_MAX_EXT_APDU_RESP_SIZE instead of potentially too small magic number * fix spaces before opening curly braces * avoid special casing SC_CARD_TYPE_BELPIC_EID: a successful read of an empty file is still a success, even if nothing can get printed Commit: b6febc0c7a84e23dcc5c26dea20846446a5e4249 https://github.com/OpenSC/OpenSC/commit/b6febc0c7a84e23dcc5c26dea20846446a5e4249 Author: Peter Marschall <pe...@ad...> Date: 2020-03-04 (Wed, 04 Mar 2020) Changed paths: M src/tools/opensc-explorer.c Log Message: ----------- opensc-explorer: re-factor do_find() * set default values for variables at declaration time * use sizeof(fid) instead of magic number * use braces after sizeof, i.e. sizeof(X) instead of sizeof X * start error message with upper-case letter Commit: f556c275f7fb5ab44a95f46f1909dfa5244925ab https://github.com/OpenSC/OpenSC/commit/f556c275f7fb5ab44a95f46f1909dfa5244925ab Author: Peter Marschall <pe...@ad...> Date: 2020-03-04 (Wed, 04 Mar 2020) Changed paths: M src/tools/opensc-explorer.c Log Message: ----------- opensc-explorer: re-factor do_find_tags() * set default values for variables at declaration time * replace magic number used as potentially too small buffer size by SC_MAX_EXT_APDU_RESP_SIZE * use braces after sizeof, i.e. sizeof(X) instead of sizeof X Commit: 968815e6ef91ba3ed4175eee6ea8adb6cebcedb4 https://github.com/OpenSC/OpenSC/commit/968815e6ef91ba3ed4175eee6ea8adb6cebcedb4 Author: Peter Marschall <pe...@ad...> Date: 2020-03-04 (Wed, 04 Mar 2020) Changed paths: M src/tools/opensc-explorer.c Log Message: ----------- opensc-explorer: re-factor do_get_data() * determine DO ID/tag the same way as do_find_tags() * replace magic magic number used as potentially too small buffer size by SC_MAX_EXT_APDU_RESP_SIZE * change buffer type from unsigned char to u8 for consistency with do_put_data() & do_find_tags() * give ID/tag of DO in error message * open target file in binary mode Commit: f1d46401cb93ab7c3581218b327af55ea87e2e2d https://github.com/OpenSC/OpenSC/commit/f1d46401cb93ab7c3581218b327af55ea87e2e2d Author: Peter Marschall <pe...@ad...> Date: 2020-03-04 (Wed, 04 Mar 2020) Changed paths: M src/tools/opensc-explorer.c Log Message: ----------- opensc-explorer: re-factor do_put_data() * determine DO ID/tag the same way as do_find_tags() * start error message with upper-case letter * use sc_strerror(r) instead of plain numeric r in error message * adapt size of buffer to SC_MAX_EXT_APDU_DATA_SIZE Commit: b77e0faadb5f6edb8272d2856f5fff49884664fa https://github.com/OpenSC/OpenSC/commit/b77e0faadb5f6edb8272d2856f5fff49884664fa Author: Peter Marschall <pe...@ad...> Date: 2020-03-04 (Wed, 04 Mar 2020) Changed paths: M src/tools/opensc-explorer.c Log Message: ----------- opensc-explorer: re-factor do_ls() * replace magic magic number used as potentially too small buffer size by SC_MAX_EXT_APDU_RESP_SIZE * replace magic number for filename by SC_MAX_PATH_STRING_SIZE * start error messages with upper-case letters * use braces after sizeof, i.e. sizeof(X) instead of sizeof X * fix indentation Commit: c2a8102615c9bfc7dd004df61e4d6a46ad6e5586 https://github.com/OpenSC/OpenSC/commit/c2a8102615c9bfc7dd004df61e4d6a46ad6e5586 Author: Peter Marschall <pe...@ad...> Date: 2020-03-04 (Wed, 04 Mar 2020) Changed paths: M src/tools/opensc-explorer.c Log Message: ----------- opensc-explorer: re-factor do_get() * replace magic number used as potentially too small buffer size by SC_MAX_EXT_APDU_RESP_SIZE * start error messages with upper-case letters Commit: be152f78b41cf3c5bcc66aa2b96136284c984064 https://github.com/OpenSC/OpenSC/commit/be152f78b41cf3c5bcc66aa2b96136284c984064 Author: Peter Marschall <pe...@ad...> Date: 2020-03-04 (Wed, 04 Mar 2020) Changed paths: M src/tools/opensc-explorer.c Log Message: ----------- opensc-explorer: re-factor do_update_binary() * replace magic magic number used as potentially too small buffer size by SC_MAX_EXT_APDU_DATA_SIZE * remove print() statement that looks suspiciously like a leftover from debugging * start error messages with upper-case letters * use sc_strerror(r) instead of plain numeric r in error message * fix spaces before opening curly braces Commit: b9d4f0c7d8bf2320b73b44bb55c28b23010a3e1c https://github.com/OpenSC/OpenSC/commit/b9d4f0c7d8bf2320b73b44bb55c28b23010a3e1c Author: Peter Marschall <pe...@ad...> Date: 2020-03-04 (Wed, 04 Mar 2020) Changed paths: M src/tools/opensc-explorer.c Log Message: ----------- opensc-explorer: re-factor & fix do_update_record() * bug fix: pass correct buffer length to sc_update_record() * bug fix: report correct number of bytes written * bug fix: check for offs to be small enough * replace magic magic number used as potentially too small buffer size by SC_MAX_EXT_APDU_DATA_SIZE * remove print() statement that looks suspiciously like a leftover from debugging * start error messages with upper-case letters * use sc_strerror(r) instead of plain numeric r in error messages * fix spaces before opening curly braces Commit: 9b0983e96d9a5b53117257437e972cbcb49bb4a5 https://github.com/OpenSC/OpenSC/commit/9b0983e96d9a5b53117257437e972cbcb49bb4a5 Author: Peter Marschall <pe...@ad...> Date: 2020-03-04 (Wed, 04 Mar 2020) Changed paths: M src/tools/opensc-explorer.c Log Message: ----------- opensc-explorer: re-factor do_random() * use braces after sizeof, i.e. sizeof(X) instead of sizeof X Commit: b2f86b3997f2da5fa9f172270a7bfa7f4bdf988f https://github.com/OpenSC/OpenSC/commit/b2f86b3997f2da5fa9f172270a7bfa7f4bdf988f Author: Peter Marschall <pe...@ad...> Date: 2020-03-04 (Wed, 04 Mar 2020) Changed paths: M src/tools/opensc-explorer.c Log Message: ----------- opensc-explorer: re-factor read_and_print_record_file() * replace magic magic number used as potentially too small buffer size by SC_MAX_EXT_APDU_RESP_SIZE * start error message with upper-case letter * return 0 on success Commit: 44c22b7820b34cb6c4ef56024ee9d04f693e03e1 https://github.com/OpenSC/OpenSC/commit/44c22b7820b34cb6c4ef56024ee9d04f693e03e1 Author: Peter Marschall <pe...@ad...> Date: 2020-03-04 (Wed, 04 Mar 2020) Changed paths: M src/tools/opensc-explorer.c Log Message: ----------- opensc-explorer: re-factor do_put() * replace magic magic number used as potentially too small buffer size by SC_MAX_EXT_APDU_DATA_SIZE * start error message with upper-case letter Compare: https://github.com/OpenSC/OpenSC/compare/88dce1218176...44c22b7820b3 |
