[Opensc-commits] [OpenSC/OpenSC] a40cde: util: refactor listing card drivers

[Frank M. <no...@gi...>]

  Branch: refs/heads/master
  Home:   https://github.com/OpenSC/OpenSC
  Commit: a40cde2d049a89e77f7e756d1d7e9594cd70e1d1
      https://github.com/OpenSC/OpenSC/commit/a40cde2d049a89e77f7e756d1d7e9594cd70e1d1
  Author: Peter Marschall <pe...@ad...>
  Date:   2020-01-12 (Sun, 12 Jan 2020)

  Changed paths:
    M src/tools/util.c
    M src/tools/util.h

  Log Message:
  -----------
  util: refactor listing card drivers

Make util_list_card_drivers() a function in util.c to allow
consistent listing of available card drivers from tools.


  Commit: 5da40bf027b2e91063bd012580bde7dd5e375ddd
      https://github.com/OpenSC/OpenSC/commit/5da40bf027b2e91063bd012580bde7dd5e375ddd
  Author: Peter Marschall <pe...@ad...>
  Date:   2020-01-12 (Sun, 12 Jan 2020)

  Changed paths:
    M doc/tools/opensc-explorer.1.xml
    M src/tools/opensc-explorer.c

  Log Message:
  -----------
  opensc-explorer: make '--card-driver ?' list all available drivers

Make opensc-explorer a bit more user friendly by treating the question mark
given as argument to option '--card-driver' special: list all available
drivers instead of stupidly bailing out.


  Commit: 94288b438e8b741aa944290774a32468f361a27a
      https://github.com/OpenSC/OpenSC/commit/94288b438e8b741aa944290774a32468f361a27a
  Author: Peter Marschall <pe...@ad...>
  Date:   2020-01-12 (Sun, 12 Jan 2020)

  Changed paths:
    M doc/tools/opensc-tool.1.xml
    M src/tools/opensc-tool.c

  Log Message:
  -----------
  opensc-tool: make '--card-driver ?' list all available drivers

Extend opensc-tool the same way opensc-explorer was extended. I.e.
treat the question mark given as argument to option '--card-driver'
special: list all available drivers instead of stupidly bailing out.


  Commit: 30fdc7de4ac2778dfe75fa05a3b6649961411d69
      https://github.com/OpenSC/OpenSC/commit/30fdc7de4ac2778dfe75fa05a3b6649961411d69
  Author: Peter Marschall <pe...@ad...>
  Date:   2020-01-12 (Sun, 12 Jan 2020)

  Changed paths:
    M doc/tools/piv-tool.1.xml
    M src/tools/piv-tool.c

  Log Message:
  -----------
  piv-tool: make '--card-driver ?' list all available drivers

Extend piv-tool the same way opensc-explorer was extended. I.e.
treat the question mark given as argument to option '--card-driver'
special: list all available drivers instead of stupidly bailing out.

In contrast to opensc-tool and opensc-explorer, which are card-agnostic,
I am not sure whether the option '--card-driver' makes sense on this
card-specific tool.


  Commit: a10368769c6457702e8e713c8da9d08d149c3936
      https://github.com/OpenSC/OpenSC/commit/a10368769c6457702e8e713c8da9d08d149c3936
  Author: Peter Marschall <pe...@ad...>
  Date:   2020-01-12 (Sun, 12 Jan 2020)

  Changed paths:
    M doc/tools/cardos-tool.1.xml
    M src/tools/cardos-tool.c

  Log Message:
  -----------
  cardos-tool: make '--card-driver ?' list all available drivers

Extend cardos-tool the same way opensc-explorer was extended. I.e.
treat the question mark given as argument to option '--card-driver'
special: list all available drivers instead of stupidly bailing out.

In contrast to opensc-tool and opensc-explorer, which are card-agnostic,
I am not sure whether the option '--card-driver' makes sense on this
card-specific tool.


  Commit: 5514a0529f21a2fcd21f24ee9bd51ac7936789de
      https://github.com/OpenSC/OpenSC/commit/5514a0529f21a2fcd21f24ee9bd51ac7936789de
  Author: Peter Marschall <pe...@ad...>
  Date:   2020-01-12 (Sun, 12 Jan 2020)

  Changed paths:
    M doc/tools/dnie-tool.1.xml
    M src/tools/dnie-tool.c

  Log Message:
  -----------
  dnie-tool: rename option '--driver' to '--card-driver'

Rename option '--driver' to '--card-driver' for increased consistency.

In addition, extend it the same way opensc-explorer was extended. I.e.
treat the question mark given as argument to option '--card-driver'
special: list all available drivers instead of stupidly bailing out.

In contrast to opensc-tool and opensc-explorer, which are card-agnostic,
I am not sure whether the option '--card-driver' makes sense on this
card-specific tool.


  Commit: 04f4f589a18c12ef775d10e3e1da758d17058f8d
      https://github.com/OpenSC/OpenSC/commit/04f4f589a18c12ef775d10e3e1da758d17058f8d
  Author: Peter Marschall <pe...@ad...>
  Date:   2020-01-12 (Sun, 12 Jan 2020)

  Changed paths:
    M doc/tools/piv-tool.1.xml
    M src/tools/piv-tool.c

  Log Message:
  -----------
  piv-tool: cleanup

- remove command line option '--card-driver';
- instead force driver 'PIV-II' and fail if card is not a PIV card
- overhaul option parsing
  - remove unused variable 'long_optind'
  - make work option '--reader' ( "r:" was missing in the optstring!!!)
  - bail out with usage message on all unknown/unhandled args
  - correctly terminate option parsing (no infinite loop)


  Commit: 58ecb4aba2206b904ebb079b7d8c3ef5a424e49b
      https://github.com/OpenSC/OpenSC/commit/58ecb4aba2206b904ebb079b7d8c3ef5a424e49b
  Author: Peter Marschall <pe...@ad...>
  Date:   2020-01-12 (Sun, 12 Jan 2020)

  Changed paths:
    M doc/tools/cardos-tool.1.xml
    M src/tools/cardos-tool.c

  Log Message:
  -----------
  cardos-tool: cleanup

- remove command line option '--card-driver';
- instead force driver 'cardos' and fail if card is not a CardOS card
- overhaul option parsing
      - remove unused variable 'long_optind'
      - bail out with usage message on all unknown/unhandled args
      - correctly terminate option parsing (no infinite loop)


  Commit: a0adbc9ef2ab006365f4a746929ff001b767da6f
      https://github.com/OpenSC/OpenSC/commit/a0adbc9ef2ab006365f4a746929ff001b767da6f
  Author: Peter Marschall <pe...@ad...>
  Date:   2020-01-12 (Sun, 12 Jan 2020)

  Changed paths:
    M doc/tools/dnie-tool.1.xml
    M src/tools/dnie-tool.c

  Log Message:
  -----------
  dnie-tool: cleanup

- remove command line option '--card-driver';
- instead force driver 'dnie' and fail if card is not a DNIe card
- overhaul option parsing
  - remove unused variable 'long_optind'
  - bail out with usage message on all unknown/unhandled args
  - correctly terminate option parsing (no infinite loop)
- slight refactoring
  - avoid magic constant '0x0f'
  - make variable 'tries_left' more local
  - move dependent code into if block


  Commit: 6b295e4207d9cb7972202d33e00da35e0bd7c685
      https://github.com/OpenSC/OpenSC/commit/6b295e4207d9cb7972202d33e00da35e0bd7c685
  Author: Peter Marschall <pe...@ad...>
  Date:   2020-01-12 (Sun, 12 Jan 2020)

  Changed paths:
    M src/tools/eidenv.c
    M src/tools/netkey-tool.c
    M src/tools/openpgp-tool.c

  Log Message:
  -----------
  tools: correctly check return value of getopt_long()

According to the specs, getopt_long() returns -1, which is often,
but not necessarily the value of EOF.


  Commit: 61c20cf83dfce5a7e2f0d5ec78dc976de74855f1
      https://github.com/OpenSC/OpenSC/commit/61c20cf83dfce5a7e2f0d5ec78dc976de74855f1
  Author: Frank Morgner <fra...@gm...>
  Date:   2020-01-22 (Wed, 22 Jan 2020)

  Changed paths:
    M doc/tools/cardos-tool.1.xml
    M doc/tools/dnie-tool.1.xml
    M doc/tools/opensc-explorer.1.xml
    M doc/tools/opensc-tool.1.xml
    M doc/tools/piv-tool.1.xml
    M src/tools/cardos-tool.c
    M src/tools/dnie-tool.c
    M src/tools/eidenv.c
    M src/tools/netkey-tool.c
    M src/tools/openpgp-tool.c
    M src/tools/opensc-explorer.c
    M src/tools/opensc-tool.c
    M src/tools/piv-tool.c
    M src/tools/util.c
    M src/tools/util.h

  Log Message:
  -----------
  Merge pull request #1896 from marschap/explorer-card-drivers

opensc-explorer: make '--card-driver ?' list all available drivers


Compare: https://github.com/OpenSC/OpenSC/compare/4ef7ed9ffd2a...61c20cf83dfc