Menu
▾
▴
[Opensc-commits] [OpenSC/OpenSC] 8e6d2e: unittests: Reproducer for undefined shift in ASN1 ...
|
From: Frank M. <no...@gi...> - 2020-01-17 14:15:33
|
Branch: refs/heads/master Home: https://github.com/OpenSC/OpenSC Commit: 8e6d2e251d803fd191b4b4f30c26a867361d8d81 https://github.com/OpenSC/OpenSC/commit/8e6d2e251d803fd191b4b4f30c26a867361d8d81 Author: Jakub Jelen <jj...@re...> Date: 2020-01-07 (Tue, 07 Jan 2020) Changed paths: M .gitignore M configure.ac M src/tests/Makefile.am A src/tests/unittests/Makefile.am A src/tests/unittests/Makefile.mak A src/tests/unittests/asn1.c A src/tests/unittests/torture.h Log Message: ----------- unittests: Reproducer for undefined shift in ASN1 parser Commit: b6b9a886f9785d11c50f7eec3f46633b181f87b8 https://github.com/OpenSC/OpenSC/commit/b6b9a886f9785d11c50f7eec3f46633b181f87b8 Author: Jakub Jelen <jj...@re...> Date: 2020-01-07 (Tue, 07 Jan 2020) Changed paths: M src/tests/unittests/asn1.c Log Message: ----------- unittests: Verify negative ASN1 integeres parsing Commit: 19501715d7552585ceac8420fe88956967610576 https://github.com/OpenSC/OpenSC/commit/19501715d7552585ceac8420fe88956967610576 Author: Jakub Jelen <jj...@re...> Date: 2020-01-07 (Tue, 07 Jan 2020) Changed paths: M src/libopensc/asn1.c Log Message: ----------- asn1: Correctly handle OIDs with second octet > 39 Commit: 7971bfded33794d35fe253b3f35ac5ad2af272bb https://github.com/OpenSC/OpenSC/commit/7971bfded33794d35fe253b3f35ac5ad2af272bb Author: Jakub Jelen <jj...@re...> Date: 2020-01-07 (Tue, 07 Jan 2020) Changed paths: M src/tests/unittests/asn1.c Log Message: ----------- unittests: Verify parsing of more OIDs Commit: 61af2c1d0ac1b0e78056bedf4b98ff9da7b35eb4 https://github.com/OpenSC/OpenSC/commit/61af2c1d0ac1b0e78056bedf4b98ff9da7b35eb4 Author: Jakub Jelen <jj...@re...> Date: 2020-01-07 (Tue, 07 Jan 2020) Changed paths: M src/libopensc/asn1.c Log Message: ----------- asn1: Add support for encoding large values in OIDs Commit: 8d49e4a3054c6c43c2cdc3595a53a74daa1fc464 https://github.com/OpenSC/OpenSC/commit/8d49e4a3054c6c43c2cdc3595a53a74daa1fc464 Author: Jakub Jelen <jj...@re...> Date: 2020-01-07 (Tue, 07 Jan 2020) Changed paths: M src/tests/unittests/asn1.c Log Message: ----------- unittests: Test encoding of OIDs and integers Commit: c1814571bd09440e09b7c32285367d580d65650a https://github.com/OpenSC/OpenSC/commit/c1814571bd09440e09b7c32285367d580d65650a Author: Jakub Jelen <jj...@re...> Date: 2020-01-07 (Tue, 07 Jan 2020) Changed paths: M src/libopensc/asn1.c Log Message: ----------- asn1: Avoid invalid unused bits values Commit: 611d1cea4c139c8f14088d3ac092c7d3ac648bca https://github.com/OpenSC/OpenSC/commit/611d1cea4c139c8f14088d3ac092c7d3ac648bca Author: Jakub Jelen <jj...@re...> Date: 2020-01-07 (Tue, 07 Jan 2020) Changed paths: M src/tests/unittests/asn1.c Log Message: ----------- unittests: Verify BIT STRING parsing as integers Commit: 127129995524728d49051c0f04161ede740adfe4 https://github.com/OpenSC/OpenSC/commit/127129995524728d49051c0f04161ede740adfe4 Author: Jakub Jelen <jj...@re...> Date: 2020-01-07 (Tue, 07 Jan 2020) Changed paths: M src/libopensc/asn1.c Log Message: ----------- ans1: Verify the padding in BIT STRING contains only zero bits Commit: d3e9b55223fc310b8c7c9b081618440582ea833e https://github.com/OpenSC/OpenSC/commit/d3e9b55223fc310b8c7c9b081618440582ea833e Author: Jakub Jelen <jj...@re...> Date: 2020-01-07 (Tue, 07 Jan 2020) Changed paths: M src/libopensc/asn1.c Log Message: ----------- asn1: Distinguish error codes for invalid objects from implementation limitation (integer size) Commit: c449aa4430dd09cd993f9ecaa60720e0d7e64805 https://github.com/OpenSC/OpenSC/commit/c449aa4430dd09cd993f9ecaa60720e0d7e64805 Author: Jakub Jelen <jj...@re...> Date: 2020-01-07 (Tue, 07 Jan 2020) Changed paths: M src/libopensc/asn1.c Log Message: ----------- asn1: Reject integers with bogus zero/non-zero bytes on left Commit: 4faf517af41c7f75a4c5ed3ec6e05f0c8ade1152 https://github.com/OpenSC/OpenSC/commit/4faf517af41c7f75a4c5ed3ec6e05f0c8ade1152 Author: Jakub Jelen <jj...@re...> Date: 2020-01-07 (Tue, 07 Jan 2020) Changed paths: M src/libopensc/asn1.c Log Message: ----------- asn1: Handle more corner cases of OBJECT ID parsing Commit: 89ed273e8136b5254ee2df8771c4cbdc3ca1599e https://github.com/OpenSC/OpenSC/commit/89ed273e8136b5254ee2df8771c4cbdc3ca1599e Author: Jakub Jelen <jj...@re...> Date: 2020-01-07 (Tue, 07 Jan 2020) Changed paths: M src/libopensc/card-cac1.c Log Message: ----------- cac1: Simplify the cycle definintion Commit: 456900941892a3ff76cb68f4bf8fa01da39685fd https://github.com/OpenSC/OpenSC/commit/456900941892a3ff76cb68f4bf8fa01da39685fd Author: Jakub Jelen <jj...@re...> Date: 2020-01-07 (Tue, 07 Jan 2020) Changed paths: M src/tests/unittests/asn1.c Log Message: ----------- unittests: Improve test coverage mostly with negative test cases Thanks @hkario for review Commit: fefff2e46209079af26d9c34090f18217b8dcf51 https://github.com/OpenSC/OpenSC/commit/fefff2e46209079af26d9c34090f18217b8dcf51 Author: Jakub Jelen <jj...@re...> Date: 2020-01-07 (Tue, 07 Jan 2020) Changed paths: M src/libopensc/asn1.c Log Message: ----------- asn1: Simplify the OID decoding Commit: aaa302ca3576607c7bf3b80730113b588da60d8d https://github.com/OpenSC/OpenSC/commit/aaa302ca3576607c7bf3b80730113b588da60d8d Author: Jakub Jelen <jj...@re...> Date: 2020-01-07 (Tue, 07 Jan 2020) Changed paths: M src/libopensc/asn1.c M src/libopensc/asn1.h M src/libopensc/iso7816.c M src/tests/unittests/asn1.c M src/tools/goid-tool.c Log Message: ----------- asn1: Allow non-strict INTEGER parsing for other code paths (FCI parsing) Commit: 71e45bb5a708262ed814d9e911ab831d6daf9643 https://github.com/OpenSC/OpenSC/commit/71e45bb5a708262ed814d9e911ab831d6daf9643 Author: Jakub Jelen <jj...@re...> Date: 2020-01-07 (Tue, 07 Jan 2020) Changed paths: M src/tests/unittests/asn1.c Log Message: ----------- unittest: Rewrite the INTEGER unittests to use macros and avoid code duplication Commit: 1e2b0fe45f6ea1e90e18747d275a9e241e04d3f5 https://github.com/OpenSC/OpenSC/commit/1e2b0fe45f6ea1e90e18747d275a9e241e04d3f5 Author: Jakub Jelen <jj...@re...> Date: 2020-01-07 (Tue, 07 Jan 2020) Changed paths: M src/tests/unittests/asn1.c Log Message: ----------- unittests: Restructure the BIT STRING tests Commit: 37c8c46623a3fb6a58e5cadb5f673252a69246d4 https://github.com/OpenSC/OpenSC/commit/37c8c46623a3fb6a58e5cadb5f673252a69246d4 Author: Jakub Jelen <jj...@re...> Date: 2020-01-07 (Tue, 07 Jan 2020) Changed paths: M src/tests/unittests/asn1.c Log Message: ----------- unittests: Simplify the OBJECT ID tests Commit: 2c913155a25171af571c0c3ee4b0cc2430bab667 https://github.com/OpenSC/OpenSC/commit/2c913155a25171af571c0c3ee4b0cc2430bab667 Author: Jakub Jelen <jj...@re...> Date: 2020-01-07 (Tue, 07 Jan 2020) Changed paths: M src/libopensc/asn1.c Log Message: ----------- asn1: Do not accept non-minimal encoding of OBJECT IDs Commit: 3af6d7999e387b8074a209aa9d44a0f29359c573 https://github.com/OpenSC/OpenSC/commit/3af6d7999e387b8074a209aa9d44a0f29359c573 Author: Jakub Jelen <jj...@re...> Date: 2020-01-07 (Tue, 07 Jan 2020) Changed paths: M src/tests/unittests/asn1.c Log Message: ----------- unittests: Add tests for non-minimal OBJECT ID encoding Thanks @hkario for suggestions Commit: 8ddfafe057fa4960fed5c427bea2c48d68e67655 https://github.com/OpenSC/OpenSC/commit/8ddfafe057fa4960fed5c427bea2c48d68e67655 Author: Jakub Jelen <jj...@re...> Date: 2020-01-07 (Tue, 07 Jan 2020) Changed paths: M src/libopensc/asn1.c Log Message: ----------- asn1: Empty bit string requires empty zero-bits indicator Commit: e8af4fc1674cee7e3b7bfeee5a68644fd856cea5 https://github.com/OpenSC/OpenSC/commit/e8af4fc1674cee7e3b7bfeee5a68644fd856cea5 Author: Jakub Jelen <jj...@re...> Date: 2020-01-07 (Tue, 07 Jan 2020) Changed paths: M src/tests/unittests/asn1.c Log Message: ----------- unittests: Add more coverage corner cases for BIT STRINGs Commit: 9a6cf6af3eda2915d991dcacfc6e983cce014303 https://github.com/OpenSC/OpenSC/commit/9a6cf6af3eda2915d991dcacfc6e983cce014303 Author: Jakub Jelen <jj...@re...> Date: 2020-01-07 (Tue, 07 Jan 2020) Changed paths: M Makefile.am M configure.ac A m4/ax_ac_append_to_file.m4 A m4/ax_ac_print_to_file.m4 A m4/ax_add_am_macro_static.m4 A m4/ax_am_macros_static.m4 A m4/ax_check_gnu_make.m4 A m4/ax_code_coverage.m4 A m4/ax_file_escapes.m4 M src/tests/unittests/Makefile.am Log Message: ----------- configure: Add option to generate code coverage (for unit tests) ./configure --enable-code-coverage --disable-optimization make check make code-coverage-capture lcov --summary OpenSC-*-coverage.info This does not work well with Windows so on windows it should be disabled (WIP) Commit: 586f0a3e42084d3b7c94cea00aeff52babbc4da1 https://github.com/OpenSC/OpenSC/commit/586f0a3e42084d3b7c94cea00aeff52babbc4da1 Author: Jakub Jelen <jj...@re...> Date: 2020-01-07 (Tue, 07 Jan 2020) Changed paths: M src/tests/unittests/asn1.c Log Message: ----------- unittests: Reproducer for empty OCTET STRINGs calling malloc(0) Commit: 90aaa9e08382801bf6a95e4683877247a3bfefb7 https://github.com/OpenSC/OpenSC/commit/90aaa9e08382801bf6a95e4683877247a3bfefb7 Author: Jakub Jelen <jj...@re...> Date: 2020-01-07 (Tue, 07 Jan 2020) Changed paths: M src/tests/unittests/asn1.c Log Message: ----------- unittests: Increase coverage of decode_entry() Commit: a4cd265e7c4704a1522b00c57e3e894afa4d55d4 https://github.com/OpenSC/OpenSC/commit/a4cd265e7c4704a1522b00c57e3e894afa4d55d4 Author: Jakub Jelen <jj...@re...> Date: 2020-01-07 (Tue, 07 Jan 2020) Changed paths: M src/tests/unittests/Makefile.am M src/tests/unittests/Makefile.mak A src/tests/unittests/compression.c Log Message: ----------- unittests: Cover the decompression API with tests Commit: b0d3a70b919ad4398a4b66415331027fb5fa19df https://github.com/OpenSC/OpenSC/commit/b0d3a70b919ad4398a4b66415331027fb5fa19df Author: Jakub Jelen <jj...@re...> Date: 2020-01-07 (Tue, 07 Jan 2020) Changed paths: M src/libopensc/card-coolkey.c Log Message: ----------- coolkey: Improve logging of return codes Commit: 8fd5ffd54ed0211f97000eca023d8a8824b1e168 https://github.com/OpenSC/OpenSC/commit/8fd5ffd54ed0211f97000eca023d8a8824b1e168 Author: Jakub Jelen <jj...@re...> Date: 2020-01-07 (Tue, 07 Jan 2020) Changed paths: M src/libopensc/simpletlv.c Log Message: ----------- simpletlv: Avoid writing before all sanity checks in sc_simpletlv_put_tag() Commit: 4fd34e28eaf13b0cd6d6dcbcb105be14bccb12e7 https://github.com/OpenSC/OpenSC/commit/4fd34e28eaf13b0cd6d6dcbcb105be14bccb12e7 Author: Jakub Jelen <jj...@re...> Date: 2020-01-07 (Tue, 07 Jan 2020) Changed paths: M src/tests/unittests/Makefile.am A src/tests/unittests/simpletlv.c Log Message: ----------- unittests: Add coverage for simpletlv parsers Commit: cae3b71d7567aef2eb61607cddab2902c2757473 https://github.com/OpenSC/OpenSC/commit/cae3b71d7567aef2eb61607cddab2902c2757473 Author: Jakub Jelen <jj...@re...> Date: 2020-01-07 (Tue, 07 Jan 2020) Changed paths: M src/libopensc/gp.h Log Message: ----------- gp: Define the structure packed, as it is used directly to read data inside Commit: 900cf7aca9bee7d5b37063c9f13918860ff7b8d3 https://github.com/OpenSC/OpenSC/commit/900cf7aca9bee7d5b37063c9f13918860ff7b8d3 Author: Jakub Jelen <jj...@re...> Date: 2020-01-07 (Tue, 07 Jan 2020) Changed paths: M src/libopensc/card-coolkey.c M src/libopensc/pkcs15-coolkey.c Log Message: ----------- coolkey: Improve logging Commit: 82ba7f311f3767a9ee26b1aa9430655cd05d279b https://github.com/OpenSC/OpenSC/commit/82ba7f311f3767a9ee26b1aa9430655cd05d279b Author: Jakub Jelen <jj...@re...> Date: 2020-01-07 (Tue, 07 Jan 2020) Changed paths: M src/libopensc/pkcs15-syn.c Log Message: ----------- pkcs15-syn: Improve logging Commit: a1b5feea966795a9bd2937c4ee09472ba8e3480d https://github.com/OpenSC/OpenSC/commit/a1b5feea966795a9bd2937c4ee09472ba8e3480d Author: Jakub Jelen <jj...@re...> Date: 2020-01-07 (Tue, 07 Jan 2020) Changed paths: M src/libopensc/pkcs15-coolkey.c Log Message: ----------- pkcs15-coolkey: Improve logging and formatting Commit: d1db793211623cc5602458413112129fce8379c5 https://github.com/OpenSC/OpenSC/commit/d1db793211623cc5602458413112129fce8379c5 Author: Jakub Jelen <jj...@re...> Date: 2020-01-07 (Tue, 07 Jan 2020) Changed paths: M src/tests/fuzzing/fuzz_pkcs15_reader.c Log Message: ----------- fuzz_pkcs15_reader: Record the ATR in fuzzer Commit: 1742dfc04503111047db5ab45ca440ea747eb0d7 https://github.com/OpenSC/OpenSC/commit/1742dfc04503111047db5ab45ca440ea747eb0d7 Author: Jakub Jelen <jj...@re...> Date: 2020-01-07 (Tue, 07 Jan 2020) Changed paths: A src/tests/fuzzing/corpus/fuzz_pkcs15_reader/741a0aae7b5b08c0ad2822ede5b3364302b28b31 A src/tests/fuzzing/corpus/fuzz_pkcs15_reader/7cf8e9b31dcee040ee438441aca2aecb523ed5e9 A src/tests/fuzzing/corpus/fuzz_pkcs15_reader/830e1bf4c7f0c539e9686bc1517d6f87907d4bf8 A src/tests/fuzzing/corpus/fuzz_pkcs15_reader/9ad3fc3cb11967be927bad9263d326783c450e37 A src/tests/fuzzing/corpus/fuzz_pkcs15_reader/b2b75c07a2c427c15ecd40ce47a9814279745b7d A src/tests/fuzzing/corpus/fuzz_pkcs15_reader/cb50689bf49ccb45a2af690848517305dcf1e429 A src/tests/fuzzing/corpus/fuzz_pkcs15_reader/de913ba454f894cfc38a16dd122ad673d32ac480 Log Message: ----------- fuzzing: Add corpus file from my cards The corpus is generated using a local build with #define APDU_LOG_FILE "apdulog" and by running: ./src/tools/pkcs11-tool -L --module ./src/pkcs11/.libs/opensc-pkcs11.s cb50689bf49ccb45a2af690848517305dcf1e429 -- my Yubikey 830e1bf4c7f0c539e9686bc1517d6f87907d4bf8 -- PIV Test Card 14 9ad3fc3cb11967be927bad9263d326783c450e37 -- CAC card b2b75c07a2c427c15ecd40ce47a9814279745b7d -- old CAC card 7cf8e9b31dcee040ee438441aca2aecb523ed5e9 -- CardOS 5.x 741a0aae7b5b08c0ad2822ede5b3364302b28b31 -- CAC Alt token de913ba454f894cfc38a16dd122ad673d32ac480 -- coolkey Commit: 23fcccecf40aaf98e52cdae265af250855fb1a68 https://github.com/OpenSC/OpenSC/commit/23fcccecf40aaf98e52cdae265af250855fb1a68 Author: Jakub Jelen <jj...@re...> Date: 2020-01-07 (Tue, 07 Jan 2020) Changed paths: M src/libopensc/reader-pcsc.c Log Message: ----------- reader-pcsc: Add a way to create corpus files for fuzzing Commit: 0fe341c34ee3e39fb0c8957e3ccfb9260ce268e8 https://github.com/OpenSC/OpenSC/commit/0fe341c34ee3e39fb0c8957e3ccfb9260ce268e8 Author: Jakub Jelen <jj...@re...> Date: 2020-01-07 (Tue, 07 Jan 2020) Changed paths: M tests/Makefile.am Log Message: ----------- Add missing dist file for tests Commit: b52e6db3538f8ac836649e01cd7a79e7bb221cbb https://github.com/OpenSC/OpenSC/commit/b52e6db3538f8ac836649e01cd7a79e7bb221cbb Author: Jakub Jelen <jj...@re...> Date: 2020-01-08 (Wed, 08 Jan 2020) Changed paths: M tests/Makefile.am Log Message: ----------- tests: Enable allowed_mechanisms test as the SoftHSM is already updated in Fedora 31 Commit: 60e7b4902748ba1d8e1afffaa4948e829b6c22d8 https://github.com/OpenSC/OpenSC/commit/60e7b4902748ba1d8e1afffaa4948e829b6c22d8 Author: Jakub Jelen <jj...@re...> Date: 2020-01-08 (Wed, 08 Jan 2020) Changed paths: M tests/common.sh Log Message: ----------- tests: Add path to softhsm pkcs11 module for Ubuntu Commit: 3b40018f4dab74e7d55112b258532fe9dbe027be https://github.com/OpenSC/OpenSC/commit/3b40018f4dab74e7d55112b258532fe9dbe027be Author: Jakub Jelen <jj...@re...> Date: 2020-01-08 (Wed, 08 Jan 2020) Changed paths: M tests/test-pkcs11-tool-allowed-mechanisms.sh Log Message: ----------- tests: Skip the allowed_mechanisms test on Ubuntu Commit: c8e40a19db93a55ad8f8adb2ae470c5e68cf70aa https://github.com/OpenSC/OpenSC/commit/c8e40a19db93a55ad8f8adb2ae470c5e68cf70aa Author: Jakub Jelen <jj...@re...> Date: 2020-01-08 (Wed, 08 Jan 2020) Changed paths: M .travis.yml Log Message: ----------- If make check does not pass, do not continue with other tests and dump logs Commit: 1ed9c7483d7c1fa6280961b6be0d8c910990d206 https://github.com/OpenSC/OpenSC/commit/1ed9c7483d7c1fa6280961b6be0d8c910990d206 Author: Jakub Jelen <jj...@re...> Date: 2020-01-08 (Wed, 08 Jan 2020) Changed paths: M tests/test-pkcs11-tool-sign-verify.sh M tests/test-pkcs11-tool-test.sh Log Message: ----------- tests: Skip most of the broken tests on current Ubuntu Commit: 5c555466858e407a8cc5f0da1d83407cf2f5ad00 https://github.com/OpenSC/OpenSC/commit/5c555466858e407a8cc5f0da1d83407cf2f5ad00 Author: Frank Morgner <fra...@gm...> Date: 2020-01-17 (Fri, 17 Jan 2020) Changed paths: M .gitignore M .travis.yml M Makefile.am M configure.ac A m4/ax_ac_append_to_file.m4 A m4/ax_ac_print_to_file.m4 A m4/ax_add_am_macro_static.m4 A m4/ax_am_macros_static.m4 A m4/ax_check_gnu_make.m4 A m4/ax_code_coverage.m4 A m4/ax_file_escapes.m4 M src/libopensc/asn1.c M src/libopensc/asn1.h M src/libopensc/card-cac1.c M src/libopensc/card-coolkey.c M src/libopensc/gp.h M src/libopensc/iso7816.c M src/libopensc/pkcs15-coolkey.c M src/libopensc/pkcs15-syn.c M src/libopensc/reader-pcsc.c M src/libopensc/simpletlv.c M src/tests/Makefile.am A src/tests/fuzzing/corpus/fuzz_pkcs15_reader/741a0aae7b5b08c0ad2822ede5b3364302b28b31 A src/tests/fuzzing/corpus/fuzz_pkcs15_reader/7cf8e9b31dcee040ee438441aca2aecb523ed5e9 A src/tests/fuzzing/corpus/fuzz_pkcs15_reader/830e1bf4c7f0c539e9686bc1517d6f87907d4bf8 A src/tests/fuzzing/corpus/fuzz_pkcs15_reader/9ad3fc3cb11967be927bad9263d326783c450e37 A src/tests/fuzzing/corpus/fuzz_pkcs15_reader/b2b75c07a2c427c15ecd40ce47a9814279745b7d A src/tests/fuzzing/corpus/fuzz_pkcs15_reader/cb50689bf49ccb45a2af690848517305dcf1e429 A src/tests/fuzzing/corpus/fuzz_pkcs15_reader/de913ba454f894cfc38a16dd122ad673d32ac480 M src/tests/fuzzing/fuzz_pkcs15_reader.c A src/tests/unittests/Makefile.am A src/tests/unittests/Makefile.mak A src/tests/unittests/asn1.c A src/tests/unittests/compression.c A src/tests/unittests/simpletlv.c A src/tests/unittests/torture.h M src/tools/goid-tool.c M tests/Makefile.am M tests/common.sh M tests/test-pkcs11-tool-allowed-mechanisms.sh M tests/test-pkcs11-tool-sign-verify.sh M tests/test-pkcs11-tool-test.sh Log Message: ----------- Merge pull request #1830 from Jakuje/fuzz Introduce unit tests and address more oss-fuzz issues (mostly ASN1 parser) Compare: https://github.com/OpenSC/OpenSC/compare/a46b24bacd54...5c555466858e |
