[Opensc-commits] [OpenSC/OpenSC] 2958b7: typo

[Jakub J. <no...@gi...>]

  Branch: refs/heads/master
  Home:   https://github.com/OpenSC/OpenSC
  Commit: 2958b71c9ac14325ca00df4edbe77e8a572b3f16
      https://github.com/OpenSC/OpenSC/commit/2958b71c9ac14325ca00df4edbe77e8a572b3f16
  Author: Jakub Jelen <jj...@re...>
  Date:   2019-08-20 (Tue, 20 Aug 2019)

  Changed paths:
    M src/libopensc/card-piv.c

  Log Message:
  -----------
  typo


  Commit: 818aa5b69c684e7b9254494cf9529f84cad95f75
      https://github.com/OpenSC/OpenSC/commit/818aa5b69c684e7b9254494cf9529f84cad95f75
  Author: Jakub Jelen <jj...@re...>
  Date:   2019-08-20 (Tue, 20 Aug 2019)

  Changed paths:
    M src/tests/p11test/p11test_case_common.c
    M src/tests/p11test/p11test_case_common.h
    M src/tests/p11test/p11test_case_readonly.c
    M src/tests/p11test/p11test_helpers.c

  Log Message:
  -----------
  p11test: Avoid possible issues reported by coverity

 * The fail_msg() in cmocka has a way not to fail, which confuses coverity. Adding explicit retunr/exit should address this issue
 * Reformat some code in p11test


  Commit: 1a0a8e637b8fc16f22f0a8d76210ed0105bc2916
      https://github.com/OpenSC/OpenSC/commit/1a0a8e637b8fc16f22f0a8d76210ed0105bc2916
  Author: Jakub Jelen <jj...@re...>
  Date:   2019-08-20 (Tue, 20 Aug 2019)

  Changed paths:
    M src/tests/p11test/p11test_case_common.c

  Log Message:
  -----------
  p11test: Check return values

CID undefined (#1 of 1): Unchecked return value (CHECKED_RETURN)
10. check_return: Calling RSA_set0_key without checking return value (as is done elsewhere 7 out of 8 times).


  Commit: 9b47462a51970e3ef6841a20baa7d3a5a75de441
      https://github.com/OpenSC/OpenSC/commit/9b47462a51970e3ef6841a20baa7d3a5a75de441
  Author: Jakub Jelen <jj...@re...>
  Date:   2019-08-20 (Tue, 20 Aug 2019)

  Changed paths:
    M src/tests/p11test/p11test_case_common.c

  Log Message:
  -----------
  Fix portability warning from coverity

CID 344928 (#1 of 1): Sizeof not portable (SIZEOF_MISMATCH)
suspicious_sizeof: Passing argument object_handles of type CK_OBJECT_HANDLE_PTR and argument objects_length * 8UL /* sizeof (CK_OBJECT_HANDLE_PTR) */ to function realloc is suspicious. In this case, sizeof (CK_OBJECT_HANDLE_PTR) is equal to sizeof (CK_OBJECT_HANDLE), but this is not a portable assumption.


Compare: https://github.com/OpenSC/OpenSC/compare/7d8009e429a0...9b47462a5197