Menu
▾
▴
[Opensc-commits] [OpenSC/pam_pkcs11] 62d1f5: Fix support of NSS after ECDSA addition
|
From: Ludovic R. <no...@gi...> - 2019-05-20 15:08:46
|
Branch: refs/heads/master Home: https://github.com/OpenSC/pam_pkcs11 Commit: 62d1f5ef3528c455022cb9cc411e844d5532dc9d https://github.com/OpenSC/pam_pkcs11/commit/62d1f5ef3528c455022cb9cc411e844d5532dc9d Author: Ludovic Rousseau <lud...@fr...> Date: 2019-05-20 (Mon, 20 May 2019) Changed paths: M src/common/cert_vfy.c Log Message: ----------- Fix support of NSS after ECDSA addition Fix compiler error: cert_vfy.c: At top level: cert_vfy.c:44:5: error: conflicting types for ‘verify_signature’ int verify_signature(X509 * x509, unsigned char *data, int data_length, ^~~~~~~~~~~~~~~~ In file included from cert_vfy.c:18:0: cert_vfy.h:81:20: note: previous declaration of ‘verify_signature’ was here CERTVFY_EXTERN int verify_signature(X509 * x509, unsigned char *data, int data_length, unsigned char **signature, int *signature_length); ^~~~~~~~~~~~~~~~ Commit: c56beadac51863cfc3526c6b7e81db17f8f18c0e https://github.com/OpenSC/pam_pkcs11/commit/c56beadac51863cfc3526c6b7e81db17f8f18c0e Author: Ludovic Rousseau <lud...@fr...> Date: 2019-05-20 (Mon, 20 May 2019) Changed paths: M src/common/cert_vfy.c M src/common/cert_vfy.h Log Message: ----------- Fix verify_signature() API Fix compiler warning: pam_pkcs11.c:729:62: warning: passing argument 5 of ‘verify_signature’ from incompatible pointer type [-Wincompatible-pointer-types] random_value, sizeof(random_value), &signature, &signature_length); ^ In file included from pam_pkcs11.c:45:0: ../common/cert_vfy.h:81:20: note: expected ‘int *’ but argument is of type ‘long unsigned int *’ CERTVFY_EXTERN int verify_signature(X509 * x509, unsigned char *data, int data_length, unsigned char **signature, int *signature_length); ^~~~~~~~~~~~~~~~ Commit: 4e841a4973ec11a2bcf7791cd443a4bb33eb35aa https://github.com/OpenSC/pam_pkcs11/commit/4e841a4973ec11a2bcf7791cd443a4bb33eb35aa Author: Ludovic Rousseau <lud...@fr...> Date: 2019-05-20 (Mon, 20 May 2019) Changed paths: M src/tools/pkcs11_eventmgr.c Log Message: ----------- Fix DBG1() use pkcs11_eventmgr.c: In function ‘main’: pkcs11_eventmgr.c:482:9: warning: too many arguments for format [-Wformat-extra-args] DBG1("Malloc failed when allocating module spec", ^ ../common/debug.h:55:54: note: in definition of macro ‘DBG1’ #define DBG1(f,a) debug_print(1, __FILE__, __LINE__, f , a ) ^ pkcs11_eventmgr.c:510:26: warning: statement with no effect [-Wunused-value] for (; modList; modList->next) ~~~~~~~^~~~~~ In file included from pkcs11_eventmgr.c:33:0: pkcs11_eventmgr.c:531:9: warning: too many arguments for format [-Wformat-extra-args] DBG1("Error in daemon() call", strerror(errno)); ^ ../common/debug.h:55:54: note: in definition of macro ‘DBG1’ #define DBG1(f,a) debug_print(1, __FILE__, __LINE__, f , a ) ^ Commit: 99ce016759f2dbd1dfb64c57febf4b8ba0b1e5ae https://github.com/OpenSC/pam_pkcs11/commit/99ce016759f2dbd1dfb64c57febf4b8ba0b1e5ae Author: Ludovic Rousseau <lud...@fr...> Date: 2019-05-20 (Mon, 20 May 2019) Changed paths: M src/common/pkcs11_lib.c Log Message: ----------- Fix DBG2() use In file included from pkcs11_lib.c:31:0: pkcs11_lib.c: In function ‘find_module_by_library’: pkcs11_lib.c:265:10: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 5 has type ‘SECMODModuleList * {aka struct SECMODModuleListStr *}’ [-Wformat=] DBG2("modList = 0x%x next = 0x%x\n", modList, modList->next); ^ debug.h:56:56: note: in definition of macro ‘DBG2’ #define DBG2(f,a,b) debug_print(1, __FILE__, __LINE__, f , a , b ) ^ pkcs11_lib.c:265:10: warning: format ‘%x’ expects argument of type ‘unsigned int’, but argument 6 has type ‘SECMODModuleList * {aka struct SECMODModuleListStr *}’ [-Wformat=] DBG2("modList = 0x%x next = 0x%x\n", modList, modList->next); ^ debug.h:56:56: note: in definition of macro ‘DBG2’ #define DBG2(f,a,b) debug_print(1, __FILE__, __LINE__, f , a , b ) ^ Commit: ee8f6c020ccf6cb4bcad99cadcfde82d378a5345 https://github.com/OpenSC/pam_pkcs11/commit/ee8f6c020ccf6cb4bcad99cadcfde82d378a5345 Author: Ludovic Rousseau <lud...@fr...> Date: 2019-05-20 (Mon, 20 May 2019) Changed paths: M src/common/pkcs11_lib.c Log Message: ----------- Fix DBG1() use In file included from pkcs11_lib.c:31:0: pkcs11_lib.c:306:10: warning: too many arguments for format [-Wformat-extra-args] DBG1("Malloc failed when allocating module spec", strerror(errno)); ^ debug.h:55:54: note: in definition of macro ‘DBG1’ #define DBG1(f,a) debug_print(1, __FILE__, __LINE__, f , a ) ^ Commit: 626904cfd7b8099ee3dbb1e8b9624af3203489d0 https://github.com/OpenSC/pam_pkcs11/commit/626904cfd7b8099ee3dbb1e8b9624af3203489d0 Author: Ludovic Rousseau <lud...@fr...> Date: 2019-05-20 (Mon, 20 May 2019) Changed paths: M src/common/pkcs11_lib.c Log Message: ----------- Fix compiler warning pkcs11_lib.c: In function ‘load_pkcs11_module’: pkcs11_lib.c:295:35: warning: passing argument 1 of ‘find_module_by_library’ discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] module = find_module_by_library(pkcs11_module); ^~~~~~~~~~~~~ pkcs11_lib.c:255:22: note: expected ‘char *’ but argument is of type ‘const char *’ static SECMODModule *find_module_by_library(char *pkcs11_module) ^~~~~~~~~~~~~~~~~~~~~~ Commit: 522f0c4d4eeb4099e16e9481a55eaefad931589a https://github.com/OpenSC/pam_pkcs11/commit/522f0c4d4eeb4099e16e9481a55eaefad931589a Author: Ludovic Rousseau <lud...@fr...> Date: 2019-05-20 (Mon, 20 May 2019) Changed paths: M src/common/cert_info.c Log Message: ----------- Fix DBG1() use In file included from cert_info.c:26:0: cert_info.c: In function ‘cert_info_digest’: cert_info.c:123:10: warning: too many arguments for format [-Wformat-extra-args] DBG1("Invalid digest algorithm, using 'sha1'",algorithm); ^ debug.h:55:54: note: in definition of macro ‘DBG1’ #define DBG1(f,a) debug_print(1, __FILE__, __LINE__, f , a ) ^ Commit: ee0b3bc57dc276608dde1814996508d442f9c06f https://github.com/OpenSC/pam_pkcs11/commit/ee0b3bc57dc276608dde1814996508d442f9c06f Author: Ludovic Rousseau <lud...@fr...> Date: 2019-05-20 (Mon, 20 May 2019) Changed paths: M src/tools/pkcs11_eventmgr.c Log Message: ----------- pkcs11_eventmgr: Fix NSS module iteration pkcs11_eventmgr.c: In function ‘main’: pkcs11_eventmgr.c:510:26: warning: statement with no effect [-Wunused-value] for (; modList; modList->next) ~~~~~~~^~~~~~ Commit: 3b4f32245a5eea3a0bfdae71480f2e518dda224e https://github.com/OpenSC/pam_pkcs11/commit/3b4f32245a5eea3a0bfdae71480f2e518dda224e Author: Ludovic Rousseau <lud...@fr...> Date: 2019-05-20 (Mon, 20 May 2019) Changed paths: M src/common/cert_vfy.c Log Message: ----------- Fix DBG1() use cert_vfy.c: In function ‘verify_signature’: cert_vfy.c:519:8: warning: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘int’ [-Wformat=] DBG1("public key type: 0x%08lx", EVP_PKEY_base_id(pubkey)); ^ debug.h:55:54: note: in definition of macro ‘DBG1’ #define DBG1(f,a) debug_print(1, __FILE__, __LINE__, f , a ) ^ cert_vfy.c:520:8: warning: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 5 has type ‘int’ [-Wformat=] DBG1("public key bits: 0x%08lx", EVP_PKEY_bits(pubkey)); ^ debug.h:55:54: note: in definition of macro ‘DBG1’ #define DBG1(f,a) debug_print(1, __FILE__, __LINE__, f , a ) ^ Commit: e91bf56db33b2d1adc1aeffba1b2ad3bc36c6705 https://github.com/OpenSC/pam_pkcs11/commit/e91bf56db33b2d1adc1aeffba1b2ad3bc36c6705 Author: Ludovic Rousseau <lud...@fr...> Date: 2019-05-20 (Mon, 20 May 2019) Changed paths: M src/common/cert_vfy.c Log Message: ----------- Fix compiler warning cert_vfy.c: In function ‘verify_signature’: cert_vfy.c:508:7: warning: unused variable ‘sig_der_len’ [-Wunused-variable] int sig_der_len; ^~~~~~~~~~~ Compare: https://github.com/OpenSC/pam_pkcs11/compare/a05b4ac8a674...e91bf56db33b |
