[Opensc-commits] [OpenSC/OpenSC] 554441: OpenPGP: harmonize error messages used in LOG_TEST...

[GitHub <no...@gi...>]

  Branch: refs/heads/master
  Home:   https://github.com/OpenSC/OpenSC
  Commit: 5544418339283c12c80307e25747f7909732295c
      https://github.com/OpenSC/OpenSC/commit/5544418339283c12c80307e25747f7909732295c
  Author: Peter Marschall <pe...@ad...>
  Date:   2019-01-06 (Sun, 06 Jan 2019)

  Changed paths:
    M src/libopensc/card-openpgp.c

  Log Message:
  -----------
  OpenPGP: harmonize error messages used in LOG_TEST...() calls

Don't terminate the messages with a period, because they are going to end up
as the first argument to a format string of the form "%s: ...".
I.e. they will be part of a longer string and terminated by a colon anyway.


  Commit: 57e66fd42e7c49c3230c2628478f2060317d8730
      https://github.com/OpenSC/OpenSC/commit/57e66fd42e7c49c3230c2628478f2060317d8730
  Author: Peter Marschall <pe...@ad...>
  Date:   2019-01-06 (Sun, 06 Jan 2019)

  Changed paths:
    M src/libopensc/card-openpgp.c

  Log Message:
  -----------
  OpenPGP: harmonize error messages

Combine sequences
	sc_log(..., "...");
	LOG_FUNC_RETURN(...);
where c_log() prints a constant string
by
	LOG_TEST_RET(..., "...");

This change results in shorter, more concise code as well as
better harmonized error messages.


  Commit: bb6b78937f1b88f753117e8fd4971545123f9fac
      https://github.com/OpenSC/OpenSC/commit/bb6b78937f1b88f753117e8fd4971545123f9fac
  Author: Peter Marschall <pe...@ad...>
  Date:   2019-01-06 (Sun, 06 Jan 2019)

  Changed paths:
    M src/libopensc/card-openpgp.c

  Log Message:
  -----------
  OpenPGP: harmonize error messages around 'key_id'

* consistently use term "Invalid key ID; must be 1, 2, or 3" in error messages
  about invalid key IDs instead of various alternatives.
* use error type SC_ERROR_INVALID_ARGUMENTS instead of SC_ERROR_INVALID_DATA
  when the key_id was passed to the respective function
* harmonize the checks to consistently use 'key_id < ... || key_id > ...'

In addition, initialize a variable to keep clang & compilers on OSX happy.


Compare: https://github.com/OpenSC/OpenSC/compare/b95d936e6cf9...bb6b78937f1b
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.