[Opensc-commits] [OpenSC/OpenSC] 0a9035: OpenPGP: get rid of "magic" constants in pgp_build...

[GitHub <no...@gi...>]

  Branch: refs/heads/master
  Home:   https://github.com/OpenSC/OpenSC
  Commit: 0a903522b81ff54057d53f2bbe0abfaadbd689bd
      https://github.com/OpenSC/OpenSC/commit/0a903522b81ff54057d53f2bbe0abfaadbd689bd
  Author: Peter Marschall <pe...@ad...>
  Date:   2019-01-02 (Wed, 02 Jan 2019)

  Changed paths:
    M src/libopensc/card-openpgp.c

  Log Message:
  -----------
  OpenPGP: get rid of "magic" constants in pgp_build_extended_header_list()

Use defined symbolic names for well-known DOs to copy data to a correctly
defined buffer 'data' using ulong2bebytes() instead of relying on
"magic" constants.


  Commit: 4c51a53beda9ee6bef42a27642f1986765f92794
      https://github.com/OpenSC/OpenSC/commit/4c51a53beda9ee6bef42a27642f1986765f92794
  Author: Peter Marschall <pe...@ad...>
  Date:   2019-01-02 (Wed, 02 Jan 2019)

  Changed paths:
    M src/libopensc/card-openpgp.c

  Log Message:
  -----------
  OpenPGP: get rid of "magic" constants in gnuk_delete_key()

Use defined symbolic names for well-known DOs to copy data to a correctly
defined buffer 'data' using ulong2bebytes() instead of relying on
"magic" constants and C's string semantic.
Also use 'sizeof(data)' instead of strange strlen() calculations.


  Commit: 7092d32830d7b9074217b4d49f0c3aa33c17fb16
      https://github.com/OpenSC/OpenSC/commit/7092d32830d7b9074217b4d49f0c3aa33c17fb16
  Author: Peter Marschall <pe...@ad...>
  Date:   2019-01-02 (Wed, 02 Jan 2019)

  Changed paths:
    M src/libopensc/card-openpgp.c

  Log Message:
  -----------
  OpenPGP: get rid of "magic" constants in pgp_gen_key()

Use defined symbolic names for well-known DOs to copy data to a correctly
defined buffer 'apdu_data' using ulong2bebytes() instead of relying on
"magic" constants and C's string semantic.
Also use 'sizeof(apdu_data)' instead of additional magic constants.


Compare: https://github.com/OpenSC/OpenSC/compare/aa7118192ae9...7092d32830d7
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.