[Opensc-commits] [OpenSC/OpenSC] 738c93: OpenPGP: a few cleanups for Gnuk

[GitHub <no...@gi...>]

  Branch: refs/heads/master
  Home:   https://github.com/OpenSC/OpenSC
  Commit: 738c933609e0e6ed54dd1b71ff6092a8288718e9
      https://github.com/OpenSC/OpenSC/commit/738c933609e0e6ed54dd1b71ff6092a8288718e9
  Author: Peter Marschall <pe...@ad...>
  Date:   2018-12-17 (Mon, 17 Dec 2018)

  Changed paths:
    M src/libopensc/card-openpgp.c

  Log Message:
  -----------
  OpenPGP: a few cleanups for Gnuk

* make sure to remain within buffer size in pgp_read_blob()
* make logic more readable in pgp_get_data()


  Commit: d3e730b621921e737f3088aa75816d6a68b2cbe0
      https://github.com/OpenSC/OpenSC/commit/d3e730b621921e737f3088aa75816d6a68b2cbe0
  Author: Peter Marschall <pe...@ad...>
  Date:   2018-12-17 (Mon, 17 Dec 2018)

  Changed paths:
    M src/libopensc/card-openpgp.c

  Log Message:
  -----------
  OpenPGP: refactor error handling in pgp_put_data_plain()

* use LOG_TEST_*() macros instead of explicit coding


  Commit: 08b9f362c08ba7c7983faf08296a87c2dd9d11bc
      https://github.com/OpenSC/OpenSC/commit/08b9f362c08ba7c7983faf08296a87c2dd9d11bc
  Author: Peter Marschall <pe...@ad...>
  Date:   2018-12-17 (Mon, 17 Dec 2018)

  Changed paths:
    M src/libopensc/card-openpgp.c

  Log Message:
  -----------
  OpenPGP: refactor error handling in pgp_gen_key()

* use LOG_TEST_*() macros instead of explicit coding


  Commit: 7916d45857b2c00c39dc7844ac52718423c37e0b
      https://github.com/OpenSC/OpenSC/commit/7916d45857b2c00c39dc7844ac52718423c37e0b
  Author: Peter Marschall <pe...@ad...>
  Date:   2018-12-17 (Mon, 17 Dec 2018)

  Changed paths:
    M src/libopensc/card-openpgp.c

  Log Message:
  -----------
  OpenPGP: refactor error handling in pgp_store_key()

* use LOG_TEST_*() macros instead of explicit coding
* harmonize use of card->ctx: saves one variable
* explictly compare pointers to != NULL


  Commit: bf2a9bc53b6bcaee9fa85d50414aee9399a6e0bb
      https://github.com/OpenSC/OpenSC/commit/bf2a9bc53b6bcaee9fa85d50414aee9399a6e0bb
  Author: Peter Marschall <pe...@ad...>
  Date:   2018-12-17 (Mon, 17 Dec 2018)

  Changed paths:
    M src/libopensc/card-openpgp.c

  Log Message:
  -----------
  OpenPGP: refactor error handling in pgp_build_extended_header_list()

* use LOG_TEST_*() macros instead of explicit coding


  Commit: c7fc7cc134361e2a63759bd9a599ee1a6638c536
      https://github.com/OpenSC/OpenSC/commit/c7fc7cc134361e2a63759bd9a599ee1a6638c536
  Author: Peter Marschall <pe...@ad...>
  Date:   2018-12-17 (Mon, 17 Dec 2018)

  Changed paths:
    M src/libopensc/card-openpgp.c

  Log Message:
  -----------
  OpenPGP: refactor error handling in pgp_calculate_and_store_fingerprint()

* initialize pointers to NULL
* explicitly compare pointers to NULL
* use LOG_TEST_*() macros instead of explicit coding


  Commit: b1539545d0ad3116c3efe1482855eb1eaf56e451
      https://github.com/OpenSC/OpenSC/commit/b1539545d0ad3116c3efe1482855eb1eaf56e451
  Author: Peter Marschall <pe...@ad...>
  Date:   2018-12-17 (Mon, 17 Dec 2018)

  Changed paths:
    M src/libopensc/card-openpgp.c

  Log Message:
  -----------
  OpenPGP: free() unconditionally in error handling of pgp_store_key()


Compare: https://github.com/OpenSC/OpenSC/compare/01287e393ebe...b1539545d0ad
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.