[Opensc-commits] [OpenSC/OpenSC] d517d8: Fix minidriver padding

[GitHub <no...@gi...>]

  Branch: refs/heads/master
  Home:   https://github.com/OpenSC/OpenSC
  Commit: d517d8e18d9c7f918e38de7e613e34f6b3d21f09
      https://github.com/OpenSC/OpenSC/commit/d517d8e18d9c7f918e38de7e613e34f6b3d21f09
  Author: Luka Logar <luk...@in...>
  Date:   2018-10-11 (Thu, 11 Oct 2018)

  Changed paths:
    M src/libopensc/padding.c
    M src/minidriver/minidriver.c

  Log Message:
  -----------
  Fix minidriver padding

Commit e5707b545e5a2dc33b0ca52a8bf63f36f71b3d85 broke signing using minidriver on Windows.

More specifically changing #define SC_ALGORITHM_RSA_PAD_NONE from 0x00000000 to 0x00000001 caused a call to sc_pkcs1_encode() to fail as the padding algorithm was not specified anywhere in the CardSignData() implementation. It kind of worked as long as SC_ALGORITHM_RSA_PAD_NONE was 0x00000000, but the above mentioned commit broke this.

Now padding algorithm has to be explicitly specified, otherwise a call to sc_pkcs1_encode() will fail.



      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.