[Opensc-commits] [OpenSC/OpenSC] 44d611: OpenPGP: slight cleanups

[GitHub <no...@gi...>]

  Branch: refs/heads/master
  Home:   https://github.com/OpenSC/OpenSC
  Commit: 44d6116c59c40086d11001b44113b3266ee32a38
      https://github.com/OpenSC/OpenSC/commit/44d6116c59c40086d11001b44113b3266ee32a38
  Author: Peter Marschall <pe...@ad...>
  Date:   2018-10-10 (Wed, 10 Oct 2018)

  Changed paths:
    M src/libopensc/card-openpgp.c

  Log Message:
  -----------
  OpenPGP: slight cleanups

* use variables if they are already there
* be a bit more explicit in logging
* more consistent tag format: %04X
* cleanup flag setting for _sc_card_add_rsa_alg()


  Commit: f1ae31aea40e9dc362b7e9ed8be1fcb594464786
      https://github.com/OpenSC/OpenSC/commit/f1ae31aea40e9dc362b7e9ed8be1fcb594464786
  Author: Peter Marschall <pe...@ad...>
  Date:   2018-10-10 (Wed, 10 Oct 2018)

  Changed paths:
    M src/libopensc/card-openpgp.c

  Log Message:
  -----------
  OpenPGP: expose additional algorithms only with EXT_CAP_ALG_ATTR_CHANGEABLE

List additional algorithms & attributes as supported only when the card
supports changing the algorithms attributes DOs and exposes this by having
the EXT_CAP_ALG_ATTR_CHANGEABLE capability set.

Using different algorithms and attributes requires changing the algorithm
attributes DOs. If that is not supported - as indicated by a missing
EXT_CAP_ALG_ATTR_CHANGEABLE capability - then only those algorithms
described by the current algorithms attributes DOs' contents can be used.

In addition simplify setting the flags.


  Commit: 772d20969ac9607a6961c9ce9574b71a95d65717
      https://github.com/OpenSC/OpenSC/commit/772d20969ac9607a6961c9ce9574b71a95d65717
  Author: Peter Marschall <pe...@ad...>
  Date:   2018-10-10 (Wed, 10 Oct 2018)

  Changed paths:
    M src/libopensc/card-openpgp.c
    M src/libopensc/cardctl.h
    M src/pkcs15init/pkcs15-openpgp.c
    M src/tools/openpgp-tool.c

  Log Message:
  -----------
  OpenPGP: first steps to support key types beyond RSA

- rename 'keytype' in some OpenPGP-specific types to 'key_id'
  because they key ID was what the field was used for
- introduce field 'algorithm' in the structures above
  to indicate the key's algorithm: RSA, ...
- define constant SC_OPENPGP_KEYALGO_RSA and use it
- rename constants SC_OPENPGP_KEYFORMAT_* to SC_OPENPGP_KEYFORMAT_RSA_*
  because they are RSA specific


  Commit: c2f02f72bd07655b3e60b2f8aeb9eea3bb8f36bd
      https://github.com/OpenSC/OpenSC/commit/c2f02f72bd07655b3e60b2f8aeb9eea3bb8f36bd
  Author: Peter Marschall <pe...@ad...>
  Date:   2018-10-10 (Wed, 10 Oct 2018)

  Changed paths:
    M src/libopensc/card-openpgp.c
    M src/libopensc/cardctl.h
    M src/pkcs15init/pkcs15-openpgp.c
    M src/tools/openpgp-tool.c

  Log Message:
  -----------
  OpenPGP: adapt data structures to support RSA alternatives

* update callers to use the adapted structures.


  Commit: 248ece23c60cb1b519ba29cb8315d7d03a6be6ff
      https://github.com/OpenSC/OpenSC/commit/248ece23c60cb1b519ba29cb8315d7d03a6be6ff
  Author: Peter Marschall <pe...@ad...>
  Date:   2018-10-10 (Wed, 10 Oct 2018)

  Changed paths:
    M src/libopensc/card-openpgp.c
    M src/pkcs15init/pkcs15-openpgp.c
    M src/tools/openpgp-tool.c

  Log Message:
  -----------
  OpenPGP: bail out on non-RSA key generation/import

Also add the necessary algorithm info where necessary.


  Commit: 8a564107a8a5976dd65219921929a9dcf2d2d712
      https://github.com/OpenSC/OpenSC/commit/8a564107a8a5976dd65219921929a9dcf2d2d712
  Author: Peter Marschall <pe...@ad...>
  Date:   2018-10-10 (Wed, 10 Oct 2018)

  Changed paths:
    M src/libopensc/card-openpgp.c

  Log Message:
  -----------
  OpenPGP: introduce gpg_parse_algo_attr_blob()

Introduce a central function to parse the algorithm atributes in DOs C1 - C3.


  Commit: 550665b906da292a256bdc446bb46c45d2f77714
      https://github.com/OpenSC/OpenSC/commit/550665b906da292a256bdc446bb46c45d2f77714
  Author: Peter Marschall <pe...@ad...>
  Date:   2018-10-10 (Wed, 10 Oct 2018)

  Changed paths:
    M src/libopensc/card-openpgp.c

  Log Message:
  -----------
  OpenPGP: refactor pgp_get_card_features()

Use pgp_parse_alog_attr_blob() to get the algorithm attribute DO's contents.


Compare: https://github.com/OpenSC/OpenSC/compare/ea6f7cfe1db8...550665b906da
      **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/

      Functionality will be removed from GitHub.com on January 31st, 2019.