[Opensc-devel] Fix (default) compiler warnings and be more strict

[Ludovic R. <lud...@gm...>]

Hello,

I worked on the idea that important warnings should NOT be ignored.
To do that I add the compilation flag -Werror so that a compilation warning
is considered as an error and the automatic compilation from travis-CI will
report the build in error.

The current master branch already reports problems, without changing the
compiler warnings level.
See [1] for the GNU/Linux gcc 4.6.3 compilation and [2] for the GNU/Linux
clang 3.4 compilation.
And [3] for the Mac OS X gcc LLVM 6.0 and [4] for the Mac OS X clang LLVM
6.0.

If I enable -Werror (as done in my travis PR [5]) the 4 compilations fails.
I have not modified the compilation on MinGW.

My plan is to:
1. fix the few warnings reported
2. merge the -Werror change so that all future PR will be tested
3. increase the warning level and fix corresponding bugs (if time permit)

Comments?
Volunteers to help on this task?

Regards,

[1] https://travis-ci.org/OpenSC/OpenSC/jobs/112371473
[2] https://travis-ci.org/OpenSC/OpenSC/jobs/112371472
[3] https://travis-ci.org/OpenSC/OpenSC/jobs/112418930
[4] https://travis-ci.org/OpenSC/OpenSC/jobs/112418929
[5] https://github.com/OpenSC/OpenSC/pull/692

-- 
 Dr. Ludovic Rousseau