Menu
▾
▴
[Opensc-commits] [OpenSC/OpenSC] 3341c5: OpenPGP: make logical structure clearer
|
From: GitHub <no...@gi...> - 2015-10-17 15:36:43
|
Branch: refs/heads/master Home: https://github.com/OpenSC/OpenSC Commit: 3341c5bb8f97de858a27e5350236817bc5c8e0bc https://github.com/OpenSC/OpenSC/commit/3341c5bb8f97de858a27e5350236817bc5c8e0bc Author: Peter Marschall <pe...@ad...> Date: 2015-10-15 (Thu, 15 Oct 2015) Changed paths: M src/libopensc/card-openpgp.c Log Message: ----------- OpenPGP: make logical structure clearer - one line per sub-term in the condition of the conditional statement Commit: d2b1c8228f19741a59d26f071e4cc238f4b65f45 https://github.com/OpenSC/OpenSC/commit/d2b1c8228f19741a59d26f071e4cc238f4b65f45 Author: Peter Marschall <pe...@ad...> Date: 2015-10-15 (Thu, 15 Oct 2015) Changed paths: M src/libopensc/card-openpgp.c Log Message: ----------- OpenPGP: set apdu_case on declaration - use ternary operator to set apdu_case immediately on declaration for the GNUK and non-GNUK case Commit: 1a05f968bdfe779522ff9dfffffcdcfda4877a1a https://github.com/OpenSC/OpenSC/commit/1a05f968bdfe779522ff9dfffffcdcfda4877a1a Author: Peter Marschall <pe...@ad...> Date: 2015-10-15 (Thu, 15 Oct 2015) Changed paths: M src/libopensc/card-openpgp.c Log Message: ----------- OpenPGP: simplify gnuk_write_certificate() - get rid of unnecessary variables - use for-loop to initialize/check/increase run variable in one place - restrict variables to the necessary scope - use ternary operator inside a statement instead of if...else... Commit: 7ba47fd5a97ea03a16bf00c715c6da0e4f5279ed https://github.com/OpenSC/OpenSC/commit/7ba47fd5a97ea03a16bf00c715c6da0e4f5279ed Author: Peter Marschall <pe...@ad...> Date: 2015-10-15 (Thu, 15 Oct 2015) Changed paths: M src/libopensc/card-openpgp.c Log Message: ----------- OpenPGP: consistently use card->ctx in pgp_put_data_plain() - get rid of unnecessary variable - harmonize coding style: adapt to prevailing use of card->ctx Commit: 3d4fbd776df2a340a440db38d7a797b78255653b https://github.com/OpenSC/OpenSC/commit/3d4fbd776df2a340a440db38d7a797b78255653b Author: Peter Marschall <pe...@ad...> Date: 2015-10-15 (Thu, 15 Oct 2015) Changed paths: M src/libopensc/card-openpgp.c Log Message: ----------- OpenPGP: harmonize coding style - 2 line breaks between functions for easier reading - function type on separate line - mark each function as 'ABI' or 'Internal' - slightly doxygen-ize comments introducing functions - fix typos in comments - break over-long comment lines - break comment lines at sensible places - consistent calling style for DRVDATA() - no code change Commit: 3d492ae3768f847f5dffabc988dbc8c1cfaa1c23 https://github.com/OpenSC/OpenSC/commit/3d492ae3768f847f5dffabc988dbc8c1cfaa1c23 Author: Peter Marschall <pe...@ad...> Date: 2015-10-15 (Thu, 15 Oct 2015) Changed paths: M src/libopensc/card-openpgp.c Log Message: ----------- OpenPGP: cleanup pgp_erase_card() - get rid of unnecessary variable - use easily understandable hex representation of APDUs - auto-calculate APDU length based on hex representation - restrict scope of some variables - use sc_log() instead of directly writing to console - line breaks & comments for easier reading/understanding - fix typo in log message Commit: 2a269c526732134134fb5bcb12557092dd2d8ffe https://github.com/OpenSC/OpenSC/commit/2a269c526732134134fb5bcb12557092dd2d8ffe Author: Peter Marschall <pe...@ad...> Date: 2015-10-15 (Thu, 15 Oct 2015) Changed paths: M src/libopensc/card-openpgp.c Log Message: ----------- OpenPGP: cleanup pgp_build_tlv() - get rid of intermediate variable - clarify check in while() loop - line breaks for easier reading Commit: 69b482dce6ebda9ca3b03154b55ec6b7753077e6 https://github.com/OpenSC/OpenSC/commit/69b482dce6ebda9ca3b03154b55ec6b7753077e6 Author: Peter Marschall <pe...@ad...> Date: 2015-10-15 (Thu, 15 Oct 2015) Changed paths: M src/libopensc/card-openpgp.c Log Message: ----------- OpenPGP: cleanup pgp_get_card_features() - bug fix: re-initialize index to start searching at the right place - get rid of unnecessary variable - add some line breaks & comemnts for easier understanding Commit: 7c2adb1fc8ff4a897d277ac85085b24ca95e867a https://github.com/OpenSC/OpenSC/commit/7c2adb1fc8ff4a897d277ac85085b24ca95e867a Author: Peter Marschall <pe...@ad...> Date: 2015-10-15 (Thu, 15 Oct 2015) Changed paths: M src/libopensc/card-openpgp.c Log Message: ----------- OpenPGP: 1st preparations for newer versions - add references to new specs - add new enum _version constants Commit: e1db96b73b2474f235cd9734d9e56a748029fd9a https://github.com/OpenSC/OpenSC/commit/e1db96b73b2474f235cd9734d9e56a748029fd9a Author: Peter Marschall <pe...@ad...> Date: 2015-10-15 (Thu, 15 Oct 2015) Changed paths: M src/libopensc/card-openpgp.c Log Message: ----------- OpenPGP: extend pgp_match_card() - explicitly check for supported versions - log successful matches by AID with their type - log detection of unsupported OpenPGP-type cards Commit: 7078fbd505bedbeb8706364eebed4ffbafc905da https://github.com/OpenSC/OpenSC/commit/7078fbd505bedbeb8706364eebed4ffbafc905da Author: Peter Marschall <pe...@ad...> Date: 2015-10-15 (Thu, 15 Oct 2015) Changed paths: M src/libopensc/card-openpgp.c Log Message: ----------- OpenPGP: cleanup pgp_init() - use LOG_FUNC_RETURN instead of return for symmetry with LOG_FUNC_CALLED Commit: a0ca6b2ef06de29b7839187962782ac65c72a969 https://github.com/OpenSC/OpenSC/commit/a0ca6b2ef06de29b7839187962782ac65c72a969 Author: Peter Marschall <pe...@ad...> Date: 2015-10-15 (Thu, 15 Oct 2015) Changed paths: M src/libopensc/card-openpgp.c Log Message: ----------- OpenPGP: set card's version in pgp_init() Commit: 6109a8792dc1185175c23a51f4a7d2ac016d1dc0 https://github.com/OpenSC/OpenSC/commit/6109a8792dc1185175c23a51f4a7d2ac016d1dc0 Author: Peter Marschall <pe...@ad...> Date: 2015-10-15 (Thu, 15 Oct 2015) Changed paths: M src/libopensc/pkcs15-openpgp.c Log Message: ----------- OpenPGP: add additional manufacturers Commit: 249f258ff25bd85dafad09283e9fa575d313db46 https://github.com/OpenSC/OpenSC/commit/249f258ff25bd85dafad09283e9fa575d313db46 Author: Frank Morgner <mo...@in...> Date: 2015-10-17 (Sat, 17 Oct 2015) Changed paths: M src/libopensc/card-openpgp.c M src/libopensc/pkcs15-openpgp.c Log Message: ----------- Merge pull request #584 from marschap/card-openpgp-cleanup2 OpenPGP card cleanup Compare: https://github.com/OpenSC/OpenSC/compare/4ddf2cc04288...249f258ff25b |
