[Opensc-commits] [OpenSC/OpenSC] de58f5: msc: check the length of input

[GitHub <no...@gi...>]

  Branch: refs/heads/master
  Home:   https://github.com/OpenSC/OpenSC
  Commit: de58f5101236f6a1b835cc8304fbf230d6aa1af4
      https://github.com/OpenSC/OpenSC/commit/de58f5101236f6a1b835cc8304fbf230d6aa1af4
  Author: Frank Morgner <mo...@in...>
  Date:   2015-09-17 (Thu, 17 Sep 2015)

  Changed paths:
    M src/libopensc/muscle.c

  Log Message:
  -----------
  msc: check the length of input


  Commit: ba3890f8e0280e68f91cc4d0ce235d11c6319560
      https://github.com/OpenSC/OpenSC/commit/ba3890f8e0280e68f91cc4d0ce235d11c6319560
  Author: Frank Morgner <mo...@in...>
  Date:   2015-09-17 (Thu, 17 Sep 2015)

  Changed paths:
    M src/libopensc/card-openpgp.c

  Log Message:
  -----------
  Checks result of calloc


  Commit: 30d4f52718437cb998a26ab926698386fd949e15
      https://github.com/OpenSC/OpenSC/commit/30d4f52718437cb998a26ab926698386fd949e15
  Author: Frank Morgner <mo...@in...>
  Date:   2015-09-17 (Thu, 17 Sep 2015)

  Changed paths:
    M src/libopensc/pkcs15-tccardos.c

  Log Message:
  -----------
  Checks untrusted input


  Commit: 8a225eb42b067c07f674b10432464538a2ca9106
      https://github.com/OpenSC/OpenSC/commit/8a225eb42b067c07f674b10432464538a2ca9106
  Author: Frank Morgner <mo...@in...>
  Date:   2015-09-17 (Thu, 17 Sep 2015)

  Changed paths:
    M src/libopensc/card-iasecc.c
    M src/pkcs15init/pkcs15-isoApplet.c

  Log Message:
  -----------
  Avoids potential NULL pointer deref


  Commit: 63a9ad79b6ffb609758c643a0797f59498ec71a0
      https://github.com/OpenSC/OpenSC/commit/63a9ad79b6ffb609758c643a0797f59498ec71a0
  Author: Frank Morgner <mo...@in...>
  Date:   2015-09-17 (Thu, 17 Sep 2015)

  Changed paths:
    M src/pkcs15init/pkcs15-isoApplet.c

  Log Message:
  -----------
  Assumes that p15card->card are set

The check for NULL was bogus anyway


  Commit: b5de72fe13b3f2246963ebd7fa48c6a2bc8fb68c
      https://github.com/OpenSC/OpenSC/commit/b5de72fe13b3f2246963ebd7fa48c6a2bc8fb68c
  Author: Frank Morgner <mo...@in...>
  Date:   2015-09-17 (Thu, 17 Sep 2015)

  Changed paths:
    M src/scconf/parse.c

  Log Message:
  -----------
  fix potention NULL deref


  Commit: 59254d9d88a0023c32698fb109405180189817b7
      https://github.com/OpenSC/OpenSC/commit/59254d9d88a0023c32698fb109405180189817b7
  Author: Frank Morgner <mo...@in...>
  Date:   2015-09-17 (Thu, 17 Sep 2015)

  Changed paths:
    M src/libopensc/card-piv.c

  Log Message:
  -----------
  Checks on errors for ftell and fseek


  Commit: 69de207c21deaa9bd6aef9b69d7d3167cd845cee
      https://github.com/OpenSC/OpenSC/commit/69de207c21deaa9bd6aef9b69d7d3167cd845cee
  Author: Frank Morgner <mo...@in...>
  Date:   2015-09-17 (Thu, 17 Sep 2015)

  Changed paths:
    M src/libopensc/card-oberthur.c

  Log Message:
  -----------
  Fixes bad type cast


  Commit: f08985086ac31f3b5a74b1b5637ac8f3339e8753
      https://github.com/OpenSC/OpenSC/commit/f08985086ac31f3b5a74b1b5637ac8f3339e8753
  Author: Frank Morgner <mo...@in...>
  Date:   2015-09-17 (Thu, 17 Sep 2015)

  Changed paths:
    M src/tools/pkcs15-tool.c

  Log Message:
  -----------
  Fixes potential buffer overrun


  Commit: 69320f9d54605f1c4d18ef9843f4a0a9582bb0a7
      https://github.com/OpenSC/OpenSC/commit/69320f9d54605f1c4d18ef9843f4a0a9582bb0a7
  Author: Frank Morgner <mo...@in...>
  Date:   2015-09-17 (Thu, 17 Sep 2015)

  Changed paths:
    M src/libopensc/ctbcs.c

  Log Message:
  -----------
  Checks for out of bounds write


  Commit: 07038225a74a738f1916e882d97a45ac4b344c13
      https://github.com/OpenSC/OpenSC/commit/07038225a74a738f1916e882d97a45ac4b344c13
  Author: Frank Morgner <mo...@in...>
  Date:   2015-09-17 (Thu, 17 Sep 2015)

  Changed paths:
    M src/libopensc/pkcs15-gemsafeV1.c

  Log Message:
  -----------
  Fixes out of bounds read


  Commit: e4bce1ca6126efb1eed3acd1c943af2875abc6a2
      https://github.com/OpenSC/OpenSC/commit/e4bce1ca6126efb1eed3acd1c943af2875abc6a2
  Author: Frank Morgner <mo...@in...>
  Date:   2015-09-17 (Thu, 17 Sep 2015)

  Changed paths:
    M src/pkcs15init/pkcs15-cardos.c

  Log Message:
  -----------
  Fixes dependency on uninitialized data


  Commit: 6c01750ba80e57f4be35c9f4e8e34ee2dec321fa
      https://github.com/OpenSC/OpenSC/commit/6c01750ba80e57f4be35c9f4e8e34ee2dec321fa
  Author: Frank Morgner <mo...@in...>
  Date:   2015-09-17 (Thu, 17 Sep 2015)

  Changed paths:
    M src/libopensc/card-authentic.c

  Log Message:
  -----------
  Removes dead code


  Commit: c22ffd95bf7932cfe230d59e2b92a9aa69f345be
      https://github.com/OpenSC/OpenSC/commit/c22ffd95bf7932cfe230d59e2b92a9aa69f345be
  Author: Frank Morgner <mo...@in...>
  Date:   2015-09-17 (Thu, 17 Sep 2015)

  Changed paths:
    M src/pkcs15init/pkcs15-lib.c

  Log Message:
  -----------
  Fixed warning about unused variable


  Commit: 5902587889f8d70499ad76366af044a7e5a0be70
      https://github.com/OpenSC/OpenSC/commit/5902587889f8d70499ad76366af044a7e5a0be70
  Author: Frank Morgner <mo...@in...>
  Date:   2015-09-17 (Thu, 17 Sep 2015)

  Changed paths:
    M src/pkcs15init/pkcs15-oberthur.c

  Log Message:
  -----------
  Removed dead code


  Commit: 0fe282414f17777487cb6bd09ca7897f1f595a7e
      https://github.com/OpenSC/OpenSC/commit/0fe282414f17777487cb6bd09ca7897f1f595a7e
  Author: Frank Morgner <mo...@in...>
  Date:   2015-09-17 (Thu, 17 Sep 2015)

  Changed paths:
    M src/pkcs15init/pkcs15-oberthur.c

  Log Message:
  -----------
  Fixed warning about unused function


  Commit: be073396be865c3b35c670a1abfab9e6d259639d
      https://github.com/OpenSC/OpenSC/commit/be073396be865c3b35c670a1abfab9e6d259639d
  Author: Frank Morgner <mo...@in...>
  Date:   2015-09-17 (Thu, 17 Sep 2015)

  Changed paths:
    M src/libopensc/card-piv.c
    M src/libopensc/card-westcos.c
    M src/libopensc/pkcs15-itacns.c

  Log Message:
  -----------
  Fixes warnings about unused variables/functions


  Commit: fe31aceacb86a02d138748e316de7af25269f551
      https://github.com/OpenSC/OpenSC/commit/fe31aceacb86a02d138748e316de7af25269f551
  Author: Frank Morgner <mo...@in...>
  Date:   2015-09-17 (Thu, 17 Sep 2015)

  Changed paths:
    M src/libopensc/card-iasecc.c

  Log Message:
  -----------
  Fixes signature of iasecc_read_public_key


  Commit: 1e2a42dae582ee48c601d821f76c77d0b85ea988
      https://github.com/OpenSC/OpenSC/commit/1e2a42dae582ee48c601d821f76c77d0b85ea988
  Author: Frank Morgner <mo...@in...>
  Date:   2015-09-17 (Thu, 17 Sep 2015)

  Changed paths:
    M src/libopensc/card-dnie.c

  Log Message:
  -----------
  Fixes warning about unused variables


  Commit: 7120a9b549ba55f2ebac41300e129b9fe95dd454
      https://github.com/OpenSC/OpenSC/commit/7120a9b549ba55f2ebac41300e129b9fe95dd454
  Author: Frank Morgner <mo...@in...>
  Date:   2015-09-25 (Fri, 25 Sep 2015)

  Changed paths:
    M src/libopensc/card-authentic.c
    M src/libopensc/card-dnie.c
    M src/libopensc/card-iasecc.c
    M src/libopensc/card-oberthur.c
    M src/libopensc/card-openpgp.c
    M src/libopensc/card-piv.c
    M src/libopensc/card-westcos.c
    M src/libopensc/ctbcs.c
    M src/libopensc/muscle.c
    M src/libopensc/pkcs15-gemsafeV1.c
    M src/libopensc/pkcs15-itacns.c
    M src/libopensc/pkcs15-tccardos.c
    M src/pkcs15init/pkcs15-cardos.c
    M src/pkcs15init/pkcs15-isoApplet.c
    M src/pkcs15init/pkcs15-lib.c
    M src/pkcs15init/pkcs15-oberthur.c
    M src/scconf/parse.c
    M src/tools/pkcs15-tool.c

  Log Message:
  -----------
  Merge pull request #554 from frankmorgner/fixes

Some more fixes for problems reported by Coverity scan


Compare: https://github.com/OpenSC/OpenSC/compare/4814863d188f...7120a9b549ba