Menu
▾
▴
[Opensc-commits] [OpenSC/OpenSC] 689ece: card-masktech.c: code improvements
|
From: GitHub <no...@gi...> - 2015-05-08 07:19:03
|
Branch: refs/heads/master Home: https://github.com/OpenSC/OpenSC Commit: 689ece205ae04ac65a9941b7568ab84b36f94475 https://github.com/OpenSC/OpenSC/commit/689ece205ae04ac65a9941b7568ab84b36f94475 Author: vletoux <vin...@gm...> Date: 2015-05-08 (Fri, 08 May 2015) Changed paths: M src/libopensc/card-masktech.c Log Message: ----------- card-masktech.c: code improvements fixes #457 Commit: 6523f3fcb9fe78650597be2710e69818e0c92b13 https://github.com/OpenSC/OpenSC/commit/6523f3fcb9fe78650597be2710e69818e0c92b13 Author: Frank Morgner <mo...@in...> Date: 2015-05-08 (Fri, 08 May 2015) Changed paths: M src/libopensc/log.h Log Message: ----------- added LOG_TEST_GOTO_ERR and SC_TEST_GOTO_ERR Don't forget to set the error label! Commit: 1f69a0d6879d969aaa88af0efba09810d3208567 https://github.com/OpenSC/OpenSC/commit/1f69a0d6879d969aaa88af0efba09810d3208567 Author: Frank Morgner <mo...@in...> Date: 2015-05-08 (Fri, 08 May 2015) Changed paths: M src/libopensc/card-authentic.c Log Message: ----------- fixed indenting Commit: c7afbb4ca2bdeec80e5c60008bbf800d6916d86c https://github.com/OpenSC/OpenSC/commit/c7afbb4ca2bdeec80e5c60008bbf800d6916d86c Author: Frank Morgner <mo...@in...> Date: 2015-05-08 (Fri, 08 May 2015) Changed paths: M src/libopensc/pkcs15-algo.c Log Message: ----------- pkcs15-algo: fixed resource leak Commit: 9263da49aaa33b3bc1d26e396a392eb9ca06400b https://github.com/OpenSC/OpenSC/commit/9263da49aaa33b3bc1d26e396a392eb9ca06400b Author: Frank Morgner <mo...@in...> Date: 2015-05-08 (Fri, 08 May 2015) Changed paths: M src/libopensc/pkcs15.c Log Message: ----------- pkcs15: fixed resource leak Commit: 3a6c4a0e1d2a40b1746b5cd9f4212347a9dc364d https://github.com/OpenSC/OpenSC/commit/3a6c4a0e1d2a40b1746b5cd9f4212347a9dc364d Author: Frank Morgner <mo...@in...> Date: 2015-05-08 (Fri, 08 May 2015) Changed paths: M src/libopensc/pkcs15-cache.c Log Message: ----------- pkcs15-cache: fixed resource leak Commit: 18e962942baddb943ae53c91b4ab061580e4636e https://github.com/OpenSC/OpenSC/commit/18e962942baddb943ae53c91b4ab061580e4636e Author: Viktor Tarasov <vik...@gm...> Date: 2015-05-08 (Fri, 08 May 2015) Changed paths: M src/libopensc/pkcs15-data.c Log Message: ----------- pkcs15-data: fix memory leakage Commit: 841d89dda685c1698a0011a7b3c50d29527ade74 https://github.com/OpenSC/OpenSC/commit/841d89dda685c1698a0011a7b3c50d29527ade74 Author: Frank Morgner <mo...@in...> Date: 2015-05-08 (Fri, 08 May 2015) Changed paths: M src/libopensc/pkcs15-pubkey.c Log Message: ----------- pkcs15-pubkey: fixed resource leak Commit: 3cfb44d70464ad126e5a098a283a8c9c32135594 https://github.com/OpenSC/OpenSC/commit/3cfb44d70464ad126e5a098a283a8c9c32135594 Author: Frank Morgner <mo...@in...> Date: 2015-05-08 (Fri, 08 May 2015) Changed paths: M src/libopensc/pkcs15-syn.c Log Message: ----------- pkcs15-syn: fixed resource leak Commit: e215b7b4fb5d51d72dc44bb7ac9dbc6fb5348426 https://github.com/OpenSC/OpenSC/commit/e215b7b4fb5d51d72dc44bb7ac9dbc6fb5348426 Author: Frank Morgner <mo...@in...> Date: 2015-05-08 (Fri, 08 May 2015) Changed paths: M src/libsm/sm-common.c Log Message: ----------- sm-common: fixed resource leak Commit: 4af4308d19ebcfccf757202e3bd0fc6eed49aefe https://github.com/OpenSC/OpenSC/commit/4af4308d19ebcfccf757202e3bd0fc6eed49aefe Author: Frank Morgner <mo...@in...> Date: 2015-05-08 (Fri, 08 May 2015) Changed paths: M src/libopensc/card-authentic.c M src/pkcs15init/pkcs15-authentic.c Log Message: ----------- authentic: fixed resource leak pkcs15-authentic: fixed resource leak card-authentic: fixed resource leak Commit: d4fd135e2040670b35c79c9fbe5c641d31c9bd00 https://github.com/OpenSC/OpenSC/commit/d4fd135e2040670b35c79c9fbe5c641d31c9bd00 Author: Frank Morgner <mo...@in...> Date: 2015-05-08 (Fri, 08 May 2015) Changed paths: M src/pkcs15init/pkcs15-cflex.c Log Message: ----------- pkcs15-cflex: fixed resource leak Commit: 68becc8fc491cc27a7eb3f8cd8e5291308457f7c https://github.com/OpenSC/OpenSC/commit/68becc8fc491cc27a7eb3f8cd8e5291308457f7c Author: Frank Morgner <mo...@in...> Date: 2015-05-08 (Fri, 08 May 2015) Changed paths: M src/pkcs15init/pkcs15-gpk.c Log Message: ----------- pkcs15-gpk: fixed resource leak Commit: 475ce71453080c190ffddaba38d04fe6c8d43087 https://github.com/OpenSC/OpenSC/commit/475ce71453080c190ffddaba38d04fe6c8d43087 Author: Viktor Tarasov <vik...@gm...> Date: 2015-05-08 (Fri, 08 May 2015) Changed paths: M src/libopensc/card-iasecc.c M src/pkcs15init/pkcs15-iasecc.c Log Message: ----------- iasecc: fixed resource leak pkcs15-iasecc: fix memory leakage iasecc: fix memory leakage Commit: ac84d282b1a5e7aae8d68ea7b15a214d4f28687d https://github.com/OpenSC/OpenSC/commit/ac84d282b1a5e7aae8d68ea7b15a214d4f28687d Author: Viktor Tarasov <vik...@gm...> Date: 2015-05-08 (Fri, 08 May 2015) Changed paths: M src/libopensc/card-myeid.c M src/pkcs15init/pkcs15-myeid.c Log Message: ----------- myeid: fixed resource leak pkcs15-myeid: fix memory leakage myeid: fix memory leakage Commit: d636338eaf597e20e3e7c2a33146c5de7c9bc413 https://github.com/OpenSC/OpenSC/commit/d636338eaf597e20e3e7c2a33146c5de7c9bc413 Author: Viktor Tarasov <vik...@gm...> Date: 2015-05-08 (Fri, 08 May 2015) Changed paths: M src/pkcs15init/pkcs15-oberthur-awp.c Log Message: ----------- pkcs15-oberthur: fix memory leakage Commit: 44253c63d08f39c0ea35eab2b96d46719c3abcef https://github.com/OpenSC/OpenSC/commit/44253c63d08f39c0ea35eab2b96d46719c3abcef Author: Frank Morgner <mo...@in...> Date: 2015-05-08 (Fri, 08 May 2015) Changed paths: M src/pkcs15init/pkcs15-rtecp.c Log Message: ----------- pkcs15-rtecp: fixed resource leak Commit: 6cb99be8219026e7d1354ab3216af26596c66f49 https://github.com/OpenSC/OpenSC/commit/6cb99be8219026e7d1354ab3216af26596c66f49 Author: Frank Morgner <mo...@in...> Date: 2015-05-08 (Fri, 08 May 2015) Changed paths: M src/pkcs15init/pkcs15-setcos.c Log Message: ----------- pkcs15-setcos: fixed resource leak Commit: 01e573b9876b6538d85e85c16d2a3f2085ebb1cd https://github.com/OpenSC/OpenSC/commit/01e573b9876b6538d85e85c16d2a3f2085ebb1cd Author: Frank Morgner <mo...@in...> Date: 2015-05-08 (Fri, 08 May 2015) Changed paths: M src/pkcs15init/profile.c Log Message: ----------- profile: fixed resource leak Commit: efbd4068af4e475ead56c295b85911af89959d0d https://github.com/OpenSC/OpenSC/commit/efbd4068af4e475ead56c295b85911af89959d0d Author: Frank Morgner <mo...@in...> Date: 2015-05-08 (Fri, 08 May 2015) Changed paths: M src/smm/sm-cwa14890.c Log Message: ----------- sm-cwa14890: fixed resource leak Commit: b0a708b0bb2f25be9d417e56b78ba6f20f2a1d78 https://github.com/OpenSC/OpenSC/commit/b0a708b0bb2f25be9d417e56b78ba6f20f2a1d78 Author: Frank Morgner <mo...@in...> Date: 2015-05-08 (Fri, 08 May 2015) Changed paths: M src/tests/pintest.c Log Message: ----------- pintest: fixed resource leak Commit: c65caed7f4ce3b3146054eafc5bb2ed426931a38 https://github.com/OpenSC/OpenSC/commit/c65caed7f4ce3b3146054eafc5bb2ed426931a38 Author: Frank Morgner <mo...@in...> Date: 2015-05-08 (Fri, 08 May 2015) Changed paths: M src/tools/openpgp-tool.c Log Message: ----------- openpgp-tool: fixed resource leak VTA: slightly touched, original commit f0ddbf4 Commit: a83da8a947232c0c6f084cbbfeb7b979fe554368 https://github.com/OpenSC/OpenSC/commit/a83da8a947232c0c6f084cbbfeb7b979fe554368 Author: Frank Morgner <mo...@in...> Date: 2015-05-08 (Fri, 08 May 2015) Changed paths: M src/tools/pkcs15-crypt.c Log Message: ----------- pkcs15-crypt: fixed resource leak Commit: 1f16f24052d5567bb2de92f080378421fa9719e2 https://github.com/OpenSC/OpenSC/commit/1f16f24052d5567bb2de92f080378421fa9719e2 Author: Frank Morgner <mo...@in...> Date: 2015-05-08 (Fri, 08 May 2015) Changed paths: M src/tools/pkcs15-init.c Log Message: ----------- pkcs15-init: fixed resource leak Commit: d96f25c147d1e19efab4f3141cf8ed8dbd55678c https://github.com/OpenSC/OpenSC/commit/d96f25c147d1e19efab4f3141cf8ed8dbd55678c Author: Frank Morgner <mo...@in...> Date: 2015-05-08 (Fri, 08 May 2015) Changed paths: M src/tools/pkcs15-tool.c Log Message: ----------- pkcs15-tool: fixed resource leak Commit: bbb803ff2e75d56e8e27d6973fde389a5f08d4f7 https://github.com/OpenSC/OpenSC/commit/bbb803ff2e75d56e8e27d6973fde389a5f08d4f7 Author: Frank Morgner <mo...@in...> Date: 2015-05-08 (Fri, 08 May 2015) Changed paths: M src/tools/sc-hsm-tool.c Log Message: ----------- sc-hsm-tool: fixed resource leak Commit: 8838388ceb9818873227e399d4fca741df3659b9 https://github.com/OpenSC/OpenSC/commit/8838388ceb9818873227e399d4fca741df3659b9 Author: Frank Morgner <mo...@in...> Date: 2015-05-08 (Fri, 08 May 2015) Changed paths: M src/libopensc/pkcs15-infocamere.c Log Message: ----------- pkcs15-infocamere: fixed resource leak Commit: ecc9b9dac9fe4edc08d55a5aad9a94b990f4f370 https://github.com/OpenSC/OpenSC/commit/ecc9b9dac9fe4edc08d55a5aad9a94b990f4f370 Author: Frank Morgner <mo...@in...> Date: 2015-05-08 (Fri, 08 May 2015) Changed paths: M src/pkcs11/openssl.c Log Message: ----------- openssl: fixed resource leak Commit: 2c32575e8970a997223f201caeeef12b53fd0174 https://github.com/OpenSC/OpenSC/commit/2c32575e8970a997223f201caeeef12b53fd0174 Author: Frank Morgner <mo...@in...> Date: 2015-05-08 (Fri, 08 May 2015) Changed paths: M src/tools/pkcs11-tool.c Log Message: ----------- pkcs11-tool: fixed resource leak Commit: e84951a5bf7f65d20061b49b6ebd8d739dd76708 https://github.com/OpenSC/OpenSC/commit/e84951a5bf7f65d20061b49b6ebd8d739dd76708 Author: Frank Morgner <mo...@in...> Date: 2015-05-08 (Fri, 08 May 2015) Changed paths: M src/pkcs11/framework-pkcs15.c M src/pkcs11/mechanism.c M src/pkcs11/openssl.c M src/pkcs11/pkcs11-object.c M src/pkcs11/sc-pkcs11.h M src/pkcs11/slot.c M src/tools/pkcs11-tool.c Log Message: ----------- fix resource leaks in while registering PKCS#11 mechanisms introduces a free_mech_data for sc_pkcs11_mechanism_type_t to clear the mechanisms private memory Commit: e338b7c1ab2b6d39bf9d57c85f789279abd0a1ca https://github.com/OpenSC/OpenSC/commit/e338b7c1ab2b6d39bf9d57c85f789279abd0a1ca Author: Frank Morgner <mo...@in...> Date: 2015-05-08 (Fri, 08 May 2015) Changed paths: M src/pkcs11/framework-pkcs15.c Log Message: ----------- framework-pkcs15: fixed memory leak when encoding pubkey Commit: ef4edb74ba5dfb1830a3a21b0c895553e9d4eedc https://github.com/OpenSC/OpenSC/commit/ef4edb74ba5dfb1830a3a21b0c895553e9d4eedc Author: Frank Morgner <mo...@in...> Date: 2015-05-08 (Fri, 08 May 2015) Changed paths: M src/pkcs11/mechanism.c M src/pkcs11/openssl.c Log Message: ----------- fixed invalid free We duplicate mechanisms based on OpenSSL so that they can be freed along all the card's algorithms created via sc_pkcs11_new_fw_mechanism. Fixes regression from eaf548aa3dab80a9bbf51da8291e7db978e3a2ad Commit: fd3d07a88496dc0adfa2f6ff7eca9078ec087985 https://github.com/OpenSC/OpenSC/commit/fd3d07a88496dc0adfa2f6ff7eca9078ec087985 Author: Hector Sanjuan <he...@co...> Date: 2015-05-08 (Fri, 08 May 2015) Changed paths: M src/libopensc/card-dnie.c M src/libopensc/cwa14890.c M src/libopensc/pkcs15-dnie.c Log Message: ----------- Issue #451: Newer DNIe not working with OpenSC. This patch fixes 3 issues which consecutively have shown up when debugging the original problem: 1 - Newer DNIe report a byte count for public certificates which is the compressed size, while older DNIe report the uncompressed size. This resulted in short-reading the x509 certificates, and in an error parsing. Therefore, during initialization we proceed to set path->count for public certificates to -1. This ensures that the lenght of the certificates for reading will be set to file-> length, which has the correct size. 2 - pkcs11-tool -t was broken for DNIe (old and new)as it tried to strip pcks11 padding from the data to sign and OpenSC tried signatures with non-padded data (as the card had SC_ALGORITHM_RSA_RAW). The new algoflags (SC_ALGORITHM_RSA_HASH_NONE | SC_ALGORITHM_RSA_PAD_PKCS1) and the removal of the strip-padding call fix the issue. 3 - The new cards won't allow setting the LE bytes when calculating the TLV, when LE equals 256. This caused an wrong SM object error response (0x69 0x88). Therefore, we don't send the LE bytes anymore in this case. The patch has been tested to work on the new problematic card and on another old one. close #451 Compare: https://github.com/OpenSC/OpenSC/compare/976db5cb0400...fd3d07a88496 |
