Re: [Opensc-devel] Request for inclusion of a new driver

[Vincent Le T. <vin...@my...>]

Hi,

The pull request is #453 (https://github.com/OpenSC/OpenSC/pull/453).

Frank already commented it
(there is a reference to a potential fix #454,
https://github.com/OpenSC/OpenSC/pull/454 - but the pull request doesn't
rely on it now)

regards,
Vincent

2015-04-29 15:51 GMT+02:00 Philip Wendland <wen...@gm...>:

> On 04/29/2015 03:08 PM, Vincent Le Toux wrote:
> > How should I submit the driver ?
> > A patch file ? Directly the c file + the instructions to register it ?
> > A pull request ? (will be a mess for me because my minidriver change is
> > still pending)
>
> My way of doing this (I don't know if it was the apporach most desired
> by the OpenSC team) was to have a pull request for the card driver, and
> different pull requests for fixes that touched general code.
>
> I had a seperate *local* branch where both (all) where combined for
> testing. I did also rebase the card driver from time to time onto the
> most recent OpenSC/master, to test it with the newest version. (This can
> also be done locally only.)
>
> git reset --hard (careful!), rebase/merge and cherry-pick could be
> useful tools for your local testing branch. Or you can work on the
> testing branch, and if the next commit works, integrate it in the
> driver-pull-request-branch.
>
> Philip
>
>
> ------------------------------------------------------------------------------
> One dashboard for servers and applications across Physical-Virtual-Cloud
> Widest out-of-the-box monitoring support with 50+ applications
> Performance metrics, stats and reports that give you Actionable Insights
> Deep dive visibility with transaction tracing using APM Insight.
> http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
> _______________________________________________
> Opensc-devel mailing list
> Ope...@li...
> https://lists.sourceforge.net/lists/listinfo/opensc-devel
>



-- 
--
Vincent Le Toux

My Smart Logon
www.mysmartlogon.com