Re: [Opensc-devel] Request for inclusion of a new driver

[Douglas E E. <dee...@gm...>]

On 4/29/2015 8:08 AM, Vincent Le Toux wrote:
> No, there is no impact on other files except the one referencing the all the drivers to add a new reference to this driver.
> It is on my opinion a non breaking change (no modification on core functions, no duplication of code, ...)
>
> This change is independant of the minidriver modifications I proposed (but I tested it with this card).
>
> The card is compatible with iso 7816-15 with some small modifications in the commands sent to the card by the driver.
> There is no NDA / license issues as I got the official autorization to publish the current driver with the GPL license.
>
> How should I submit the driver ?
> A patch file ? Directly the c file + the instructions to register it ?
> A pull request ? (will be a mess for me because my minidriver change is still pending)

I will let others comment on the above.

>
> regards,
> Vincent LE TOUX
>
>
> 2015-04-29 14:51 GMT+02:00 Douglas E Engert <dee...@gm... <mailto:dee...@gm...>>:
>
>
>
>     On 4/29/2015 7:19 AM, Vincent Le Toux wrote:
>     > Hi,
>     >
>     > I'd like to request to include a new card driver in OpenSC.
>     > The card is the one produced by MaskTech gmbh.
>     >http://www.masktech.com/
>     >
>     > I've the agreement of the owner about that.
>
>     Any license or NDA issues? Are there specifications published?
>
>     >
>     >
>     > Is it possible ?
>     > If yes, can I include it in the branch I am using to test the minidriver modifications ?
>     > (https://github.com/OpenSC/OpenSC/tree/minidriver-cmck-issues-i426)
>
>     Please try and keep them independent. The minidriver supports many cards.
>
>     You are asking to support a new card. Based on problems with adding previous drivers,
>     new driver developer who are usually new to OpenSC, start making code changes to core
>     functions, or duplicating code.  Having the driver be its own branch can catch many of
>     these modifications that affect other cards.
>
>     Also the new driver may or may not be ready with the minidriver changes that sound
>     like they could be included with 0.15.0
>
>     >
>     > Thanks in advance
>     >
>     > regards
>     >
>     > --
>     > --
>     > Vincent Le Toux
>     >
>     > My Smart Logon
>      > www.mysmartlogon.com <http://www.mysmartlogon.com> <http://www.mysmartlogon.com/>
>      >
>      >
>      > ------------------------------------------------------------------------------
>      > One dashboard for servers and applications across Physical-Virtual-Cloud
>      > Widest out-of-the-box monitoring support with 50+ applications
>      > Performance metrics, stats and reports that give you Actionable Insights
>      > Deep dive visibility with transaction tracing using APM Insight.
>      > http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
>      >
>      >
>      >
>      > _______________________________________________
>      > Opensc-devel mailing list
>      > Ope...@li... <mailto:Ope...@li...>
>      > https://lists.sourceforge.net/lists/listinfo/opensc-devel
>      >
>
>     --
>
>        Douglas E. Engert  <DEE...@gm... <mailto:DEE...@gm...>>
>
>
>     ------------------------------------------------------------------------------
>     One dashboard for servers and applications across Physical-Virtual-Cloud
>     Widest out-of-the-box monitoring support with 50+ applications
>     Performance metrics, stats and reports that give you Actionable Insights
>     Deep dive visibility with transaction tracing using APM Insight.
>     http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
>     _______________________________________________
>     Opensc-devel mailing list
>     Ope...@li... <mailto:Ope...@li...>
>     https://lists.sourceforge.net/lists/listinfo/opensc-devel
>
>
>
>
> --
> --
> Vincent Le Toux
>
> My Smart Logon
> www.mysmartlogon.com <http://www.mysmartlogon.com/>
>
>
> ------------------------------------------------------------------------------
> One dashboard for servers and applications across Physical-Virtual-Cloud
> Widest out-of-the-box monitoring support with 50+ applications
> Performance metrics, stats and reports that give you Actionable Insights
> Deep dive visibility with transaction tracing using APM Insight.
> http://ad.doubleclick.net/ddm/clk/290420510;117567292;y
>
>
>
> _______________________________________________
> Opensc-devel mailing list
> Ope...@li...
> https://lists.sourceforge.net/lists/listinfo/opensc-devel
>

-- 

  Douglas E. Engert  <DEE...@gm...>