[Opensc-commits] [OpenSC/OpenSC] 981a0f: Fix-up changes caused by Coverity scan

SourceForge Headquarters 225 Broadway Suite 1600 San Diego, CA 92101 +1 (858) 422-6466

  Branch: refs/heads/coverity_scan
  Home:   https://github.com/OpenSC/OpenSC
  Commit: 981a0fbbaf36b9f2e0b725e5c19c7a42e3e32c61
      https://github.com/OpenSC/OpenSC/commit/981a0fbbaf36b9f2e0b725e5c19c7a42e3e32c61
  Author: Doug Engert <dee...@gm...>
  Date:   2015-02-11 (Wed, 11 Feb 2015)

  Changed paths:
    M src/libopensc/card-piv.c
    M src/tools/piv-tool.c

  Log Message:
  -----------
  Fix-up changes caused by Coverity scan

piv-tool.c add  /* fall through */ to avoif false warning
card-piv.c - clean up if sc_lock fails.

  Commit: 0ffad3f3bb9c893ab5a06998c7c7f0d571e7918d
      https://github.com/OpenSC/OpenSC/commit/0ffad3f3bb9c893ab5a06998c7c7f0d571e7918d
  Author: Robert Quattlebaum <da...@de...>
  Date:   2015-02-12 (Thu, 12 Feb 2015)

  Changed paths:
    M src/libopensc/pkcs15-piv.c

  Log Message:
  -----------
  Fix for bad caching behavior of PIV PKCS15 emulator.

  Commit: 14ed749a88432f1b061302dd75a55e27b5d2be79
      https://github.com/OpenSC/OpenSC/commit/14ed749a88432f1b061302dd75a55e27b5d2be79
  Author: Martin Paljak <mar...@gm...>
  Date:   2015-02-13 (Fri, 13 Feb 2015)

  Changed paths:
    A CONTRIBUTING.md

  Log Message:
  -----------
  Create CONTRIBUTING.md

So that new issues and pull requests could get some information.

  Commit: 572218c59c8323c76a243763604801fb3587bf63
      https://github.com/OpenSC/OpenSC/commit/572218c59c8323c76a243763604801fb3587bf63
  Author: Doug Engert <dee...@gm...>
  Date:   2015-02-16 (Mon, 16 Feb 2015)

  Changed paths:
    M src/tools/piv-tool.c

  Log Message:
  -----------
  Fall through comment before break

  Commit: e37690aed56d36dcdfd43762ee910465b9f44e87
      https://github.com/OpenSC/OpenSC/commit/e37690aed56d36dcdfd43762ee910465b9f44e87
  Author: Doug Engert <dee...@gm...>
  Date:   2015-02-16 (Mon, 16 Feb 2015)

  Changed paths:
    M src/libopensc/card-piv.c
    M src/tools/piv-tool.c

  Log Message:
  -----------
  Merge pull request #376 from dengert/piv-reverts

Fix-up changes caused by Coverity scan See #366 in PIV code

  Commit: d7475c8180c7fe96a85f13184c05bbe0fec20c3c
      https://github.com/OpenSC/OpenSC/commit/d7475c8180c7fe96a85f13184c05bbe0fec20c3c
  Author: Doug Engert <dee...@gm...>
  Date:   2015-02-16 (Mon, 16 Feb 2015)

  Changed paths:
    M src/libopensc/card-piv.c

  Log Message:
  -----------
  Add brackets   in card-piv.c

  Commit: 45a4def5fdb0f0ea05bd36661f5ecc617b16af8c
      https://github.com/OpenSC/OpenSC/commit/45a4def5fdb0f0ea05bd36661f5ecc617b16af8c
  Author: Doug Engert <dee...@gm...>
  Date:   2015-02-16 (Mon, 16 Feb 2015)

  Changed paths:
    M src/libopensc/card-piv.c

  Log Message:
  -----------
  Merge pull request #382 from dengert/piv-fix1

Add brackets   in card-piv.c

  Commit: fa923831f8e8073f0b57ea492c9e2e93f661a373
      https://github.com/OpenSC/OpenSC/commit/fa923831f8e8073f0b57ea492c9e2e93f661a373
  Author: Viktor Tarasov <vik...@gm...>
  Date:   2015-02-20 (Fri, 20 Feb 2015)

  Changed paths:
    M src/libopensc/asn1.c
    M src/libopensc/card-myeid.c
    M src/libopensc/card-piv.c
    M src/libopensc/card-sc-hsm.c
    M src/libopensc/card.c
    M src/libopensc/internal.h
    M src/libopensc/opensc.h
    M src/libopensc/pkcs15-algo.c
    M src/libopensc/pkcs15-pubkey.c
    M src/libopensc/pkcs15-sc-hsm.c
    M src/libopensc/pkcs15-sec.c
    M src/libopensc/pkcs15.h
    M src/pkcs11/framework-pkcs15.c
    M src/pkcs15init/pkcs15-lib.c
    M src/pkcs15init/pkcs15-sc-hsm.c

  Log Message:
  -----------
  introduce EC curve OID into algorithm info data

needed to store information about EC curve supported by card.
Primary usage is when importing/generating key to get know if particular curve is supported by card.

  Commit: 80c496671f5bb513a1298b462040ed12d549fb2b
      https://github.com/OpenSC/OpenSC/commit/80c496671f5bb513a1298b462040ed12d549fb2b
  Author: Viktor Tarasov <vik...@gm...>
  Date:   2015-02-20 (Fri, 20 Feb 2015)

  Changed paths:
    M src/libopensc/asn1.c
    M src/libopensc/asn1.h
    M src/libopensc/libopensc.exports

  Log Message:
  -----------
  helper functions to change format of ECDSA signature

  Commit: b08671fab5b500ed18e7fe189d8e6aadbaf22f4b
      https://github.com/OpenSC/OpenSC/commit/b08671fab5b500ed18e7fe189d8e6aadbaf22f4b
  Author: Viktor Tarasov <vik...@gm...>
  Date:   2015-02-20 (Fri, 20 Feb 2015)

  Changed paths:
    M src/tools/pkcs15-crypt.c

  Log Message:
  -----------
  pkcs15-crypt: option for output format of ECDSA signature

  Commit: ced77ae6c7360914e746178b369561ad7fac84dc
      https://github.com/OpenSC/OpenSC/commit/ced77ae6c7360914e746178b369561ad7fac84dc
  Author: Pedro Martelletto <pe...@am...>
  Date:   2015-02-20 (Fri, 20 Feb 2015)

  Changed paths:
    M src/pkcs15init/pkcs15-cardos.c

  Log Message:
  -----------
  cardos: overwrite content of deleted private key

when deleting a private key object, overwrite its contents so the key can no longer be used.

(VTA: original commit touched to use LOG macros and add debug logs)

  Commit: da07e22c97effe27d8decf4037f314e4015da1eb
      https://github.com/OpenSC/OpenSC/commit/da07e22c97effe27d8decf4037f314e4015da1eb
  Author: Frank Morgner <mo...@in...>
  Date:   2015-02-20 (Fri, 20 Feb 2015)

  Changed paths:
    M src/libopensc/card-authentic.c

  Log Message:
  -----------
  use memmove for overlapping memory

  Commit: 236e68b17c85be8b7507615a99663f5f6da3438c
      https://github.com/OpenSC/OpenSC/commit/236e68b17c85be8b7507615a99663f5f6da3438c
  Author: Frank Morgner <mo...@in...>
  Date:   2015-02-20 (Fri, 20 Feb 2015)

  Changed paths:
    M src/libopensc/asn1.c

  Log Message:
  -----------
  fixed NULL dereference

  Commit: 16ea926d2980ab9b92d94bd649cdb9a4ce6d769a
      https://github.com/OpenSC/OpenSC/commit/16ea926d2980ab9b92d94bd649cdb9a4ce6d769a
  Author: Frank Morgner <mo...@in...>
  Date:   2015-02-20 (Fri, 20 Feb 2015)

  Changed paths:
    M src/pkcs11/pkcs11-object.c

  Log Message:
  -----------
  fixed indentation

  Commit: bff0ea483711a044f514ccee0e4ab5552dbea2bb
      https://github.com/OpenSC/OpenSC/commit/bff0ea483711a044f514ccee0e4ab5552dbea2bb
  Author: Frank Morgner <mo...@in...>
  Date:   2015-02-20 (Fri, 20 Feb 2015)

  Changed paths:
    M src/tools/pkcs11-tool.c

  Log Message:
  -----------
  fixed compiler warning

  Commit: 9f3dbaa39dbb2c6c4515bb2ea0ec78023d10bdb4
      https://github.com/OpenSC/OpenSC/commit/9f3dbaa39dbb2c6c4515bb2ea0ec78023d10bdb4
  Author: Frank Morgner <mo...@in...>
  Date:   2015-02-20 (Fri, 20 Feb 2015)

  Changed paths:
    M .travis.yml

  Log Message:
  -----------
  honour warnings

  Commit: 58d1f1db3f0c8a8880d05301b803fb5524eabdc8
      https://github.com/OpenSC/OpenSC/commit/58d1f1db3f0c8a8880d05301b803fb5524eabdc8
  Author: Doug Engert <dee...@gm...>
  Date:   2015-02-21 (Sat, 21 Feb 2015)

  Changed paths:
    M src/libopensc/pkcs15-piv.c

  Log Message:
  -----------
  Merge pull request #385 from darconeous/patch-2

Allow PKCS15 cache to work with PIV cards (if enabled)

  Commit: 8cf99a93726e735e04ed2563f14e315a60a4a859
      https://github.com/OpenSC/OpenSC/commit/8cf99a93726e735e04ed2563f14e315a60a4a859
  Author: Viktor Tarasov <vik...@gm...>
  Date:   2015-03-04 (Wed, 04 Mar 2015)

  Changed paths:
    M src/libopensc/asn1.c

  Log Message:
  -----------
  asn1: fix error in EC signature encode helper

The raw format of EC signature was invalid when 'r' and 's' had different length.
https://github.com/OpenSC/OpenSC/pull/381#issuecomment-77016382

According to PKCS#11 v2.20:
"If r and s have different octet length, the shorter of both must
be padded with leading zero octets such that both have the same octet length."

  Commit: 1123768ac3b722afe3a0d662967515c547530554
      https://github.com/OpenSC/OpenSC/commit/1123768ac3b722afe3a0d662967515c547530554
  Author: Viktor Tarasov <vik...@gm...>
  Date:   2015-03-04 (Wed, 04 Mar 2015)

  Changed paths:
    M src/libopensc/card.c

  Log Message:
  -----------
  libopensc: invalid 'free' and 'assign NULL' order

  Commit: 31124ac4f906ba8a331bde47d23bc89757f1829f
      https://github.com/OpenSC/OpenSC/commit/31124ac4f906ba8a331bde47d23bc89757f1829f
  Author: Viktor Tarasov <vik...@gm...>
  Date:   2015-03-04 (Wed, 04 Mar 2015)

  Changed paths:
    M src/libopensc/card.c
    M src/libopensc/opensc.h
    M src/pkcs15init/pkcs15-lib.c

  Log Message:
  -----------
  pkcs15init: allocate EC parameters

  Commit: 6f6286de99a62ab0d2edf6023f39cfa8db139420
      https://github.com/OpenSC/OpenSC/commit/6f6286de99a62ab0d2edf6023f39cfa8db139420
  Author: Viktor Tarasov <vik...@gm...>
  Date:   2015-03-04 (Wed, 04 Mar 2015)

  Changed paths:
    M src/pkcs11/framework-pkcs15.c
    M src/pkcs11/misc.c
    M src/pkcs11/sc-pkcs11.h

  Log Message:
  -----------
  pkcs11: generate EC key: use allocated EC params

For internal use allocate and copy the EC params data from the caller's template,
rather then use them directly as a pointer in internal public key data.

  Commit: 1739300657dfa6148f82c39b5a062bc679357649
      https://github.com/OpenSC/OpenSC/commit/1739300657dfa6148f82c39b5a062bc679357649
  Author: Viktor Tarasov <vik...@gm...>
  Date:   2015-03-05 (Thu, 05 Mar 2015)

  Changed paths:
    M src/libopensc/pkcs15-pubkey.c

  Log Message:
  -----------
  pkcs15: fix name of EC curve, add new ones

Compare: https://github.com/OpenSC/OpenSC/compare/3c1d8ad69557...1739300657df

[Opensc-commits] [OpenSC/OpenSC] 981a0f: Fix-up changes caused by Coverity scan

OpenSC - tools and libraries for smart cards

[Opensc-commits] [OpenSC/OpenSC] 981a0f: Fix-up changes caused by Coverity scan