[Opensc-commits] [OpenSC/OpenSC] 08eb70: revert or partially revert some of recent commits

[GitHub <no...@gi...>]

  Branch: refs/heads/coverity_scan
  Home:   https://github.com/OpenSC/OpenSC
  Commit: 08eb700b9749c17e8ff29ddb45b3132d8d38308e
      https://github.com/OpenSC/OpenSC/commit/08eb700b9749c17e8ff29ddb45b3132d8d38308e
  Author: Viktor Tarasov <vik...@gm...>
  Date:   2015-02-07 (Sat, 07 Feb 2015)

  Changed paths:
    M src/libopensc/card-asepcos.c
    M src/libopensc/card-iasecc.c
    M src/libopensc/pkcs15.c
    M src/pkcs11/slot.c
    M src/pkcs15init/pkcs15-lib.c
    M src/pkcs15init/pkcs15-myeid.c
    M src/tools/piv-tool.c

  Log Message:
  -----------
  revert or partially revert some of recent commits

b94c163 - invalid, non-tested
11881a6 -- src/libopensc/card-iasecc.c -- return from select has to be ignored,
3a92bf7 -- src/pkcs11/slot.c -- SEGFAULT issue #373
3a92bf7 -- src/tools/piv-tool.c -- confirmed by author
6759c04 -- src/pkcs15init/pkcs15-lib.c -- file instantiation error has to be ignored


  Commit: faaa11e091001f063dac46f29f0aad28c2494a18
      https://github.com/OpenSC/OpenSC/commit/faaa11e091001f063dac46f29f0aad28c2494a18
  Author: Philip Wendland <wen...@gm...>
  Date:   2015-02-07 (Sat, 07 Feb 2015)

  Changed paths:
    M src/libopensc/pkcs15.c

  Log Message:
  -----------
  Prefer serial number from EF(TokenInfo) and cached serials over CARDCTL

sc_pkcs15_get_object_guid() should prefer the serial number from
EF(TokenInfo) over card->serialnr because the user may override the
card's serial number with "pkcs15-init -C --serial". The card->serialnr
should be used before calling card CTL with SC_CARDCTL_GET_SERIALNR
because it might contain a cached value.

This change *should* allow cards to be used with the minidriver even if
SC_CARDCTL_GET_SERIALNR is not implemented. For example, a driver might
set card->serialnr at initialization or the user might initialize a
PKCS#15 card with its own "--serial".

See also the discussion at the mailing list:
[Opensc-devel] AT_SIGNATURE and AT_EXCHANGE Problem


  Commit: 9148f21cd1079c53796b420f16e42b3b365d41aa
      https://github.com/OpenSC/OpenSC/commit/9148f21cd1079c53796b420f16e42b3b365d41aa
  Author: Viktor Tarasov <vik...@gm...>
  Date:   2015-02-07 (Sat, 07 Feb 2015)

  Changed paths:
    M src/libopensc/pkcs15-pubkey.c

  Log Message:
  -----------
  pkcs15-pubkey: possible NULL dereference, logs

... remove obsolete comments, minor coding style corrections


  Commit: e374f88b82b047a55ce557f3e90a80b76eb0108e
      https://github.com/OpenSC/OpenSC/commit/e374f88b82b047a55ce557f3e90a80b76eb0108e
  Author: Viktor Tarasov <vik...@gm...>
  Date:   2015-02-07 (Sat, 07 Feb 2015)

  Changed paths:
    M src/libopensc/pkcs15-algo.c
    M src/libopensc/pkcs15-pubkey.c

  Log Message:
  -----------
  pkcs15-pubkey: add EC params in SPKI encoding


  Commit: 96265e6d08a0be51d7d83468d9e42bd54a7b409a
      https://github.com/OpenSC/OpenSC/commit/96265e6d08a0be51d7d83468d9e42bd54a7b409a
  Author: Viktor Tarasov <vik...@gm...>
  Date:   2015-02-07 (Sat, 07 Feb 2015)

  Changed paths:
    M src/pkcs11/framework-pkcs15.c
    M src/pkcs15init/pkcs15-init.h
    M src/pkcs15init/pkcs15-lib.c
    M src/tools/pkcs15-init.c

  Log Message:
  -----------
  pkcs15init: superpluous 'ec-params' in init data

Pkcs15init data, used to import/generate key objects, includes twice the same EC parameters data:
 - explicit 'params' data
 - part of sc_pkcs15_pubkey/sc_pkcs15_prkey
Explicit 'ec-params' data is removed.


  Commit: 22fb49b5545a09bf7b4be071ef189388e6a582b1
      https://github.com/OpenSC/OpenSC/commit/22fb49b5545a09bf7b4be071ef189388e6a582b1
  Author: Thomas Calderon <tho...@ss...>
  Date:   2015-02-07 (Sat, 07 Feb 2015)

  Changed paths:
    M src/pkcs11/framework-pkcs15.c

  Log Message:
  -----------
  PKCS#11: Improve compliance for public keys.

  * Key usage required when calling C_CreateObject for public key are not used.
    This adds the logic to convert from PKCS#11 attributes to PKCS#15 in the
    structure that is sent to underlying _store_pubkey functions.


  Commit: d1621439648f29b0b1a5306bdf108007e695380b
      https://github.com/OpenSC/OpenSC/commit/d1621439648f29b0b1a5306bdf108007e695380b
  Author: Martin Campbell <ma...@ca...>
  Date:   2015-02-07 (Sat, 07 Feb 2015)

  Changed paths:
    M src/libopensc/card-epass2003.c
    M src/libopensc/card.c

  Log Message:
  -----------
  Updating to fix failure of ePass2003 USB smart card due to failure to re-authenticate secure messaging when card is reset due to multiple applications using PKCS11 sessions


  Commit: 3c1d8ad69557adf6aab08bc549188425c8b33a92
      https://github.com/OpenSC/OpenSC/commit/3c1d8ad69557adf6aab08bc549188425c8b33a92
  Author: Viktor Tarasov <vik...@gm...>
  Date:   2015-02-07 (Sat, 07 Feb 2015)

  Changed paths:
    M src/libopensc/iso7816.c

  Log Message:
  -----------
  accept no output for 'SELECT' MF and 'SELECT' DF_NAME

PR #342


Compare: https://github.com/OpenSC/OpenSC/compare/3a92bf7af5aa...3c1d8ad69557