[Opensc-commits] [OpenSC/OpenSC] 7a34c2: fixed dereference before null check

[GitHub <no...@gi...>]

  Branch: refs/heads/master
  Home:   https://github.com/OpenSC/OpenSC
  Commit: 7a34c204c1904b789a1842003071b4da3d7c0932
      https://github.com/OpenSC/OpenSC/commit/7a34c204c1904b789a1842003071b4da3d7c0932
  Author: Frank Morgner <mo...@in...>
  Date:   2015-01-22 (Thu, 22 Jan 2015)

  Changed paths:
    M src/common/compat_getopt_main.c
    M src/libopensc/card-authentic.c
    M src/libopensc/card-iasecc.c
    M src/libopensc/card-oberthur.c
    M src/libopensc/card-westcos.c
    M src/libopensc/card.c
    M src/libopensc/cwa14890.c
    M src/libopensc/sc.c
    M src/pkcs11/framework-pkcs15.c
    M src/pkcs11/pkcs11-global.c
    M src/pkcs15init/pkcs15-entersafe.c
    M src/pkcs15init/pkcs15-epass2003.c
    M src/pkcs15init/pkcs15-gpk.c
    M src/pkcs15init/pkcs15-jcop.c
    M src/pkcs15init/pkcs15-lib.c
    M src/pkcs15init/pkcs15-myeid.c
    M src/pkcs15init/pkcs15-oberthur-awp.c
    M src/pkcs15init/pkcs15-oberthur.c
    M src/pkcs15init/pkcs15-setcos.c
    M src/pkcs15init/profile.c
    M src/scconf/parse.c
    M src/scconf/sclex.c
    M src/tests/base64.c
    M src/tools/dnie-tool.c
    M src/tools/piv-tool.c
    M src/tools/pkcs15-init.c
    M src/tools/pkcs15-tool.c
    M src/tools/westcos-tool.c

  Log Message:
  -----------
  fixed dereference before null check

silence warnings reported by coverity-scan


  Commit: 1b53b59ed393057cc7840b916d4081ef64a1da74
      https://github.com/OpenSC/OpenSC/commit/1b53b59ed393057cc7840b916d4081ef64a1da74
  Author: Frank Morgner <mo...@in...>
  Date:   2015-01-24 (Sat, 24 Jan 2015)

  Changed paths:
    M src/tools/sc-hsm-tool.c

  Log Message:
  -----------
  fixed potential use after free

reported by coverity scan


  Commit: 8df9896204f4d776bd312f725436f2f791abd377
      https://github.com/OpenSC/OpenSC/commit/8df9896204f4d776bd312f725436f2f791abd377
  Author: Frank Morgner <mo...@in...>
  Date:   2015-01-24 (Sat, 24 Jan 2015)

  Changed paths:
    M src/tools/pkcs15-init.c

  Log Message:
  -----------
  pass big parameter by reference

reported by coverity scan


  Commit: fca3a37097a7653dfc318ca8e99450cbd2747eea
      https://github.com/OpenSC/OpenSC/commit/fca3a37097a7653dfc318ca8e99450cbd2747eea
  Author: Frank Morgner <mo...@in...>
  Date:   2015-01-24 (Sat, 24 Jan 2015)

  Changed paths:
    M src/tools/sc-hsm-tool.c
    M src/tools/util.c

  Log Message:
  -----------
  fixed truncated stdio return value


  Commit: 9a4b58800b8c1fc89f598d52b28994be2fbf8bd7
      https://github.com/OpenSC/OpenSC/commit/9a4b58800b8c1fc89f598d52b28994be2fbf8bd7
  Author: Frank Morgner <mo...@in...>
  Date:   2015-01-24 (Sat, 24 Jan 2015)

  Changed paths:
    M src/tools/cardos-tool.c

  Log Message:
  -----------
  fixed Printf arg type mismatch


  Commit: 3f64d3a805b93f1c436c321c3fb832757d4c07b4
      https://github.com/OpenSC/OpenSC/commit/3f64d3a805b93f1c436c321c3fb832757d4c07b4
  Author: Frank Morgner <mo...@in...>
  Date:   2015-01-24 (Sat, 24 Jan 2015)

  Changed paths:
    M src/tools/pkcs11-tool.c

  Log Message:
  -----------
  fixed bad memory allocation


  Commit: 6641cbf45559050ebcc059ed3df33e26ea185c15
      https://github.com/OpenSC/OpenSC/commit/6641cbf45559050ebcc059ed3df33e26ea185c15
  Author: Frank Morgner <mo...@in...>
  Date:   2015-01-24 (Sat, 24 Jan 2015)

  Changed paths:
    M src/libopensc/pkcs15-tcos.c
    M src/tools/cryptoflex-tool.c
    M src/tools/pkcs11-tool.c

  Log Message:
  -----------
  fixed potential string overflow


  Commit: 00330b2c7937bbceae3e3ebfae112c626c7ae231
      https://github.com/OpenSC/OpenSC/commit/00330b2c7937bbceae3e3ebfae112c626c7ae231
  Author: Frank Morgner <mo...@in...>
  Date:   2015-01-24 (Sat, 24 Jan 2015)

  Changed paths:
    M src/libopensc/card.c

  Log Message:
  -----------
  fixed resource leak


  Commit: b6a935a261d87fa77f1682763ff7c7f55189f246
      https://github.com/OpenSC/OpenSC/commit/b6a935a261d87fa77f1682763ff7c7f55189f246
  Author: Frank Morgner <mo...@in...>
  Date:   2015-01-24 (Sat, 24 Jan 2015)

  Changed paths:
    M src/libopensc/apdu.c

  Log Message:
  -----------
  fixed memory leak


  Commit: fdd38f6e0437077086a793dadc912f07c75d8774
      https://github.com/OpenSC/OpenSC/commit/fdd38f6e0437077086a793dadc912f07c75d8774
  Author: Frank Morgner <mo...@in...>
  Date:   2015-01-28 (Wed, 28 Jan 2015)

  Changed paths:
    M src/libopensc/pkcs15-tcos.c
    M src/pkcs15init/pkcs15-lib.c

  Log Message:
  -----------
  fixed copy into fixed size buffer


  Commit: 77752f442d90665b814f5a7fbbe5d3f28000860b
      https://github.com/OpenSC/OpenSC/commit/77752f442d90665b814f5a7fbbe5d3f28000860b
  Author: Frank Morgner <mo...@in...>
  Date:   2015-01-28 (Wed, 28 Jan 2015)

  Changed paths:
    M src/libopensc/card-dnie.c
    M src/libopensc/pkcs15-itacns.c
    M src/pkcs11/framework-pkcs15.c
    M src/pkcs11/pkcs11-object.c
    M src/pkcs15init/pkcs15-lib.c
    M src/pkcs15init/pkcs15-sc-hsm.c
    M src/pkcs15init/pkcs15-westcos.c
    M src/tools/pkcs15-tool.c

  Log Message:
  -----------
  fixed unused value


  Commit: 7c497b324f8a79cec3dc374373efe6e2040bab2b
      https://github.com/OpenSC/OpenSC/commit/7c497b324f8a79cec3dc374373efe6e2040bab2b
  Author: Frank Morgner <mo...@in...>
  Date:   2015-01-28 (Wed, 28 Jan 2015)

  Changed paths:
    M src/libopensc/card.c
    M src/libopensc/iasecc-sm.c

  Log Message:
  -----------
  fixed not null terminated buffer


  Commit: 027e4a08679c1bacb139e990ec33b8a61f3d416a
      https://github.com/OpenSC/OpenSC/commit/027e4a08679c1bacb139e990ec33b8a61f3d416a
  Author: Frank Morgner <mo...@in...>
  Date:   2015-01-28 (Wed, 28 Jan 2015)

  Changed paths:
    M src/libopensc/ctx.c
    M src/libopensc/reader-pcsc.c

  Log Message:
  -----------
  fixed out of bounds read


  Commit: b1b99ce7e5973569e743c3ce285b2730d759ed72
      https://github.com/OpenSC/OpenSC/commit/b1b99ce7e5973569e743c3ce285b2730d759ed72
  Author: Frank Morgner <mo...@in...>
  Date:   2015-01-28 (Wed, 28 Jan 2015)

  Changed paths:
    M src/pkcs15init/pkcs15-myeid.c

  Log Message:
  -----------
  fixed integer underflow


  Commit: 68d86644fd642f71e0295a81aa356e7fde319abd
      https://github.com/OpenSC/OpenSC/commit/68d86644fd642f71e0295a81aa356e7fde319abd
  Author: Frank Morgner <mo...@in...>
  Date:   2015-01-28 (Wed, 28 Jan 2015)

  Changed paths:
    M src/libopensc/cwa-dnie.c

  Log Message:
  -----------
  fixed use after free


  Commit: 87b2403673ca84870698b5d8ccf0efe831506c14
      https://github.com/OpenSC/OpenSC/commit/87b2403673ca84870698b5d8ccf0efe831506c14
  Author: Frank Morgner <mo...@in...>
  Date:   2015-01-28 (Wed, 28 Jan 2015)

  Changed paths:
    M src/libopensc/card-epass2003.c
    M src/libopensc/card-myeid.c
    M src/libopensc/card-setcos.c
    M src/libopensc/ctbcs.c
    M src/pkcs15init/pkcs15-asepcos.c
    M src/pkcs15init/pkcs15-openpgp.c
    M src/tools/cryptoflex-tool.c

  Log Message:
  -----------
  fixed out of bounds access/write


  Commit: 08fcfcc8f0b4b3c7a987b25d22430acbe8868975
      https://github.com/OpenSC/OpenSC/commit/08fcfcc8f0b4b3c7a987b25d22430acbe8868975
  Author: Frank Morgner <mo...@in...>
  Date:   2015-01-28 (Wed, 28 Jan 2015)

  Changed paths:
    M src/tools/sc-hsm-tool.c

  Log Message:
  -----------
  fixed wrong sizeof argument


  Commit: b9f1fb333ccc2a3fbdc3d351c4253310e32720dc
      https://github.com/OpenSC/OpenSC/commit/b9f1fb333ccc2a3fbdc3d351c4253310e32720dc
  Author: Frank Morgner <mo...@in...>
  Date:   2015-01-28 (Wed, 28 Jan 2015)

  Changed paths:
    M src/libopensc/muscle.c

  Log Message:
  -----------
  fixed bad output data length


  Commit: ac0424e947098a65a011368f1e13242aa0416e6b
      https://github.com/OpenSC/OpenSC/commit/ac0424e947098a65a011368f1e13242aa0416e6b
  Author: Frank Morgner <mo...@in...>
  Date:   2015-01-28 (Wed, 28 Jan 2015)

  Changed paths:
    M src/pkcs11/pkcs11-spy.c

  Log Message:
  -----------
  fixed pkcs11spy's version number


  Commit: 7fb495ac314b97e4196732a5b0bc6b789afdc2c7
      https://github.com/OpenSC/OpenSC/commit/7fb495ac314b97e4196732a5b0bc6b789afdc2c7
  Author: Frank Morgner <mo...@in...>
  Date:   2015-01-28 (Wed, 28 Jan 2015)

  Changed paths:
    M src/pkcs15init/profile.c

  Log Message:
  -----------
  fixed self assignment


  Commit: 92ad6eb63c5d32ac12331f2f8d13780f1b8a75e5
      https://github.com/OpenSC/OpenSC/commit/92ad6eb63c5d32ac12331f2f8d13780f1b8a75e5
  Author: Frank Morgner <mo...@in...>
  Date:   2015-01-28 (Wed, 28 Jan 2015)

  Changed paths:
    M src/libopensc/card-dnie.c

  Log Message:
  -----------
  fixed determining ef type


  Commit: 3a557ad0dddcd89e569ef69c048ceae8955974a7
      https://github.com/OpenSC/OpenSC/commit/3a557ad0dddcd89e569ef69c048ceae8955974a7
  Author: Frank Morgner <mo...@in...>
  Date:   2015-01-28 (Wed, 28 Jan 2015)

  Changed paths:
    M src/libopensc/reader-pcsc.c

  Log Message:
  -----------
  fixed parsing pace output data


  Commit: 734cb67924be16d0d03a8dadd92043e1f4396fd4
      https://github.com/OpenSC/OpenSC/commit/734cb67924be16d0d03a8dadd92043e1f4396fd4
  Author: Frank Morgner <mo...@in...>
  Date:   2015-01-28 (Wed, 28 Jan 2015)

  Changed paths:
    M src/libopensc/card-gemsafeV1.c

  Log Message:
  -----------
  fixed algo ref


  Commit: b94c16394f89b78f9d43ecd7a8fb25f3e25b842e
      https://github.com/OpenSC/OpenSC/commit/b94c16394f89b78f9d43ecd7a8fb25f3e25b842e
  Author: Frank Morgner <mo...@in...>
  Date:   2015-01-28 (Wed, 28 Jan 2015)

  Changed paths:
    M src/libopensc/card-asepcos.c

  Log Message:
  -----------
  card-asepcos: fixed puk handling


  Commit: bd3cfcf5ef9770535369f679351d256a8c1e8a6d
      https://github.com/OpenSC/OpenSC/commit/bd3cfcf5ef9770535369f679351d256a8c1e8a6d
  Author: Frank Morgner <mo...@in...>
  Date:   2015-01-28 (Wed, 28 Jan 2015)

  Changed paths:
    M src/libopensc/iso7816.c

  Log Message:
  -----------
  fixed copy/paste error


  Commit: 2e04fa99c11c47b2c5c7f5b4bd5474bc310e51ad
      https://github.com/OpenSC/OpenSC/commit/2e04fa99c11c47b2c5c7f5b4bd5474bc310e51ad
  Author: Frank Morgner <mo...@in...>
  Date:   2015-01-28 (Wed, 28 Jan 2015)

  Changed paths:
    M src/libopensc/card-openpgp.c
    M src/libopensc/card-piv.c
    M src/libopensc/card-tcos.c
    M src/pkcs15init/pkcs15-oberthur-awp.c
    M src/tools/pkcs11-tool.c
    M src/tools/pkcs15-init.c
    M src/tools/pkcs15-tool.c

  Log Message:
  -----------
  fixed pointless array comparisons


  Commit: 6759c04b26127b62fbe01f368daa764e94ffe08d
      https://github.com/OpenSC/OpenSC/commit/6759c04b26127b62fbe01f368daa764e94ffe08d
  Author: Frank Morgner <mo...@in...>
  Date:   2015-01-28 (Wed, 28 Jan 2015)

  Changed paths:
    M src/libopensc/card-iasecc.c
    M src/libopensc/card-mcrd.c
    M src/libopensc/card-muscle.c
    M src/libopensc/card-oberthur.c
    M src/libopensc/card-piv.c
    M src/libopensc/pkcs15-cache.c
    M src/libopensc/pkcs15-dnie.c
    M src/libopensc/pkcs15-sc-hsm.c
    M src/libopensc/pkcs15-syn.c
    M src/libopensc/pkcs15.c
    M src/libopensc/reader-pcsc.c
    M src/pkcs11/framework-pkcs15.c
    M src/pkcs15init/pkcs15-lib.c
    M src/tests/lottery.c
    M src/tests/p15dump.c
    M src/tests/pintest.c
    M src/tools/openpgp-tool.c
    M src/tools/piv-tool.c
    M src/tools/pkcs11-tool.c

  Log Message:
  -----------
  don't ignore errors


  Commit: 2f3eaa1dbec3bd28177284e265847662b14910a2
      https://github.com/OpenSC/OpenSC/commit/2f3eaa1dbec3bd28177284e265847662b14910a2
  Author: Frank Morgner <mo...@in...>
  Date:   2015-02-02 (Mon, 02 Feb 2015)

  Changed paths:
    M src/common/compat_getopt_main.c
    M src/libopensc/apdu.c
    M src/libopensc/card-asepcos.c
    M src/libopensc/card-authentic.c
    M src/libopensc/card-dnie.c
    M src/libopensc/card-epass2003.c
    M src/libopensc/card-gemsafeV1.c
    M src/libopensc/card-iasecc.c
    M src/libopensc/card-mcrd.c
    M src/libopensc/card-muscle.c
    M src/libopensc/card-myeid.c
    M src/libopensc/card-oberthur.c
    M src/libopensc/card-openpgp.c
    M src/libopensc/card-piv.c
    M src/libopensc/card-setcos.c
    M src/libopensc/card-tcos.c
    M src/libopensc/card-westcos.c
    M src/libopensc/card.c
    M src/libopensc/ctbcs.c
    M src/libopensc/ctx.c
    M src/libopensc/cwa-dnie.c
    M src/libopensc/cwa14890.c
    M src/libopensc/iasecc-sm.c
    M src/libopensc/iso7816.c
    M src/libopensc/muscle.c
    M src/libopensc/pkcs15-cache.c
    M src/libopensc/pkcs15-dnie.c
    M src/libopensc/pkcs15-itacns.c
    M src/libopensc/pkcs15-sc-hsm.c
    M src/libopensc/pkcs15-syn.c
    M src/libopensc/pkcs15-tcos.c
    M src/libopensc/pkcs15.c
    M src/libopensc/reader-pcsc.c
    M src/libopensc/sc.c
    M src/pkcs11/framework-pkcs15.c
    M src/pkcs11/pkcs11-global.c
    M src/pkcs11/pkcs11-object.c
    M src/pkcs11/pkcs11-spy.c
    M src/pkcs15init/pkcs15-asepcos.c
    M src/pkcs15init/pkcs15-entersafe.c
    M src/pkcs15init/pkcs15-epass2003.c
    M src/pkcs15init/pkcs15-gpk.c
    M src/pkcs15init/pkcs15-jcop.c
    M src/pkcs15init/pkcs15-lib.c
    M src/pkcs15init/pkcs15-myeid.c
    M src/pkcs15init/pkcs15-oberthur-awp.c
    M src/pkcs15init/pkcs15-oberthur.c
    M src/pkcs15init/pkcs15-openpgp.c
    M src/pkcs15init/pkcs15-sc-hsm.c
    M src/pkcs15init/pkcs15-setcos.c
    M src/pkcs15init/pkcs15-westcos.c
    M src/pkcs15init/profile.c
    M src/scconf/parse.c
    M src/scconf/sclex.c
    M src/tests/base64.c
    M src/tests/lottery.c
    M src/tests/p15dump.c
    M src/tests/pintest.c
    M src/tools/cardos-tool.c
    M src/tools/cryptoflex-tool.c
    M src/tools/dnie-tool.c
    M src/tools/openpgp-tool.c
    M src/tools/piv-tool.c
    M src/tools/pkcs11-tool.c
    M src/tools/pkcs15-init.c
    M src/tools/pkcs15-tool.c
    M src/tools/sc-hsm-tool.c
    M src/tools/util.c
    M src/tools/westcos-tool.c

  Log Message:
  -----------
  Merge pull request #366 from frankmorgner/coverity

Fixes for Problems reported by Coverity Scan


Compare: https://github.com/OpenSC/OpenSC/compare/3047fe2c3b36...2f3eaa1dbec3