Re: [Opensc-commits] [OpenSC/OpenSC] 3d3592: pkcs15-tool: remove unused 'pubkey_pem_encode()'

[Douglas E. E. <dee...@an...>]

I am not sure what you did here. It looks like you created the sc_pkcs15_encode_pubkey_as_spki
over in pkcs15-tool.

The intend of the original code was to call the version of sc_pkcs15_encode_pubkey_as_spki
in libopensc. So there would be only one version of the code.

There was an export for sc_pkcs15_encode_pubkey_as_spki added for libopensc to allow this.

On 1/13/2014 6:08 AM, GitHub wrote:
>    Branch: refs/heads/master
>    Home:   https://github.com/OpenSC/OpenSC
>    Commit: 3d3592ab288bb5ba23f565ba0f02db180fe84de5
>        https://github.com/OpenSC/OpenSC/commit/3d3592ab288bb5ba23f565ba0f02db180fe84de5
>    Author: Viktor Tarasov <vik...@gm...>
>    Date:   2014-01-13 (Mon, 13 Jan 2014)
>
>    Changed paths:
>      M src/tools/pkcs15-tool.c
>
>    Log Message:
>    -----------
>    pkcs15-tool: remove unused 'pubkey_pem_encode()'
>
> used instead the sc_pkcs15_encode_pubkey_as_spki()
>
>
>    Commit: 5437f87d4b7ac5848dae22ff8f6a597da014d708
>        https://github.com/OpenSC/OpenSC/commit/5437f87d4b7ac5848dae22ff8f6a597da014d708
>    Author: Viktor Tarasov <vik...@gm...>
>    Date:   2014-01-13 (Mon, 13 Jan 2014)
>
>    Changed paths:
>      M src/libopensc/pkcs15-pubkey.c
>      M src/pkcs15init/pkcs15-lib.c
>
>    Log Message:
>    -----------
>    pkcs15: encode public key algorithm (issue 202)
>
> coding style: use linux style line break
>
>
> Compare: https://github.com/OpenSC/OpenSC/compare/3dba84714f2c...5437f87d4b7a
>
>
>
> ------------------------------------------------------------------------------
> CenturyLink Cloud: The Leader in Enterprise Cloud Services.
> Learn Why More Businesses Are Choosing CenturyLink Cloud For
> Critical Workloads, Development Environments & Everything In Between.
> Get a Quote or Start a Free Trial Today.
> http://pubads.g.doubleclick.net/gampad/clk?id=119420431&iu=/4140/ostg.clktrk
>
>
>
> _______________________________________________
> Opensc-commits mailing list
> Ope...@li...
> https://lists.sourceforge.net/lists/listinfo/opensc-commits
>

-- 

  Douglas E. Engert  <DEE...@an...> <DEE...@gm...>
  Argonne National Laboratory
  9700 South Cass Avenue
  Argonne, Illinois  60439
  (630) 252-5444