From: Ludovic R. <lud...@gm...> - 2013-08-04 17:08:07
|
2013/8/4 Alex Samorukov <ml...@os...>: > Hi, Hello, > As OpenSC user it is unclear for me why bug 173 was closed without any > resolution. From my personal point of view proposed patch was not able > to cause any issues for OpenSC users. I am agree that problem is > probably with standard compliance, but i don`t understand why OpenSC > should drop support of popular hardware because of this reason. E.g. > ACPI code in the Linux kernel supports many exceptions or buggy > chipsets. I don`t see any benefits that users with similar problems will > use third-party patches instead. It would be great if other developers > can take a look on this issue. > > If my patch is done in a wrong way - please recommend how to do it > properly, but i think that closing real issue (even if it is caused by > wrong windows official driver) is not a good approach. Viktor tried to explain why your code is not accepted. You are patching a core function src/pkcs11/framework-pkcs15.c to fix a bug for a non standard card. The correct way to add specific code is to use/create a card-* and/or pkcs15-* file. Bye -- Dr. Ludovic Rousseau |