[Opensc-commits] [OpenSC/OpenSC] f05307: libopensc: assertion fails on calling fclose() on ...

[GitHub <no...@gi...>]

  Branch: refs/heads/master
  Home:   https://github.com/OpenSC/OpenSC
  Commit: f053070e14c33098da18bd5a4c11e039f11a9a6b
      https://github.com/OpenSC/OpenSC/commit/f053070e14c33098da18bd5a4c11e039f11a9a6b
  Author: Viktor Tarasov <vik...@gm...>
  Date:   2013-08-02 (Fri, 02 Aug 2013)

  Changed paths:
    M src/libopensc/ctx.c
    M src/libopensc/log.c

  Log Message:
  -----------
  libopensc: assertion fails on calling fclose() on a NULL filehandle

>From @geoffbeier:
(https://github.com/OpenSC/OpenSC/pull/171#issuecomment-20407132)

So it sounds like the right fix is to:

 * check the return value of sc_ctx_log_to_file() and have sc_do_log_va()
   return if it's anything other than SC_SUCCESS.
 * Inside sc_ctx_log_to_file() make sure to set ctx->debug_file to NULL
   whenever it does call fclose() on it.
 * Inside sc_do_log_va() where it currently calls fclose() check
   if(ctx->debug_file && ctx->debug_file != stdout &&ctx->debug_file != stderr)


  Commit: c4c189fec3da4bd19b76c6dfaa7496179eb3b387
      https://github.com/OpenSC/OpenSC/commit/c4c189fec3da4bd19b76c6dfaa7496179eb3b387
  Author: Viktor Tarasov <vik...@gm...>
  Date:   2013-08-02 (Fri, 02 Aug 2013)

  Changed paths:
    M src/Makefile.am

  Log Message:
  -----------
  make: change make order of SM components

to respect dependencies


Compare: https://github.com/OpenSC/OpenSC/compare/3567660a1c5d...c4c189fec3da