#3252 clm: memleak detected by valgrind

[Surbhi Tripathi]

==245== 35,424 bytes in 54 blocks are definitely lost in loss record 172 of 175
==245== at 0x4C33B25: calloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==245== by 0x56997DE: clma_mds_dec(ncsmds_callback_info) (clma_mds.cc:701)
==245== by 0x5699013: clma_mds_callback(ncsmds_callback_info) (clma_mds.cc:1091)
==245== by 0x58FC5EB: mds_mcm_do_decode_full_or_flat.isra.0 (mds_c_sndrcv.c:5619)
==245== by 0x58FE327: mds_mcm_process_recv_snd_msg_common.part.5 (mds_c_sndrcv.c:4914)
==245== by 0x58FE7DA: mcm_recv_red_bcast (mds_c_sndrcv.c:5143)
==245== by 0x58FE7DA: mds_mcm_ll_data_rcv (mds_c_sndrcv.c:4808)
==245== by 0x5904060: mdtm_process_recv_message_common (mds_dt_common.c:572)
==245== by 0x5904431: mdtm_process_recv_data (mds_dt_common.c:1122)
==245== by 0x590CA7E: mdtm_process_recv_events (mds_dt_tipc.c:1146)
==245== by 0x60E96DA: start_thread (pthread_create.c:463)
==245== by 0x642271E: clone (clone.S:95)

[Surbhi Tripathi]

There are multiple "CLMSV_CLMS_TO_CLMA_IS_MEMBER_MSG" which were not dispatched ( which finally destroys the message). Number of messages not being dispatched is equal to the number of blocks leaked.

$grep -r " CLMSV_CLMS_TO_CLMA_IS_MEMBER_MSG:" ./SC-* |wc -l
54

/var/lib/lxc/SC-1/rootfs/var/log/opensaf/.245.valgrind:==245== 35,424 bytes in 54 blocks are definitely lost in loss record 185 of 188

[Surbhi Tripathi]

commit ccaaff3962fe3ae48167ea959299b698bb69e3f4 (HEAD -> develop, origin/develop)
Author: ztrisur Surbhi.tripathi@dektech.com.au
Date: Thu Mar 25 11:53:24 2021 +1100

clm: memleak detected by valgrind [#3252]

"CLMSV_CLMS_TO_CLMA_IS_MEMBER_MSG" were not destroyed. Fixed that.