#3013 nid: opensafd was crashed during start-up

[Vu Minh Nguyen]

opensafd was crashed during start-up since the monitor thread received a strange name whose size is over maximum length: nid_name = "CLMNARDEHLFMIMMDIMMNDLOGDNTFDC"

2019-02-22 02:44:26.585 SC-1 osaftransportd[445]: Started
2019-02-22 02:44:26.588 SC-1 opensafd[140]: NO Monitoring of TRANSPORT started
2019-02-22 02:44:26.589 SC-1 opensafd[140]: src/nid/nodeinit.cc:1542: svc_monitor_thread: Assertion 'read_rc < NID_MAXSNAME' failed.
2019-02-22 02:44:26.608 SC-1 osafamfnd[292]: NO 'safSu=SC-1,safSg=NoRed,safApp=OpenSAF' Presence State INSTANTIATING => INSTANTIATED
2019-02-22 02:44:27.442 SC-1 osafamfd[277]: NO Received node_up from 2060f: msg_id 1
2019-02-22 02:44:27.442 SC-1 osafamfd[277]: NO Received node_up from 2050f: msg_id 1
2019-02-22 02:44:27.442 SC-1 osafamfd[277]: NO Received node_up from 2030f: msg_id 1
2019-02-22 02:44:27.442 SC-1 osafamfd[277]: NO Received node_up from 2040f: msg_id 1
2019-02-22 02:44:27.445 SC-1 osafamfnd[292]: NO Assigning 'safSi=NoRed1,safApp=OpenSAF' ACTIVE to 'safSu=SC-1,safSg=NoRed,safApp=OpenSAF'
2019-02-22 02:44:27.445 SC-1 osafamfnd[292]: NO Assigned 'safSi=NoRed1,safApp=OpenSAF' ACTIVE to 'safSu=SC-1,safSg=NoRed,safApp=OpenSAF'
2019-02-22 02:44:27.590 SC-1 opensafd[109]: Starting OpenSAF Services (Using TIPC):Aborted (core dumped)

The full backtrace is attached.

[Vu Minh Nguyen]

syslog

[Vu Minh Nguyen]

https://sourceforge.net/p/opensaf/mailman/message/36598313/

[Vu Minh Nguyen]

commit a4c13cca035b90e547048ec78b6fee07f54d6566 (HEAD -> develop, origin/develop)
Author: Vu Minh Nguyen vu.m.nguyen@dektech.com.au
Date: Wed Feb 27 17:20:42 2019 +0700

nid: fix opensafd crashed during start-up [#3013]

There is a dependency b/w svc_monitor_thread and spawn_services.
The coredump happens when spawn_services is executed while
the thread has not yet started. In this case, data is sent to the
pipe but no one consumed it. When it comes to consume the data,
will get unexpected data and crash the program.

This patch ensures the things will happen in the right order:
svc_monitor_thread must be in ready state before spawn_services()
is executed.