Menu

#2830 imm: mismatch b/w immutil_saImmOxInitialize and corresponding APIs

5.18.04
fixed
nobody
None
defect
imm
lib
major
False
2018-04-17
2018-04-05
No

The version in saImmO{m,i}Initialize is input/output parameter and is declared as non-constant for both IMM OM and OI API.

But in immutil wrapper library, some are declared as constant and the version is not update before returning from such wrappers.

Related

Wiki: ChangeLog-5.18.04

Discussion

  • Vu Minh Nguyen

    Vu Minh Nguyen - 2018-04-05
    • status: accepted --> review
     
  • Vu Minh Nguyen

    Vu Minh Nguyen - 2018-04-05
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -1,3 +1,3 @@
     The `version` in `saImmO{m,i}Initialize` is input/output parameter and is declared as non-constant for both IMM OM and OI API.
    
    -But in immutil wrapper library,  some are declared as constant and *don't update*  the in/out `version` before returning from such wrappers. 
    +But in immutil wrapper library,  some are declared as constant and the version *is not update*  before returning from such wrappers. 
    
     
  • Vu Minh Nguyen

    Vu Minh Nguyen - 2018-04-13

    Code in samples/immsv/immutils/immutil.{h,c} need to be fixed too.

     
  • Vu Minh Nguyen

    Vu Minh Nguyen - 2018-04-17
    • status: review --> fixed
    • assigned_to: Vu Minh Nguyen --> nobody
     
  • Vu Minh Nguyen

    Vu Minh Nguyen - 2018-04-17

    commit 9f47acbc11b9f8cbe19be7c0c2869cdc5ff0ea6b (HEAD, origin/develop, develop)
    Author: Vu Minh Nguyen vu.m.nguyen@dektech.com.au
    Date: Tue Apr 17 09:40:04 2018 +0700

    imm: make version parameter in immutil_xxx non-const [#2830]
    
    The version in saImmO{m,i}Initialize is input/output parameter and is declared
    as non-constant for both IMM OM and OI API according to SAF spec.
    But in immutil wrapper library, some are declared as constant parameter
    and the version is not updated before returning from such wrappers.
    
    This patch makes that parameter non-const [in/out] and do update the version
    before returning from wrapper APIs. Also fix the wrong usages of
    these wrappers - passed constant version, in some services/applications.
    
     

Log in to post a comment.