Menu

#2826 imm: potential leak of memory pointed to by ao_node in OM API

5.21.06
fixed
None
defect
imm
lib
major
False
2021-03-25
2018-04-04
No

The allocated memory ao_node should be freed before going to lock_fail in below code:

::: C++
/* Allocate the IMMA_ADMIN_OWNER_NODE & Populate */
ao_node = calloc(1, sizeof(IMMA_ADMIN_OWNER_NODE));
...
mds_send_fail:
      if (m_NCS_LOCK(&cb->cb_lock, NCS_LOCK_WRITE) != NCSCC_RC_SUCCESS) {
        rc = SA_AIS_ERR_LIBRARY;
        **goto lock_fail;**
      }
      locked = true;

  admin_owner_node_free:
      if (ao_node != NULL) {
        free(ao_node);
        ao_node = NULL;
      }

lock_fail:
      if (out_evt) free(out_evt);
      return rc;
    }

Related

Wiki: ChangeLog-5.21.06

Discussion

  • Gary Lee

    Gary Lee - 2018-09-29
    • Milestone: 5.18.04 --> future
     
  • Surbhi Tripathi

    Surbhi Tripathi - 2021-03-23
    • status: accepted --> assigned
    • assigned_to: Vu Minh Nguyen --> Surbhi Tripathi
    • Milestone: future --> 5.21.06
     
  • Surbhi Tripathi

    Surbhi Tripathi - 2021-03-24
    • status: assigned --> review
     
  • Surbhi Tripathi

    Surbhi Tripathi - 2021-03-25

    commit 0ef3528def6fea13daa1a7a07f34db4994a5e636 (HEAD -> develop, origin/develop, ticket-2826)
    Author: ztrisur Surbhi.tripathi@dektech.com.au
    Date: Thu Mar 25 09:46:03 2021 +1100

    imm: potential leak of memory pointed to by ao_node in OM API [#2826]
    
     
  • Surbhi Tripathi

    Surbhi Tripathi - 2021-03-25
    • status: review --> fixed
     

Log in to post a comment.