Menu

#2805 base: Close a long list of not-inherited fds

5.18.04
fixed
None
defect
base
lib
minor
False
2018-03-22
2018-03-09
No

In ncs_os_process_execute_timed(), if OPENSAF_KEEP_FD_OPEN_AFTER_FORK is unset, after fork() currently we are closing all possible fds. SC_OPEN_MAX could be a big number, that causes unexpected delays when amf launches component processes.

Related

Tickets: #2814
Wiki: ChangeLog-5.18.04

Discussion

  • Minh Hon Chau

    Minh Hon Chau - 2018-03-09

    One possibility is that obtaining the open fds of parent process by reading /proc/self/fd and only close the inherited ones in child process

     
  • Minh Hon Chau

    Minh Hon Chau - 2018-03-14
    • status: unassigned --> accepted
    • assigned_to: Minh Hon Chau
     
  • Minh Hon Chau

    Minh Hon Chau - 2018-03-15
    • status: accepted --> review
     
  • Minh Hon Chau

    Minh Hon Chau - 2018-03-22
    • status: review --> fixed
     
  • Minh Hon Chau

    Minh Hon Chau - 2018-03-22

    [develop]
    commit d9242ba1651af32ecfb63142d2c88072a0852bc3
    Author: Minh Chau minh.chau@dektech.com.au
    Date: Thu Mar 22 11:19:44 2018 +1100

    base: Only close inherited fd(s) after fork() in child process [#2805]
    
     

Log in to post a comment.