Menu

#2591 imm: Admo id is not updated after resurrecting the client

5.17.11
fixed
None
defect
imm
lib
major
False
2017-10-30
2017-09-25
Hung Nguyen
No

Steps to reproduce:

  1. OmAdminOwnerInitialize (ROF=False)
  2. OmAdminOwnerSet
  3. Kill osafimmnd and wait for it to finishing syncing
  4. OmAdminOperationInvoke returns ERR_BAD_HANDLE, it should return OK.

In admin_op_invoke_common(), admo id is obtained before checking for the client being stale.

  adminOwnerId = ao_node->mAdminOwnerId;
...
  if (cl_node->stale) {
... // If stale, ao_node->mAdminOwnerId my be upadted with new value here
  }

In case of the client being stale, new admo id will be retrieved from the server and set to ao_node->mAdminOwnerId.
adminOwnerId should be assigned after resurrecting.

Related

Wiki: ChangeLog-5.17.11

Discussion

  • Hung Nguyen

    Hung Nguyen - 2017-09-26
    • status: accepted --> review
     
  • Hung Nguyen

    Hung Nguyen - 2017-09-30
     
  • Hung Nguyen

    Hung Nguyen - 2017-09-30

    develop (5.17.10) [code:704bdb]

    commit 704bdbcfb4fe3f400fb731d99fdfb3dc567de626
    Author: Hung Nguyen <hung.d.nguyen@dektech.com.au>
    Date:   Sat Sep 30 20:31:05 2017 +0700
    
        imm: Update admo id after resurrecting [#2591]
    
        Update admo id after resurrecting.
    

    release [code:597b98]

    commit 597b98026c1101e675230ee1914f18f451745396
    Author: Hung Nguyen <hung.d.nguyen@dektech.com.au>
    Date:   Sat Sep 30 20:31:05 2017 +0700
    
        imm: Update admo id after resurrecting [#2591]
    
        Update admo id after resurrecting.
    
     

    Related

    Commit: [597b98]
    Commit: [704bdb]

  • Hung Nguyen

    Hung Nguyen - 2017-09-30
    • status: review --> fixed
     

Log in to post a comment.