Menu ▾ ▴

#2539 amfa: Incorrect return code from saAmfPmStart_3() and saAmfResponse_4() for invalid handle

5.17.07
fixed
nobody
None
defect
amf
lib
minor
False
2018-06-08
2017-08-01
Nguyen TK Luu
No

When saAmfPmStart_3() and saAmfResponse_4() are called with uninitialized or already-finalized handle, they return SA_AIS_ERR_VERSION instead of SA_AIS_ERR_BAD_HANDLE.

Reproduce:

  • Case 1:
    Call saAmfPmStart_3() or saAmfResponse_4() with an uninitialized handle (arbitrary value).

  • Case 2:

    1. Call saAmfInitialize.
    2. Call saAmfFinalize with the handle obtained in 1).
    3. Call saAmfPmStart_3() or saAmfResponse_4() with the finalized handle.

Similar ticket #248 was created for saAmfComponentErrorReport_4 () and saAmfComponentErrorClear_4().

Related

Wiki: ChangeLog-5.17.11

Discussion

  • Nguyen TK Luu

    Nguyen TK Luu - 2017-08-01
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -1,8 +1,10 @@
 When saAmfPmStart_3() and saAmfResponse_4() are called with uninitialized or already-finalized handle, they return SA_AIS_ERR_VERSION instead of SA_AIS_ERR_BAD_HANDLE.

 Reproduce:
+
 * Case 1:
     Call saAmfPmStart_3() or saAmfResponse_4() with an unitialized handle (arbitrary value).
+
 * Case 2:
     1. Call saAmfInitialize.
     2. Call saAmfFinalize with the handle obtained in 1)
     

  • Nguyen TK Luu

    Nguyen TK Luu - 2017-08-01
    • summary: amf: Incorrect return code from saAmfPmStart_3() and saAmfResponse_4() for invalid handle --> amfa: Incorrect return code from saAmfPmStart_3() and saAmfResponse_4() for invalid handle
     

  • Nguyen TK Luu

    Nguyen TK Luu - 2017-08-01
    • Description has changed:

    Diff:

    --- old
+++ new
@@ -3,11 +3,11 @@
 Reproduce:

 * Case 1:
-    Call saAmfPmStart_3() or saAmfResponse_4() with an unitialized handle (arbitrary value).
+    Call saAmfPmStart_3() or saAmfResponse_4() with an uninitialized handle (arbitrary value).

 * Case 2:
     1. Call saAmfInitialize.
-    2. Call saAmfFinalize with the handle obtained in 1)
+    2. Call saAmfFinalize with the handle obtained in 1).
     3. Call saAmfPmStart_3() or saAmfResponse_4() with the finalized handle.

 Similar ticket [#248](http://sourceforge.net/p/opensaf/tickets/248/) was created for saAmfComponentErrorReport_4 () and saAmfComponentErrorClear_4().
     

  • Nguyen TK Luu

    Nguyen TK Luu - 2017-08-02
    • status: assigned --> review
     

  • Nguyen TK Luu

    Nguyen TK Luu - 2017-08-11
    • Milestone: 5.17.10 --> 5.17.07
     

  • Gary Lee

    Gary Lee - 2017-08-15

    develop:

    commit 5302e11d528a33cce150a1583b829452b96b440d
    Author: Nguyen Luu nguyen.tk.luu@dektech.com.au
    Date: Tue Aug 15 16:06:49 2017 +1000

    amfa: Fix saAmfPmStart_3 and saAmfResponse_4 to correctly return BAD_HANDLE [#2539]

When called with an uninitialized or already finalized handle,
saAmfPmStart_3 and saAmfResponse_4 should return SA_AIS_ERR_BAD_HANDLE
instead of SA_AIS_ERR_VERSION as previously done.

    release:

    commit 023e169f6e54adcf81147af4c3b0e2a3799948fb
    Author: Nguyen Luu nguyen.tk.luu@dektech.com.au
    Date: Tue Aug 15 16:06:49 2017 +1000

    amfa: Fix saAmfPmStart_3 and saAmfResponse_4 to correctly return BAD_HANDLE [#2539]

When called with an uninitialized or already finalized handle,
saAmfPmStart_3 and saAmfResponse_4 should return SA_AIS_ERR_BAD_HANDLE
instead of SA_AIS_ERR_VERSION as previously done.
     

  • Gary Lee

    Gary Lee - 2017-08-15
    • status: review --> fixed
     

  • Nguyen TK Luu

    Nguyen TK Luu - 2018-06-08
    • assigned_to: Nguyen TK Luu --> nobody
     

Log in to post a comment.