OpenSAF / Tickets / #2445 log: reorganize headers and implementation

Vu Minh Nguyen - 2017-05-30

Description has changed:

Diff:

--- old +++ new @@ -2,3 +2,4 @@ 1) Put headers and implementations in proper places 2) Fix all cppcheck messages 3) Fix all cpplint messages +4) Replace NULL by nullptr

assigned_to: Vu Minh Nguyen --> Canh Truong
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Description has changed:

Diff:

--- old
+++ new
@@ -1,5 +1,7 @@
 This ticket intends to do some enhancements:
-1) Put headers and implementations in proper places
+1) Put public interfaces and its implementations in proper places (e.g: lgs_amf_init() interface could be put into lgs_amf.h file)
 2) Fix all cppcheck messages
 3) Fix all cpplint messages
 4) Replace NULL by nullptr
+
+Will divide the fix to several increaments. The purpose is to make the review patch small and avoid code rebasing. The work could be fixing all above items for few files, then send it out for review.

Anders Widell - 2017-07-01

Milestone: 5.17.08 --> 5.17.10
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Canh Truong - 2017-07-20

status: accepted --> review
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Canh Truong - 2017-07-20

Part1 - Fix cppcheck, cpplint, replace nullptr for following files:
- lgs_amf. , lgs_config. , lgs_dest. , lgs_evt. , lgs_file. ,
lgs_filehdl. , lgs_nildest. , lgs_unixsock_dest.
lgs_util. , lgs_dest_test.

Last edit: Canh Truong 2017-07-20

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Vu Minh Nguyen - 2017-08-11

status: review --> accepted
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Vu Minh Nguyen - 2017-08-11

[develop]
commit 8a15fb881c238d4e3246d97d7e5201e5ae235af5
Author: Canh Van Truong canh.v.truong@dektech.com.au
Date: Wed Jul 19 18:07:16 2017 +0700

log: fix cppcheck, cpplint and reorganize headers - part 1 [#2445]
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Canh Truong - 2017-10-30

status: accepted --> review
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anders Widell - 2017-10-30

Milestone: 5.17.10 --> 5.18.01
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anders Widell - 2018-02-02

Milestone: 5.18.01 --> 5.18.04
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Anders Widell - 2018-04-20

Milestone: 5.18.04 --> 5.18.06
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Gary Lee - 2018-06-29

Milestone: 5.18.06 --> 5.18.08
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Gary Lee - 2018-09-29

Milestone: 5.18.09 --> 5.18.12
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Gary Lee - 2018-09-29

Is this still being reviewed?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Canh Truong - 2018-10-01

status: review --> unassigned

assigned_to: Canh Truong --> nobody
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Gary Lee - 2019-01-09

Milestone: 5.19.01 --> 5.19.03
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Gary Lee - 2019-01-09

Milestone: 5.19.03 --> future
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

log: reorganize headers and implementation

Milestone

Searches

Help

#2445 log: reorganize headers and implementation

Related

Discussion