#1386 AMFND: Comp receives QUIESCED csi when it has not received ACTIVE csi

[Minh Hon Chau]

A brief description about the test:
During unlock nodegroup, a component raises errorReport(SA_AMF_COMPONENT_FAILOVER)
- Assigning ACTIVE SI is ongoing but not completed, which means the other components have not received csiSet yet.
- ErrorReport initiates component failover, amfnd receives QUIESCED su-si event from amfd
- A part of avnd_comp_csi_assign() means that amfnd will not send QUIESCED csi to component which's csi is not in ASSIGNED state.
- But in this test, amfnd does send QUIESCED csi to unassigned component

---

Full traces are attached, just copy a trace snippet with some additional debugs

Jun 12 10:48:15.133971 osafamfnd [418:su.cc:0382] >> avnd_evt_avd_info_su_si_assign_evh: 'safSu=1,safSg=1,safApp=abcdtest'
Jun 12 10:48:15.133975 osafamfnd [418:susm.cc:0183] >> avnd_su_siq_rec_buf: 'safSu=1,safSg=1,safApp=abcdtest'
Jun 12 10:48:15.133978 osafamfnd [418:susm.cc:0196] << avnd_su_siq_rec_buf
Jun 12 10:48:15.133980 osafamfnd [418:susm.cc:0311] >> avnd_su_si_msg_prc: 'safSu=1,safSg=1,safApp=abcdtest', act=5, ha_state=3, single_csi=0
Jun 12 10:48:15.133983 osafamfnd [418:sidb.cc:0580] >> avnd_su_si_all_modify:

Jun 12 10:48:15.133986 osafamfnd [418:sidb.cc:0585] TR DEBUG: curr_si->prv_state:0
Jun 12 10:48:15.133992 osafamfnd [418:sidb.cc:0588] TR DEBUG: curr_si->prv_state:1

Jun 12 10:48:15.133995 osafamfnd [418:sidb.cc:0630] >> avnd_su_si_csi_all_modify: (nil)
Jun 12 10:48:15.133998 osafamfnd [418:sidb.cc:0686] << avnd_su_si_csi_all_modify
Jun 12 10:48:15.134000 osafamfnd [418:sidb.cc:0602] << avnd_su_si_all_modify
Jun 12 10:48:15.134002 osafamfnd [418:susm.cc:0637] >> avnd_su_si_assign: 'safSu=1,safSg=1,safApp=abcdtest' '(null)'
Jun 12 10:48:15.134005 osafamfnd [418:susm.cc:0458] >> assign_si_to_su: 'safSi=ABC,safApp=abcdtest' si-state'3' 'safSu=1,safSg=1,safApp=abcdtest' single_csi=0
Jun 12 10:48:15.134019 osafamfnd [418:susm.cc:0460] NO Assigning 'safSi=ABC,safApp=abcdtest' QUIESCED to 'safSu=1,safSg=1,safApp=abcdtest'
Jun 12 10:48:15.134023 osafamfnd [418:comp.cc:0914] >> avnd_comp_csi_assign: comp:'safComp=C,safSu=1,safSg=1,safApp=abcdtest'
Jun 12 10:48:15.134026 osafamfnd [418:comp.cc:0915] IN Assigning 'all CSIs' QUIESCED to 'safComp=C,safSu=1,safSg=1,safApp=abcdtest'

Jun 12 10:48:15.134028 osafamfnd [418:comp.cc:0987] TR DEBUG: curr_csi->comp_name:safComp=C,safSu=1,safSg=1,safApp=abcdtest
Jun 12 10:48:15.134030 osafamfnd [418:comp.cc:0988] TR DEBUG: curr_csi->prv_assign_state:1
Jun 12 10:48:15.134033 osafamfnd [418:comp.cc:0989] TR DEBUG: curr_csi->curr_assign_state:1
Jun 12 10:48:15.134035 osafamfnd [418:comp.cc:0990] TR DEBUG: curr_csi->si->curr_assign_state:2
Jun 12 10:48:15.134037 osafamfnd [418:comp.cc:0991] TR DEBUG: curr_csi->si->prv_assign_state:2
Jun 12 10:48:15.134039 osafamfnd [418:comp.cc:0997] TR DEBUG: curr_csi->si->name:safSi=ABC,safApp=abcdtest
Jun 12 10:48:15.134042 osafamfnd [418:comp.cc:0998] TR DEBUG: curr_csi->si->prv_state:1
Jun 12 10:48:15.134044 osafamfnd [418:comp.cc:0999] TR DEBUG: curr_csi->si->curr_state:3

Jun 12 10:48:15.134046 osafamfnd [418:comp.cc:1892] >> avnd_comp_cbk_send: 'safComp=C,safSu=1,safSg=1,safApp=abcdtest' 3

---

This problem should also happen in normal su unlock within component failover trigger

[Minh Hon Chau]

Attach model, hack amf_demo patch for repeat the problem.

Commands:

immcfg -f ./app3_twon2su1si.xml
immcfg -a saAmfNodeSuFailoverMax=100 safAmfNode=PL-4,safAmfCluster=myAmfCluster
echo 1 > /root/err
echo 1 > /root/delay
amf-adm unlock-in safSu=SU4,safSg=AmfDemoTwon,safApp=AmfDemoTwon
amf-adm unlock-in safSu=SU5,safSg=AmfDemoTwon,safApp=AmfDemoTwon
amf-adm unlock safSu=SU4,safSg=AmfDemoTwon,safApp=AmfDemoTwon
echo 0 > /root/err

[Nagendra Kumar]

changeset: 6748:96fa8fd63c7c
branch: opensaf-4.5.x
parent: 6745:46c0ddb783cd
user: Minh Hon Chauminh.chau@dektech.com.au
date: Thu Aug 20 17:12:39 2015 +0530
summary: amfnd: comp receives QUIESCED csi when it has not received ACTIVE csi V4 [#1386]

changeset: 6749:639a1323fb05
branch: opensaf-4.6.x
parent: 6746:c053728b3357
user: Minh Hon Chauminh.chau@dektech.com.au
date: Thu Aug 20 17:13:05 2015 +0530
summary: amfnd: comp receives QUIESCED csi when it has not received ACTIVE csi V4 [#1386]

changeset: 6750:61429c868555
tag: tip
parent: 6747:f10722994dcf
user: Minh Hon Chauminh.chau@dektech.com.au
date: Thu Aug 20 17:13:30 2015 +0530
summary: amfnd: comp receives QUIESCED csi when it has not received ACTIVE csi V4 [#1386]

[staging:96fa8f]
[staging:639a13]
[staging:61429c]