#1152 osafdtmd segfaults

[Hans Feldt]

starting opensaf with an invalid IP address in dtmd.conf osafdtmd segafaults:

(gdb) run -n
Starting program: /home/uabhafe/local/lib/opensaf/osafdtmd -n
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib/x86_64-linux-gnu/libthread_db.so.1".
[New Thread 0x7ffff7fd4b00 (LWP 5688)]

Program received signal SIGSEGV, Segmentation fault.
0x00000000004065fb in dtm_validate_listening_ip_addr (config=config@entry=0x61b9c0 <_dtms_cb>) at dtm_read_config.c:140
140 if (if_addr->ifa_addr->sa_family == AF_INET) {
(gdb) info locals
if_addrs = <optimized out="">
if_addr = 0x6306d0
tmp = 0x0
(gdb) p *if_addr
$2 = {ifa_next = 0x630788, ifa_name = 0x630774 "tun0", ifa_flags = 69841, ifa_addr = 0x0, ifa_netmask = 0x0, ifa_ifu = {ifu_broadaddr = 0x0, ifu_dstaddr = 0x0}, ifa_data = 0x630e00}

[Hans Feldt]

fails when vpn is setup, The scan crash when it hits the tun0 interface

[Hans Feldt]

diff --git a/osaf/services/infrastructure/dtms/dtm/dtm_read_config.c b/osaf/services/infrastructure/dtms/dtm/dtm_read_config.c
--- a/osaf/services/infrastructure/dtms/dtm/dtm_read_config.c
+++ b/osaf/services/infrastructure/dtms/dtm/dtm_read_config.c
@@ -136,6 +136,9 @@ char *dtm_validate_listening_ip_addr(DTM

                    TRACE("Interface name : %s", if_addr->ifa_name);

• if (if_addr->ifa_addr == NULL)
• continue;
  +
  // Address
  if (if_addr->ifa_addr->sa_family == AF_INET) {
  tmp = &((struct sockaddr_in *)if_addr->ifa_addr)->sin_addr;

[Nagendra Kumar]

My suggestion/requirement would be:
1. dtmd should set the default IP address configured on eth0 and throws a notice message. This also helps in testing as you don't have to configure IP address every time, you install.
2. If eth0 is not found, throw an error and exit.

[Hans Feldt]

I would like the default to be on the loopback interface, address 127.0.0.1
That is always available and for prototyping playing with opensaf it works nicely!
If someone starts opensaf on a corporate LAN and eth0 is configured it is not so good.

[Nagendra Kumar]

You mean that taking 127.0.0.1 is not advisable? It also have another side effect that only one node will come up with 127.0.0.1.
My opinion is : Have everything as current behavior(avoid crash of course), insert a logic in between to take IP address of eth0 if configured IP is not matching with any IP addresses available on all interfaces and send syslog intimating the same.
If eth0 is also not available, maintain the same behavior.

[Hans Feldt]

Yes I mean to have 127.0.0.1 as default which is a safe default. eth0 is not. If you want/need a cluster you have to configure it anyway.

[Hans Feldt]

changeset: 5994:917623d21cf6
branch: opensaf-4.3.x
parent: 5990:0974fdd2ef70
user: Hans Feldt hans.feldt@ericsson.com
date: Mon Oct 06 09:49:53 2014 +0200
summary: dtm: fix NULL ptr dereference [#1152]

changeset: 5995:bb58bd44d93f
branch: opensaf-4.4.x
parent: 5991:46bd98b1d43d
user: Hans Feldt hans.feldt@ericsson.com
date: Mon Oct 06 09:49:53 2014 +0200
summary: dtm: fix NULL ptr dereference [#1152]

changeset: 5996:89d33770e737
branch: opensaf-4.5.x
parent: 5992:c01a7d0e0a15
user: Hans Feldt hans.feldt@ericsson.com
date: Mon Oct 06 09:49:53 2014 +0200
summary: dtm: fix NULL ptr dereference [#1152]

changeset: 5997:88eeaf69642a
tag: tip
parent: 5993:d04b7c9fec97
user: Hans Feldt hans.feldt@ericsson.com
date: Mon Oct 06 09:49:53 2014 +0200
summary: dtm: fix NULL ptr dereference [#1152]

[Hans Feldt]

changeset: 5998:dff1a47eed83
branch: opensaf-4.3.x
parent: 5994:917623d21cf6
user: Hans Feldt hans.feldt@ericsson.com
date: Mon Oct 06 09:58:23 2014 +0200
summary: dtm: fix compiler warning [#1152]

changeset: 5999:f5211afdf779
branch: opensaf-4.4.x
parent: 5995:bb58bd44d93f
user: Hans Feldt hans.feldt@ericsson.com
date: Mon Oct 06 09:58:23 2014 +0200
summary: dtm: fix compiler warning [#1152]

changeset: 6000:7e46e7698b61
branch: opensaf-4.5.x
parent: 5996:89d33770e737
user: Hans Feldt hans.feldt@ericsson.com
date: Mon Oct 06 09:58:23 2014 +0200
summary: dtm: fix compiler warning [#1152]

changeset: 6001:f43bbfae4011
tag: tip
parent: 5997:88eeaf69642a
user: Hans Feldt hans.feldt@ericsson.com
date: Mon Oct 06 09:58:23 2014 +0200
summary: dtm: fix compiler warning [#1152]