From: Zoran M. <zor...@er...> - 2015-09-24 15:11:59
|
Summary: imm: correct ccbId in immnd_evt_proc_ccb_apply [#1501] Review request for Trac Ticket(s): 1501 Peer Reviewer(s): Neelakanta Pull request to: Zoran Affected branch(es): opensaf-4.5.x, opensaf-4.6.x Development branch: opensaf-4.6.x -------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- changeset a49d948d513c3a0d3b133bf1bfd024ad22e2a280 Author: Zoran Milinkovic <zor...@er...> Date: Thu, 24 Sep 2015 17:09:42 +0200 imm: correct ccbId in immnd_evt_proc_ccb_apply [#1501] The patch corrects the right ccbId in the evt->info union. Complete diffstat: ------------------ osaf/services/saf/immsv/immnd/immnd_evt.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) Testing Commands: ----------------- Testing, Expected Results: -------------------------- Conditions of Submission: ------------------------- Ack from Neelakanta Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. |
From: Zoran M. <zor...@er...> - 2015-09-24 15:12:16
|
Summary: imm: correct ccbId in immnd_evt_proc_ccb_apply [#1501] Review request for Trac Ticket(s): 1501 Peer Reviewer(s): Neelakanta Pull request to: Zoran Affected branch(es): default(4.7) Development branch: default(4.7) -------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- changeset 32784fa9ca0d9f24b3afddcf570da8c9e448eb09 Author: Zoran Milinkovic <zor...@er...> Date: Thu, 24 Sep 2015 17:04:19 +0200 imm: correct ccbId in immnd_evt_proc_ccb_apply [#1501] The patch corrects the right ccbId in the evt->info union. Complete diffstat: ------------------ osaf/services/saf/immsv/immnd/immnd_evt.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) Testing Commands: ----------------- Testing, Expected Results: -------------------------- Conditions of Submission: ------------------------- Ack from Neelakanta Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. |
From: Zoran M. <zor...@er...> - 2015-09-24 15:12:18
|
osaf/services/saf/immsv/immnd/immnd_evt.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) The patch corrects the right ccbId in the evt->info union. diff --git a/osaf/services/saf/immsv/immnd/immnd_evt.c b/osaf/services/saf/immsv/immnd/immnd_evt.c --- a/osaf/services/saf/immsv/immnd/immnd_evt.c +++ b/osaf/services/saf/immsv/immnd/immnd_evt.c @@ -7759,7 +7759,7 @@ static void immnd_evt_proc_ccb_apply(IMM SaUint32T applCtn = 0; SaUint32T *applConnArr = NULL; SaUint32T applArrSize = - immModel_getLocalAppliersForCcb(cb, evt->info.objModify.ccbId, &applConnArr, &applCtn); + immModel_getLocalAppliersForCcb(cb, evt->info.ccbId, &applConnArr, &applCtn); if(applArrSize) { memset(&send_evt, '\0', sizeof(IMMSV_EVT)); @@ -7878,7 +7878,7 @@ static void immnd_evt_proc_ccb_apply(IMM memset(&send_evt, '\0', sizeof(IMMSV_EVT)); send_evt.type = IMMSV_EVT_TYPE_IMMA; send_evt.info.imma.info.errRsp.error = err; - send_evt.info.imma.info.errRsp.errStrings = immModel_ccbGrabErrStrings(cb, evt->info.objDelete.ccbId); + send_evt.info.imma.info.errRsp.errStrings = immModel_ccbGrabErrStrings(cb, evt->info.ccbId); if(send_evt.info.imma.info.errRsp.errStrings) { send_evt.info.imma.type = IMMA_EVT_ND2A_IMM_ERROR_2; |
From: Neelakanta R. <red...@or...> - 2015-09-25 09:02:54
|
Hi zoran, Reviewed the patch. Ack. /Neel. On Thursday 24 September 2015 08:42 PM, Zoran Milinkovic wrote: > osaf/services/saf/immsv/immnd/immnd_evt.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > > The patch corrects the right ccbId in the evt->info union. > > diff --git a/osaf/services/saf/immsv/immnd/immnd_evt.c b/osaf/services/saf/immsv/immnd/immnd_evt.c > --- a/osaf/services/saf/immsv/immnd/immnd_evt.c > +++ b/osaf/services/saf/immsv/immnd/immnd_evt.c > @@ -7759,7 +7759,7 @@ static void immnd_evt_proc_ccb_apply(IMM > SaUint32T applCtn = 0; > SaUint32T *applConnArr = NULL; > SaUint32T applArrSize = > - immModel_getLocalAppliersForCcb(cb, evt->info.objModify.ccbId, &applConnArr, &applCtn); > + immModel_getLocalAppliersForCcb(cb, evt->info.ccbId, &applConnArr, &applCtn); > > if(applArrSize) { > memset(&send_evt, '\0', sizeof(IMMSV_EVT)); > @@ -7878,7 +7878,7 @@ static void immnd_evt_proc_ccb_apply(IMM > memset(&send_evt, '\0', sizeof(IMMSV_EVT)); > send_evt.type = IMMSV_EVT_TYPE_IMMA; > send_evt.info.imma.info.errRsp.error = err; > - send_evt.info.imma.info.errRsp.errStrings = immModel_ccbGrabErrStrings(cb, evt->info.objDelete.ccbId); > + send_evt.info.imma.info.errRsp.errStrings = immModel_ccbGrabErrStrings(cb, evt->info.ccbId); > > if(send_evt.info.imma.info.errRsp.errStrings) { > send_evt.info.imma.type = IMMA_EVT_ND2A_IMM_ERROR_2; |
From: Neelakanta R. <red...@or...> - 2015-09-25 09:03:22
|
HI zoran, Reviewed the patch. Ack. /neel. On Thursday 24 September 2015 08:42 PM, Zoran Milinkovic wrote: > osaf/services/saf/immsv/immnd/immnd_evt.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > > The patch corrects the right ccbId in the evt->info union. > > diff --git a/osaf/services/saf/immsv/immnd/immnd_evt.c b/osaf/services/saf/immsv/immnd/immnd_evt.c > --- a/osaf/services/saf/immsv/immnd/immnd_evt.c > +++ b/osaf/services/saf/immsv/immnd/immnd_evt.c > @@ -7759,7 +7759,7 @@ static void immnd_evt_proc_ccb_apply(IMM > SaUint32T applCtn = 0; > SaUint32T *applConnArr = NULL; > SaUint32T applArrSize = > - immModel_getLocalAppliersForCcb(cb, evt->info.objModify.ccbId, &applConnArr, &applCtn); > + immModel_getLocalAppliersForCcb(cb, evt->info.ccbId, &applConnArr, &applCtn); > > if(applArrSize) { > memset(&send_evt, '\0', sizeof(IMMSV_EVT)); > @@ -7878,7 +7878,7 @@ static void immnd_evt_proc_ccb_apply(IMM > memset(&send_evt, '\0', sizeof(IMMSV_EVT)); > send_evt.type = IMMSV_EVT_TYPE_IMMA; > send_evt.info.imma.info.errRsp.error = err; > - send_evt.info.imma.info.errRsp.errStrings = immModel_ccbGrabErrStrings(cb, evt->info.objDelete.ccbId); > + send_evt.info.imma.info.errRsp.errStrings = immModel_ccbGrabErrStrings(cb, evt->info.ccbId); > > if(send_evt.info.imma.info.errRsp.errStrings) { > send_evt.info.imma.type = IMMA_EVT_ND2A_IMM_ERROR_2; |
From: Zoran M. <zor...@er...> - 2015-09-24 15:12:00
|
osaf/services/saf/immsv/immnd/immnd_evt.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) The patch corrects the right ccbId in the evt->info union. diff --git a/osaf/services/saf/immsv/immnd/immnd_evt.c b/osaf/services/saf/immsv/immnd/immnd_evt.c --- a/osaf/services/saf/immsv/immnd/immnd_evt.c +++ b/osaf/services/saf/immsv/immnd/immnd_evt.c @@ -7649,7 +7649,7 @@ static void immnd_evt_proc_ccb_apply(IMM SaUint32T applCtn = 0; SaUint32T *applConnArr = NULL; SaUint32T applArrSize = - immModel_getLocalAppliersForCcb(cb, evt->info.objModify.ccbId, &applConnArr, &applCtn); + immModel_getLocalAppliersForCcb(cb, evt->info.ccbId, &applConnArr, &applCtn); if(applArrSize) { memset(&send_evt, '\0', sizeof(IMMSV_EVT)); |
From: Neelakanta R. <red...@or...> - 2015-09-25 09:04:32
|
Hi zoran, Reviewed the patch. Ack. /Neel. On Thursday 24 September 2015 08:41 PM, Zoran Milinkovic wrote: > osaf/services/saf/immsv/immnd/immnd_evt.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > > The patch corrects the right ccbId in the evt->info union. > > diff --git a/osaf/services/saf/immsv/immnd/immnd_evt.c b/osaf/services/saf/immsv/immnd/immnd_evt.c > --- a/osaf/services/saf/immsv/immnd/immnd_evt.c > +++ b/osaf/services/saf/immsv/immnd/immnd_evt.c > @@ -7649,7 +7649,7 @@ static void immnd_evt_proc_ccb_apply(IMM > SaUint32T applCtn = 0; > SaUint32T *applConnArr = NULL; > SaUint32T applArrSize = > - immModel_getLocalAppliersForCcb(cb, evt->info.objModify.ccbId, &applConnArr, &applCtn); > + immModel_getLocalAppliersForCcb(cb, evt->info.ccbId, &applConnArr, &applCtn); > > if(applArrSize) { > memset(&send_evt, '\0', sizeof(IMMSV_EVT)); |