From: Zoran M. <zor...@er...> - 2015-09-12 10:42:20
|
Summary: imm: fix memory leak in display resources [#1477] Review request for Trac Ticket(s): 1477 Peer Reviewer(s): Neelakanta, Hung Pull request to: Zoran Affected branch(es): opensaf-4.5.x, opensaf-4.6.x, default(4.7) Development branch: default(4.7) -------------------------------- Impacted area Impact y/n -------------------------------- Docs n Build system n RPM/packaging n Configuration files n Startup scripts n SAF services y OpenSAF services n Core libraries n Samples n Tests n Other n Comments (indicate scope for each "y" above): --------------------------------------------- changeset 4581d497fbff57d03c32108444a47c6aa3c1d232 Author: Zoran Milinkovic <zor...@er...> Date: Sat, 12 Sep 2015 12:37:21 +0200 imm: fix memory leak in display resources [#1477] The patch releases allocated memory for the result of admin op for display resources Complete diffstat: ------------------ osaf/services/saf/immsv/immnd/immnd_evt.c | 27 +++++++++++++++++++++++++++ 1 files changed, 27 insertions(+), 0 deletions(-) Testing Commands: ----------------- Testing, Expected Results: -------------------------- Check that IMMND does not have memory leak after admin ops for display resources Conditions of Submission: ------------------------- Ack from Neelakanta and Hung Arch Built Started Linux distro ------------------------------------------- mips n n mips64 n n x86 n n x86_64 n n powerpc n n powerpc64 n n Reviewer Checklist: ------------------- [Submitters: make sure that your review doesn't trigger any checkmarks!] Your checkin has not passed review because (see checked entries): ___ Your RR template is generally incomplete; it has too many blank entries that need proper data filled in. ___ You have failed to nominate the proper persons for review and push. ___ Your patches do not have proper short+long header ___ You have grammar/spelling in your header that is unacceptable. ___ You have exceeded a sensible line length in your headers/comments/text. ___ You have failed to put in a proper Trac Ticket # into your commits. ___ You have incorrectly put/left internal data in your comments/files (i.e. internal bug tracking tool IDs, product names etc) ___ You have not given any evidence of testing beyond basic build tests. Demonstrate some level of runtime or other sanity testing. ___ You have ^M present in some of your files. These have to be removed. ___ You have needlessly changed whitespace or added whitespace crimes like trailing spaces, or spaces before tabs. ___ You have mixed real technical changes with whitespace and other cosmetic code cleanup changes. These have to be separate commits. ___ You need to refactor your submission into logical chunks; there is too much content into a single commit. ___ You have extraneous garbage in your review (merge commits etc) ___ You have giant attachments which should never have been sent; Instead you should place your content in a public tree to be pulled. ___ You have too many commits attached to an e-mail; resend as threaded commits, or place in a public tree for a pull. ___ You have resent this content multiple times without a clear indication of what has changed between each re-send. ___ You have failed to adequately and individually address all of the comments and change requests that were proposed in the initial review. ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) ___ Your computer have a badly configured date and time; confusing the the threaded patch review. ___ Your changes affect IPC mechanism, and you don't present any results for in-service upgradability test. ___ Your changes affect user manual and documentation, your patch series do not contain the patch that updates the Doxygen manual. |
From: Zoran M. <zor...@er...> - 2015-09-12 10:42:21
|
osaf/services/saf/immsv/immnd/immnd_evt.c | 27 +++++++++++++++++++++++++++ 1 files changed, 27 insertions(+), 0 deletions(-) The patch releases allocated memory for the result of admin op for display resources diff --git a/osaf/services/saf/immsv/immnd/immnd_evt.c b/osaf/services/saf/immsv/immnd/immnd_evt.c --- a/osaf/services/saf/immsv/immnd/immnd_evt.c +++ b/osaf/services/saf/immsv/immnd/immnd_evt.c @@ -4726,6 +4726,7 @@ static uint32_t immnd_evt_proc_admop_rsp */ bool displayRes=false; IMMSV_ADMIN_OPERATION_PARAM *rparams= NULL; + IMMSV_ADMIN_OPERATION_PARAM *prev; struct ImmsvAdminOperationParam *params = evt->info.admOpRsp.parms; SaAisErrorT err = evt->info.admOpRsp.error; SaAisErrorT result = evt->info.admOpRsp.result; @@ -4768,6 +4769,19 @@ static uint32_t immnd_evt_proc_admop_rsp rc = immnd_mds_send_rsp(cb, &(cl_node->tmpSinfo), &send_evt); TRACE_2("SYNC REPLY SENT rc:%u", rc); } + + // Free memory + while(rparams) { + if(rparams->paramType == SA_IMM_ATTR_SASTRINGT) { + free(rparams->paramBuffer.val.x.buf); + } + free(rparams->paramName.buf); + + prev = rparams; + rparams = rparams->next; + free(prev); + } + if (rc != NCSCC_RC_SUCCESS) { LOG_ER("Failure in sending reply for admin-op over MDS"); } @@ -5043,6 +5057,7 @@ static void immnd_evt_proc_admop(IMMND_C uint32_t rc = NCSCC_RC_SUCCESS; SaAisErrorT result = SA_AIS_OK; IMMSV_ADMIN_OPERATION_PARAM *rparams= NULL; + IMMSV_ADMIN_OPERATION_PARAM *prev; osafassert(!pbeExpected); TRACE("Ok reply for internally handled adminOp when PBE not configured"); @@ -5077,6 +5092,18 @@ static void immnd_evt_proc_admop(IMMND_C } } + // Free memory + while(rparams) { + if(rparams->paramType == SA_IMM_ATTR_SASTRINGT) { + free(rparams->paramBuffer.val.x.buf); + } + free(rparams->paramName.buf); + + prev = rparams; + rparams = rparams->next; + free(prev); + } + if (rc != NCSCC_RC_SUCCESS) { LOG_ER("Failure in sending reply for admin-op over MDS"); } |
From: Hung N. <hun...@de...> - 2015-09-12 12:13:55
|
Hi Zoran, An alternative solution is to append 'rparams' to: 'evt->info.admOpRsp.parms' in immnd_evt_proc_admop_rsp() 'evt->info.admOpReq.params' in immnd_evt_proc_admop() and then just let the immnd_evt_destroy() do the job. If you still want to free the memory immediately after sending, I think it's better to follow the pattern in immnd_evt_destroy() while (rparams) { IMMSV_ADMIN_OPERATION_PARAM *p = rparams; rparams = p->next; if (p->paramName.buf) { free(p->paramName.buf); p->paramName.buf = NULL; p->paramName.size = 0; } immsv_evt_free_att_val(&(p->paramBuffer), p->paramType); p->next = NULL; free(p); } Best Regards, Hùng Nguyễn - DEK Technologies ------------------------------------------------------------------------ *From:* Zoran Milinkovic *Sent:* Saturday, September 12, 2015 5:42PM *To:* Neelakanta Reddy *Cc:* Opensaf-devel *Subject:* [devel] [PATCH 1 of 1] imm: fix memory leak in display resources [#1477] osaf/services/saf/immsv/immnd/immnd_evt.c | 27 +++++++++++++++++++++++++++ 1 files changed, 27 insertions(+), 0 deletions(-) The patch releases allocated memory for the result of admin op for display resources diff --git a/osaf/services/saf/immsv/immnd/immnd_evt.c b/osaf/services/saf/immsv/immnd/immnd_evt.c --- a/osaf/services/saf/immsv/immnd/immnd_evt.c +++ b/osaf/services/saf/immsv/immnd/immnd_evt.c @@ -4726,6 +4726,7 @@ static uint32_t immnd_evt_proc_admop_rsp */ bool displayRes=false; IMMSV_ADMIN_OPERATION_PARAM *rparams= NULL; + IMMSV_ADMIN_OPERATION_PARAM *prev; struct ImmsvAdminOperationParam *params = evt->info.admOpRsp.parms; SaAisErrorT err = evt->info.admOpRsp.error; SaAisErrorT result = evt->info.admOpRsp.result; @@ -4768,6 +4769,19 @@ static uint32_t immnd_evt_proc_admop_rsp rc = immnd_mds_send_rsp(cb, &(cl_node->tmpSinfo), &send_evt); TRACE_2("SYNC REPLY SENT rc:%u", rc); } + + // Free memory + while(rparams) { + if(rparams->paramType == SA_IMM_ATTR_SASTRINGT) { + free(rparams->paramBuffer.val.x.buf); + } + free(rparams->paramName.buf); + + prev = rparams; + rparams = rparams->next; + free(prev); + } + if (rc != NCSCC_RC_SUCCESS) { LOG_ER("Failure in sending reply for admin-op over MDS"); } @@ -5043,6 +5057,7 @@ static void immnd_evt_proc_admop(IMMND_C uint32_t rc = NCSCC_RC_SUCCESS; SaAisErrorT result = SA_AIS_OK; IMMSV_ADMIN_OPERATION_PARAM *rparams= NULL; + IMMSV_ADMIN_OPERATION_PARAM *prev; osafassert(!pbeExpected); TRACE("Ok reply for internally handled adminOp when PBE not configured"); @@ -5077,6 +5092,18 @@ static void immnd_evt_proc_admop(IMMND_C } } + // Free memory + while(rparams) { + if(rparams->paramType == SA_IMM_ATTR_SASTRINGT) { + free(rparams->paramBuffer.val.x.buf); + } + free(rparams->paramName.buf); + + prev = rparams; + rparams = rparams->next; + free(prev); + } + if (rc != NCSCC_RC_SUCCESS) { LOG_ER("Failure in sending reply for admin-op over MDS"); } ------------------------------------------------------------------------------ _______________________________________________ Opensaf-devel mailing list Ope...@li... https://lists.sourceforge.net/lists/listinfo/opensaf-devel |
From: Zoran M. <zor...@er...> - 2015-09-12 17:48:13
|
Hi Hung, Find my comments inline. From: Hung Nguyen [mailto:hun...@de...] Sent: Saturday, September 12, 2015 2:13 PM To: Zoran Milinkovic; red...@or... Cc: ope...@li... Subject: Re: [devel] [PATCH 1 of 1] imm: fix memory leak in display resources [#1477] Hi Zoran, An alternative solution is to append 'rparams' to: 'evt->info.admOpRsp.parms' in immnd_evt_proc_admop_rsp() 'evt->info.admOpReq.params' in immnd_evt_proc_admop() and then just let the immnd_evt_destroy() do the job. [Zoran] Not good solution. Incoming parameters will not be freed, and attaching rparams to admOpRsp and admOpReq will add more confusion in the code. If you still want to free the memory immediately after sending, I think it's better to follow the pattern in immnd_evt_destroy() while (rparams) { IMMSV_ADMIN_OPERATION_PARAM *p = rparams; rparams = p->next; if (p->paramName.buf) { free(p->paramName.buf); p->paramName.buf = NULL; p->paramName.size = 0; } immsv_evt_free_att_val(&(p->paramBuffer), p->paramType); p->next = NULL; free(p); } [Zoran] I will change the code and use immsv_evt_free_att_val() when I push the code. Setting fields to NULL and 0 for security reason is not necessary. rparams is a local variable within “if” block and is not used anywhere else. Best regards, Zoran Best Regards, Hùng Nguyễn - DEK Technologies ________________________________ From: Zoran Milinkovic Sent: Saturday, September 12, 2015 5:42PM To: Neelakanta Reddy Cc: Opensaf-devel Subject: [devel] [PATCH 1 of 1] imm: fix memory leak in display resources [#1477] osaf/services/saf/immsv/immnd/immnd_evt.c | 27 +++++++++++++++++++++++++++ 1 files changed, 27 insertions(+), 0 deletions(-) The patch releases allocated memory for the result of admin op for display resources diff --git a/osaf/services/saf/immsv/immnd/immnd_evt.c b/osaf/services/saf/immsv/immnd/immnd_evt.c --- a/osaf/services/saf/immsv/immnd/immnd_evt.c +++ b/osaf/services/saf/immsv/immnd/immnd_evt.c @@ -4726,6 +4726,7 @@ static uint32_t immnd_evt_proc_admop_rsp */ bool displayRes=false; IMMSV_ADMIN_OPERATION_PARAM *rparams= NULL; + IMMSV_ADMIN_OPERATION_PARAM *prev; struct ImmsvAdminOperationParam *params = evt->info.admOpRsp.parms; SaAisErrorT err = evt->info.admOpRsp.error; SaAisErrorT result = evt->info.admOpRsp.result; @@ -4768,6 +4769,19 @@ static uint32_t immnd_evt_proc_admop_rsp rc = immnd_mds_send_rsp(cb, &(cl_node->tmpSinfo), &send_evt); TRACE_2("SYNC REPLY SENT rc:%u", rc); } + + // Free memory + while(rparams) { + if(rparams->paramType == SA_IMM_ATTR_SASTRINGT) { + free(rparams->paramBuffer.val.x.buf); + } + free(rparams->paramName.buf); + + prev = rparams; + rparams = rparams->next; + free(prev); + } + if (rc != NCSCC_RC_SUCCESS) { LOG_ER("Failure in sending reply for admin-op over MDS"); } @@ -5043,6 +5057,7 @@ static void immnd_evt_proc_admop(IMMND_C uint32_t rc = NCSCC_RC_SUCCESS; SaAisErrorT result = SA_AIS_OK; IMMSV_ADMIN_OPERATION_PARAM *rparams= NULL; + IMMSV_ADMIN_OPERATION_PARAM *prev; osafassert(!pbeExpected); TRACE("Ok reply for internally handled adminOp when PBE not configured"); @@ -5077,6 +5092,18 @@ static void immnd_evt_proc_admop(IMMND_C } } + // Free memory + while(rparams) { + if(rparams->paramType == SA_IMM_ATTR_SASTRINGT) { + free(rparams->paramBuffer.val.x.buf); + } + free(rparams->paramName.buf); + + prev = rparams; + rparams = rparams->next; + free(prev); + } + if (rc != NCSCC_RC_SUCCESS) { LOG_ER("Failure in sending reply for admin-op over MDS"); } ------------------------------------------------------------------------------ _______________________________________________ Opensaf-devel mailing list Ope...@li...<mailto:Ope...@li...> https://lists.sourceforge.net/lists/listinfo/opensaf-devel |
From: Hung N. <hun...@de...> - 2015-09-13 02:26:30
|
Hi Zoran, By "appending rparams", I mean merging rparams with the incoming parameters by using 'next' pointer. Yes, I agree that this will cause more confusion:-) Best Regards, Hùng Nguyễn - DEK Technologies ------------------------------------------------------------------------ *From:* Zoran Milinkovic *Sent:* Sunday, September 13, 2015 12:48AM *To:* Hung Nguyen, Neelakanta Reddy *Cc:* Opensaf-devel *Subject:* RE: [devel] [PATCH 1 of 1] imm: fix memory leak in display resources [#1477] Hi Hung, Find my comments inline. *From:*Hung Nguyen [mailto:hun...@de...] *Sent:* Saturday, September 12, 2015 2:13 PM *To:* Zoran Milinkovic; red...@or... *Cc:* ope...@li... *Subject:* Re: [devel] [PATCH 1 of 1] imm: fix memory leak in display resources [#1477] Hi Zoran, An alternative solution is to append 'rparams' to: 'evt->info.admOpRsp.parms' in immnd_evt_proc_admop_rsp() 'evt->info.admOpReq.params' in immnd_evt_proc_admop() and then just let the immnd_evt_destroy() do the job. [Zoran] Not good solution. Incoming parameters will not be freed, and attaching rparams to admOpRsp and admOpReq will add more confusion in the code. If you still want to free the memory immediately after sending, I think it's better to follow the pattern in immnd_evt_destroy() while (rparams) { IMMSV_ADMIN_OPERATION_PARAM *p = rparams; rparams = p->next; if (p->paramName.buf) { free(p->paramName.buf); p->paramName.buf = NULL; p->paramName.size = 0; } immsv_evt_free_att_val(&(p->paramBuffer), p->paramType); p->next = NULL; free(p); } [Zoran] I will change the code and use immsv_evt_free_att_val() when I push the code. Setting fields to NULL and 0 for security reason is not necessary. rparams is a local variable within “if” block and is not used anywhere else. Best regards, Zoran Best Regards, Hùng Nguyễn - DEK Technologies ------------------------------------------------------------------------ *From:* Zoran Milinkovic *Sent:* Saturday, September 12, 2015 5:42PM *To:* Neelakanta Reddy *Cc:* Opensaf-devel *Subject:* [devel] [PATCH 1 of 1] imm: fix memory leak in display resources [#1477] osaf/services/saf/immsv/immnd/immnd_evt.c | 27 +++++++++++++++++++++++++++ 1 files changed, 27 insertions(+), 0 deletions(-) The patch releases allocated memory for the result of admin op for display resources diff --git a/osaf/services/saf/immsv/immnd/immnd_evt.c b/osaf/services/saf/immsv/immnd/immnd_evt.c --- a/osaf/services/saf/immsv/immnd/immnd_evt.c +++ b/osaf/services/saf/immsv/immnd/immnd_evt.c @@ -4726,6 +4726,7 @@ static uint32_t immnd_evt_proc_admop_rsp */ bool displayRes=false; IMMSV_ADMIN_OPERATION_PARAM *rparams= NULL; + IMMSV_ADMIN_OPERATION_PARAM *prev; struct ImmsvAdminOperationParam *params = evt->info.admOpRsp.parms; SaAisErrorT err = evt->info.admOpRsp.error; SaAisErrorT result = evt->info.admOpRsp.result; @@ -4768,6 +4769,19 @@ static uint32_t immnd_evt_proc_admop_rsp rc = immnd_mds_send_rsp(cb, &(cl_node->tmpSinfo), &send_evt); TRACE_2("SYNC REPLY SENT rc:%u", rc); } + + // Free memory + while(rparams) { + if(rparams->paramType == SA_IMM_ATTR_SASTRINGT) { + free(rparams->paramBuffer.val.x.buf); + } + free(rparams->paramName.buf); + + prev = rparams; + rparams = rparams->next; + free(prev); + } + if (rc != NCSCC_RC_SUCCESS) { LOG_ER("Failure in sending reply for admin-op over MDS"); } @@ -5043,6 +5057,7 @@ static void immnd_evt_proc_admop(IMMND_C uint32_t rc = NCSCC_RC_SUCCESS; SaAisErrorT result = SA_AIS_OK; IMMSV_ADMIN_OPERATION_PARAM *rparams= NULL; + IMMSV_ADMIN_OPERATION_PARAM *prev; osafassert(!pbeExpected); TRACE("Ok reply for internally handled adminOp when PBE not configured"); @@ -5077,6 +5092,18 @@ static void immnd_evt_proc_admop(IMMND_C } } + // Free memory + while(rparams) { + if(rparams->paramType == SA_IMM_ATTR_SASTRINGT) { + free(rparams->paramBuffer.val.x.buf); + } + free(rparams->paramName.buf); + + prev = rparams; + rparams = rparams->next; + free(prev); + } + if (rc != NCSCC_RC_SUCCESS) { LOG_ER("Failure in sending reply for admin-op over MDS"); } ------------------------------------------------------------------------------ _______________________________________________ Opensaf-devel mailing list Ope...@li... <mailto:Ope...@li...> https://lists.sourceforge.net/lists/listinfo/opensaf-devel |
From: Neelakanta R. <red...@or...> - 2015-09-15 06:40:23
|
Hi zoran, Reviewed and tested the patch. Ack with the comment. comment: destroy rparams in generic way as in immnd_evt_destroy (suggested by Hung). /Neel. On Saturday 12 September 2015 04:12 PM, Zoran Milinkovic wrote: > Summary: imm: fix memory leak in display resources [#1477] > Review request for Trac Ticket(s): 1477 > Peer Reviewer(s): Neelakanta, Hung > Pull request to: Zoran > Affected branch(es): opensaf-4.5.x, opensaf-4.6.x, default(4.7) > Development branch: default(4.7) > > -------------------------------- > Impacted area Impact y/n > -------------------------------- > Docs n > Build system n > RPM/packaging n > Configuration files n > Startup scripts n > SAF services y > OpenSAF services n > Core libraries n > Samples n > Tests n > Other n > > > Comments (indicate scope for each "y" above): > --------------------------------------------- > > changeset 4581d497fbff57d03c32108444a47c6aa3c1d232 > Author: Zoran Milinkovic <zor...@er...> > Date: Sat, 12 Sep 2015 12:37:21 +0200 > > imm: fix memory leak in display resources [#1477] > > The patch releases allocated memory for the result of admin op for display > resources > > > Complete diffstat: > ------------------ > osaf/services/saf/immsv/immnd/immnd_evt.c | 27 +++++++++++++++++++++++++++ > 1 files changed, 27 insertions(+), 0 deletions(-) > > > Testing Commands: > ----------------- > > > Testing, Expected Results: > -------------------------- > Check that IMMND does not have memory leak after admin ops for display resources > > > Conditions of Submission: > ------------------------- > Ack from Neelakanta and Hung > > > Arch Built Started Linux distro > ------------------------------------------- > mips n n > mips64 n n > x86 n n > x86_64 n n > powerpc n n > powerpc64 n n > > > Reviewer Checklist: > ------------------- > [Submitters: make sure that your review doesn't trigger any checkmarks!] > > > Your checkin has not passed review because (see checked entries): > > ___ Your RR template is generally incomplete; it has too many blank entries > that need proper data filled in. > > ___ You have failed to nominate the proper persons for review and push. > > ___ Your patches do not have proper short+long header > > ___ You have grammar/spelling in your header that is unacceptable. > > ___ You have exceeded a sensible line length in your headers/comments/text. > > ___ You have failed to put in a proper Trac Ticket # into your commits. > > ___ You have incorrectly put/left internal data in your comments/files > (i.e. internal bug tracking tool IDs, product names etc) > > ___ You have not given any evidence of testing beyond basic build tests. > Demonstrate some level of runtime or other sanity testing. > > ___ You have ^M present in some of your files. These have to be removed. > > ___ You have needlessly changed whitespace or added whitespace crimes > like trailing spaces, or spaces before tabs. > > ___ You have mixed real technical changes with whitespace and other > cosmetic code cleanup changes. These have to be separate commits. > > ___ You need to refactor your submission into logical chunks; there is > too much content into a single commit. > > ___ You have extraneous garbage in your review (merge commits etc) > > ___ You have giant attachments which should never have been sent; > Instead you should place your content in a public tree to be pulled. > > ___ You have too many commits attached to an e-mail; resend as threaded > commits, or place in a public tree for a pull. > > ___ You have resent this content multiple times without a clear indication > of what has changed between each re-send. > > ___ You have failed to adequately and individually address all of the > comments and change requests that were proposed in the initial review. > > ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) > > ___ Your computer have a badly configured date and time; confusing the > the threaded patch review. > > ___ Your changes affect IPC mechanism, and you don't present any results > for in-service upgradability test. > > ___ Your changes affect user manual and documentation, your patch series > do not contain the patch that updates the Doxygen manual. > |
From: Zoran M. <zor...@er...> - 2015-09-15 07:29:09
|
Hi Neelakanta, As I answered to Hung, merging two linked list from different sources into one list to be able to free memory, make the code more confusing. To merge two lists, we still need to iterate to the end of one linked list. I don't see any benefit of merging 2 linked lists. Best regards, Zoran -----Original Message----- From: Neelakanta Reddy [mailto:red...@or...] Sent: Tuesday, September 15, 2015 8:47 AM To: Zoran Milinkovic Cc: ope...@li... Subject: Re: [PATCH 0 of 1] Review Request for imm: fix memory leak in display resources [#1477] Hi zoran, Reviewed and tested the patch. Ack with the comment. comment: destroy rparams in generic way as in immnd_evt_destroy (suggested by Hung). /Neel. On Saturday 12 September 2015 04:12 PM, Zoran Milinkovic wrote: > Summary: imm: fix memory leak in display resources [#1477] Review > request for Trac Ticket(s): 1477 Peer Reviewer(s): Neelakanta, Hung > Pull request to: Zoran Affected branch(es): opensaf-4.5.x, > opensaf-4.6.x, default(4.7) Development branch: default(4.7) > > -------------------------------- > Impacted area Impact y/n > -------------------------------- > Docs n > Build system n > RPM/packaging n > Configuration files n > Startup scripts n > SAF services y > OpenSAF services n > Core libraries n > Samples n > Tests n > Other n > > > Comments (indicate scope for each "y" above): > --------------------------------------------- > > changeset 4581d497fbff57d03c32108444a47c6aa3c1d232 > Author: Zoran Milinkovic <zor...@er...> > Date: Sat, 12 Sep 2015 12:37:21 +0200 > > imm: fix memory leak in display resources [#1477] > > The patch releases allocated memory for the result of admin op for display > resources > > > Complete diffstat: > ------------------ > osaf/services/saf/immsv/immnd/immnd_evt.c | 27 +++++++++++++++++++++++++++ > 1 files changed, 27 insertions(+), 0 deletions(-) > > > Testing Commands: > ----------------- > > > Testing, Expected Results: > -------------------------- > Check that IMMND does not have memory leak after admin ops for display > resources > > > Conditions of Submission: > ------------------------- > Ack from Neelakanta and Hung > > > Arch Built Started Linux distro > ------------------------------------------- > mips n n > mips64 n n > x86 n n > x86_64 n n > powerpc n n > powerpc64 n n > > > Reviewer Checklist: > ------------------- > [Submitters: make sure that your review doesn't trigger any > checkmarks!] > > > Your checkin has not passed review because (see checked entries): > > ___ Your RR template is generally incomplete; it has too many blank entries > that need proper data filled in. > > ___ You have failed to nominate the proper persons for review and push. > > ___ Your patches do not have proper short+long header > > ___ You have grammar/spelling in your header that is unacceptable. > > ___ You have exceeded a sensible line length in your headers/comments/text. > > ___ You have failed to put in a proper Trac Ticket # into your commits. > > ___ You have incorrectly put/left internal data in your comments/files > (i.e. internal bug tracking tool IDs, product names etc) > > ___ You have not given any evidence of testing beyond basic build tests. > Demonstrate some level of runtime or other sanity testing. > > ___ You have ^M present in some of your files. These have to be removed. > > ___ You have needlessly changed whitespace or added whitespace crimes > like trailing spaces, or spaces before tabs. > > ___ You have mixed real technical changes with whitespace and other > cosmetic code cleanup changes. These have to be separate commits. > > ___ You need to refactor your submission into logical chunks; there is > too much content into a single commit. > > ___ You have extraneous garbage in your review (merge commits etc) > > ___ You have giant attachments which should never have been sent; > Instead you should place your content in a public tree to be pulled. > > ___ You have too many commits attached to an e-mail; resend as threaded > commits, or place in a public tree for a pull. > > ___ You have resent this content multiple times without a clear indication > of what has changed between each re-send. > > ___ You have failed to adequately and individually address all of the > comments and change requests that were proposed in the initial review. > > ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) > > ___ Your computer have a badly configured date and time; confusing the > the threaded patch review. > > ___ Your changes affect IPC mechanism, and you don't present any results > for in-service upgradability test. > > ___ Your changes affect user manual and documentation, your patch series > do not contain the patch that updates the Doxygen manual. > |
From: Neelakanta R. <red...@or...> - 2015-09-15 08:17:14
|
Hi zoran, My comment was not merging, but freeing: while (rparams) { IMMSV_ADMIN_OPERATION_PARAM *p = rparams; rparams = p->next; if (p->paramName.buf) { free(p->paramName.buf); p->paramName.buf = NULL; p->paramName.size = 0; } immsv_evt_free_att_val(&(p->paramBuffer), p->paramType); p->next = NULL; free(p); } /Neel. On Tuesday 15 September 2015 12:58 PM, Zoran Milinkovic wrote: > Hi Neelakanta, > > As I answered to Hung, merging two linked list from different sources into one list to be able to free memory, make the code more confusing. > To merge two lists, we still need to iterate to the end of one linked list. > I don't see any benefit of merging 2 linked lists. > > Best regards, > Zoran > > -----Original Message----- > From: Neelakanta Reddy [mailto:red...@or...] > Sent: Tuesday, September 15, 2015 8:47 AM > To: Zoran Milinkovic > Cc: ope...@li... > Subject: Re: [PATCH 0 of 1] Review Request for imm: fix memory leak in display resources [#1477] > > Hi zoran, > > Reviewed and tested the patch. > Ack with the comment. > > comment: > destroy rparams in generic way as in immnd_evt_destroy (suggested by Hung). > > /Neel. > > On Saturday 12 September 2015 04:12 PM, Zoran Milinkovic wrote: >> Summary: imm: fix memory leak in display resources [#1477] Review >> request for Trac Ticket(s): 1477 Peer Reviewer(s): Neelakanta, Hung >> Pull request to: Zoran Affected branch(es): opensaf-4.5.x, >> opensaf-4.6.x, default(4.7) Development branch: default(4.7) >> >> -------------------------------- >> Impacted area Impact y/n >> -------------------------------- >> Docs n >> Build system n >> RPM/packaging n >> Configuration files n >> Startup scripts n >> SAF services y >> OpenSAF services n >> Core libraries n >> Samples n >> Tests n >> Other n >> >> >> Comments (indicate scope for each "y" above): >> --------------------------------------------- >> >> changeset 4581d497fbff57d03c32108444a47c6aa3c1d232 >> Author: Zoran Milinkovic <zor...@er...> >> Date: Sat, 12 Sep 2015 12:37:21 +0200 >> >> imm: fix memory leak in display resources [#1477] >> >> The patch releases allocated memory for the result of admin op for display >> resources >> >> >> Complete diffstat: >> ------------------ >> osaf/services/saf/immsv/immnd/immnd_evt.c | 27 +++++++++++++++++++++++++++ >> 1 files changed, 27 insertions(+), 0 deletions(-) >> >> >> Testing Commands: >> ----------------- >> >> >> Testing, Expected Results: >> -------------------------- >> Check that IMMND does not have memory leak after admin ops for display >> resources >> >> >> Conditions of Submission: >> ------------------------- >> Ack from Neelakanta and Hung >> >> >> Arch Built Started Linux distro >> ------------------------------------------- >> mips n n >> mips64 n n >> x86 n n >> x86_64 n n >> powerpc n n >> powerpc64 n n >> >> >> Reviewer Checklist: >> ------------------- >> [Submitters: make sure that your review doesn't trigger any >> checkmarks!] >> >> >> Your checkin has not passed review because (see checked entries): >> >> ___ Your RR template is generally incomplete; it has too many blank entries >> that need proper data filled in. >> >> ___ You have failed to nominate the proper persons for review and push. >> >> ___ Your patches do not have proper short+long header >> >> ___ You have grammar/spelling in your header that is unacceptable. >> >> ___ You have exceeded a sensible line length in your headers/comments/text. >> >> ___ You have failed to put in a proper Trac Ticket # into your commits. >> >> ___ You have incorrectly put/left internal data in your comments/files >> (i.e. internal bug tracking tool IDs, product names etc) >> >> ___ You have not given any evidence of testing beyond basic build tests. >> Demonstrate some level of runtime or other sanity testing. >> >> ___ You have ^M present in some of your files. These have to be removed. >> >> ___ You have needlessly changed whitespace or added whitespace crimes >> like trailing spaces, or spaces before tabs. >> >> ___ You have mixed real technical changes with whitespace and other >> cosmetic code cleanup changes. These have to be separate commits. >> >> ___ You need to refactor your submission into logical chunks; there is >> too much content into a single commit. >> >> ___ You have extraneous garbage in your review (merge commits etc) >> >> ___ You have giant attachments which should never have been sent; >> Instead you should place your content in a public tree to be pulled. >> >> ___ You have too many commits attached to an e-mail; resend as threaded >> commits, or place in a public tree for a pull. >> >> ___ You have resent this content multiple times without a clear indication >> of what has changed between each re-send. >> >> ___ You have failed to adequately and individually address all of the >> comments and change requests that were proposed in the initial review. >> >> ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) >> >> ___ Your computer have a badly configured date and time; confusing the >> the threaded patch review. >> >> ___ Your changes affect IPC mechanism, and you don't present any results >> for in-service upgradability test. >> >> ___ Your changes affect user manual and documentation, your patch series >> do not contain the patch that updates the Doxygen manual. >> |
From: Zoran M. <zor...@er...> - 2015-09-15 08:34:40
|
Hi Neelakanta, It was misunderstanding. I'll do as you described. Thanks, Zoran -----Original Message----- From: Neelakanta Reddy [mailto:red...@or...] Sent: Tuesday, September 15, 2015 10:24 AM To: Zoran Milinkovic Cc: ope...@li... Subject: Re: [PATCH 0 of 1] Review Request for imm: fix memory leak in display resources [#1477] Hi zoran, My comment was not merging, but freeing: while (rparams) { IMMSV_ADMIN_OPERATION_PARAM *p = rparams; rparams = p->next; if (p->paramName.buf) { free(p->paramName.buf); p->paramName.buf = NULL; p->paramName.size = 0; } immsv_evt_free_att_val(&(p->paramBuffer), p->paramType); p->next = NULL; free(p); } /Neel. On Tuesday 15 September 2015 12:58 PM, Zoran Milinkovic wrote: > Hi Neelakanta, > > As I answered to Hung, merging two linked list from different sources into one list to be able to free memory, make the code more confusing. > To merge two lists, we still need to iterate to the end of one linked list. > I don't see any benefit of merging 2 linked lists. > > Best regards, > Zoran > > -----Original Message----- > From: Neelakanta Reddy [mailto:red...@or...] > Sent: Tuesday, September 15, 2015 8:47 AM > To: Zoran Milinkovic > Cc: ope...@li... > Subject: Re: [PATCH 0 of 1] Review Request for imm: fix memory leak in > display resources [#1477] > > Hi zoran, > > Reviewed and tested the patch. > Ack with the comment. > > comment: > destroy rparams in generic way as in immnd_evt_destroy (suggested by Hung). > > /Neel. > > On Saturday 12 September 2015 04:12 PM, Zoran Milinkovic wrote: >> Summary: imm: fix memory leak in display resources [#1477] Review >> request for Trac Ticket(s): 1477 Peer Reviewer(s): Neelakanta, Hung >> Pull request to: Zoran Affected branch(es): opensaf-4.5.x, >> opensaf-4.6.x, default(4.7) Development branch: default(4.7) >> >> -------------------------------- >> Impacted area Impact y/n >> -------------------------------- >> Docs n >> Build system n >> RPM/packaging n >> Configuration files n >> Startup scripts n >> SAF services y >> OpenSAF services n >> Core libraries n >> Samples n >> Tests n >> Other n >> >> >> Comments (indicate scope for each "y" above): >> --------------------------------------------- >> >> changeset 4581d497fbff57d03c32108444a47c6aa3c1d232 >> Author: Zoran Milinkovic <zor...@er...> >> Date: Sat, 12 Sep 2015 12:37:21 +0200 >> >> imm: fix memory leak in display resources [#1477] >> >> The patch releases allocated memory for the result of admin op for display >> resources >> >> >> Complete diffstat: >> ------------------ >> osaf/services/saf/immsv/immnd/immnd_evt.c | 27 +++++++++++++++++++++++++++ >> 1 files changed, 27 insertions(+), 0 deletions(-) >> >> >> Testing Commands: >> ----------------- >> >> >> Testing, Expected Results: >> -------------------------- >> Check that IMMND does not have memory leak after admin ops for >> display resources >> >> >> Conditions of Submission: >> ------------------------- >> Ack from Neelakanta and Hung >> >> >> Arch Built Started Linux distro >> ------------------------------------------- >> mips n n >> mips64 n n >> x86 n n >> x86_64 n n >> powerpc n n >> powerpc64 n n >> >> >> Reviewer Checklist: >> ------------------- >> [Submitters: make sure that your review doesn't trigger any >> checkmarks!] >> >> >> Your checkin has not passed review because (see checked entries): >> >> ___ Your RR template is generally incomplete; it has too many blank entries >> that need proper data filled in. >> >> ___ You have failed to nominate the proper persons for review and push. >> >> ___ Your patches do not have proper short+long header >> >> ___ You have grammar/spelling in your header that is unacceptable. >> >> ___ You have exceeded a sensible line length in your headers/comments/text. >> >> ___ You have failed to put in a proper Trac Ticket # into your commits. >> >> ___ You have incorrectly put/left internal data in your comments/files >> (i.e. internal bug tracking tool IDs, product names etc) >> >> ___ You have not given any evidence of testing beyond basic build tests. >> Demonstrate some level of runtime or other sanity testing. >> >> ___ You have ^M present in some of your files. These have to be removed. >> >> ___ You have needlessly changed whitespace or added whitespace crimes >> like trailing spaces, or spaces before tabs. >> >> ___ You have mixed real technical changes with whitespace and other >> cosmetic code cleanup changes. These have to be separate commits. >> >> ___ You need to refactor your submission into logical chunks; there is >> too much content into a single commit. >> >> ___ You have extraneous garbage in your review (merge commits etc) >> >> ___ You have giant attachments which should never have been sent; >> Instead you should place your content in a public tree to be pulled. >> >> ___ You have too many commits attached to an e-mail; resend as threaded >> commits, or place in a public tree for a pull. >> >> ___ You have resent this content multiple times without a clear indication >> of what has changed between each re-send. >> >> ___ You have failed to adequately and individually address all of the >> comments and change requests that were proposed in the initial review. >> >> ___ You have a misconfigured ~/.hgrc file (i.e. username, email etc) >> >> ___ Your computer have a badly configured date and time; confusing the >> the threaded patch review. >> >> ___ Your changes affect IPC mechanism, and you don't present any results >> for in-service upgradability test. >> >> ___ Your changes affect user manual and documentation, your patch series >> do not contain the patch that updates the Doxygen manual. >> |