Re: [devel] [PATCH 1 of 1] amfd: fix infinite loop when processing CLM node tracking [#877]

[Alex J. <aj...@ge...>]

Actually, it is a PLM Deactivation request, which CLM translates into 
NODE_LEFT.

Alex

On 04/29/2014 10:15 AM, Hans Feldt wrote:
> What is the test case, CLM node lock?
> /Hans
>
>> -----Original Message-----
>> From: Alex Jones [mailto:aj...@ge...]
>> Sent: den 29 april 2014 16:04
>> To: Hans Feldt
>> Cc: ope...@li...
>> Subject: [PATCH 1 of 1] amfd: fix infinite loop when processing CLM node tracking [#877]
>>
>>   osaf/services/saf/amf/amfd/clm.cc |  1 +
>>   1 files changed, 1 insertions(+), 0 deletions(-)
>>
>>
>> Logs from amfnd:
>> Apr 25 21:37:13.521696 osafamfnd [4547] ER AMF director heart beat timeout, generating core for amfd
>>
>> clm_node_exit_validate loops through all the SUs for the passed in node, but
>> never actually moves to the next SU, so the while test is always true.
>>
>> By moving on the the next SU in the loop, we can exit the while loop when there
>> are no more SUs.
>>
>> diff --git a/osaf/services/saf/amf/amfd/clm.cc b/osaf/services/saf/amf/amfd/clm.cc
>> --- a/osaf/services/saf/amf/amfd/clm.cc
>> +++ b/osaf/services/saf/amf/amfd/clm.cc
>> @@ -114,6 +114,7 @@ static void clm_node_exit_validate(AVD_A
>>   			}
>>   			susi = susi->su_next;
>>   		}
>> +		su = su->avnd_list_su_next;
>>   	}
>>
>>   done: