Menu

Code Merge Request #4: Fiy CMake Python detection (open)

Merging...

Merged

Something went wrong. Please, merge manually

Checking if merge is possible...

Something went wrong. Please, merge manually

tbeu wants to merge 1 commit from /u/t-beu/openrti/ to master, 2019-12-13

This fixes the Python detection if CMake is configured for MSVC.

Commit Date  
[fb9324] (fix-python-detection) by tbeu tbeu

Fix Python detection

With MSVC and Python 3.7 (the tested version) CheckCXXSourceCompiles tries to link the python37_d.lib which is not found. CheckCXXSourceCompiles was configured to always build in release mode.

2019-09-17 20:05:32 Tree

Discussion

  • Mathias Fröhlich

    Thanks so far.

    But, I am not going to merge that as is. There are lots of unrelated changes packed into this commit. I have already picked the typos. Also the upcase/downcase change that I pused some time ago is partially undone.
    If I merge something I want to be able to review the change without being distracted to unrelated changes. So, having commits that focus on exactly one topic would be great. That also opens the opportunity to revert that specific topic commit in case it turns out problematic without sacreficing may be usefull changes within the same munged together commit.

    I am not exactly sure what you are fixing. Is this more related to the version check or more related that the wrong python dll is liked to the rti python binding module?

    best
    Mathias

     
  • tbeu

    tbeu - 2019-09-20

    Thanks for the feedback. Glad to see that this repo is alive. I will provide a new PR with dedicated CMake fixes (there is one more linker issue in MSVC when building the import libs for the python libs).

     
  • tbeu

    tbeu - 2019-11-05

    With the new master I now get the message

    Could NOT find Python: Found unsuitable major version "3", but required major version is exact version "2"

    Python 3.7 is what I have installed and what is detected.

     
  • Mathias Fröhlich

    With the current git master, there is an other change that should improve the selection of the python version to be used for the binding.

     

Log in to post a comment.

Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.