#43 Fix network message pack/unpack

OpenRPG1
closed-accepted
Server (5)
5
2007-05-12
2007-04-22
No

Fix incorrect use of pack() and unpack() on the network message length. The use of plain "i" and htons() doesn't work on 64 bit Linux systems.

Discussion

  • Digital Xero

    Digital Xero - 2007-05-09

    Logged In: YES
    user_id=76439
    Originator: NO

    How will this play with clients and servers who have not bothered to upgrade if I implement this?

     
  • Digital Xero

    Digital Xero - 2007-05-10
    • labels: --> Server
    • assigned_to: nobody --> digitalxero
     
  • David Vrabel

    David Vrabel - 2007-05-11

    Logged In: YES
    user_id=36369
    Originator: YES

    This doesn't change the byte ordering on 32 bit platforms so old clients will be compatible. I believe 64 bit systems have never worked correctly.

     
  • Digital Xero

    Digital Xero - 2007-05-12

    Logged In: YES
    user_id=76439
    Originator: NO

    Applied this patch to both the release and development versions CVS, it will be in the next system update

     
  • Digital Xero

    Digital Xero - 2007-05-12
    • status: open --> closed-accepted
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks