Menu

Reporting things not bugs

2000-05-07
2000-05-08
  • Robert John Andersen

    Whats the mechanism for reporting things like changes in an implementation of a method, open a bug or post to this forum.

    As an example, while looking through OQUser I noted the 2 methods:
    <PRE>
    public void addToDoItem(int aTopicID, int anItemID) {
      OQToDoItem btdi = new OQToDoItem (aTopicID, anItemID);
      toDoItems.addElement (btdi);
    }

    public void addToDoItem(OQToDoItem aToDoItem) {
      toDoItems.addElement (aToDoItem);
    }
    </PRE>

    I would suggest that addToDoItem(int aTopicID, int anItemID) be changed to

    <PRE>
    public void addToDoItem(int aTopicID, int anItemID) {
      addtoDoItem( new OQToDoItem( aTopicID, anItemID );
    }
    </PRE>

    I know things like this are small but it helps insulate against errors if changes have to take place to the toDoItems Vector.

    Let me know, thanks.

     
    • Matt Jensen

      Matt Jensen - 2000-05-08

      Good point, thanks. Change made, and will be rolled into the next build (I'm trying to put builds every 24-48 hours now).  I agree it's generally better to get things done well, upfront, than to add a bunch of half-done code and hope you'll have time to clean it all up later.

      Regarding reporting, I think in this example it could have been posted either as a low-priority bug or wish-list item.  Maybe we should add a "coding style" priority.

       

Log in to post a comment.

Want the latest updates on software, tech news, and AI?
Get latest updates about software, tech news, and AI from SourceForge directly in your inbox once a month.