Menu

#396 line comment in block comment may hide end of comment  Edit

compiler
pending
None
2025-11-30
2022-07-29
No

The following code compiles fine in the actual version

 /* block comment start .... !   */
 and is stil lactive
*/    ! and ends here

see testsuite/tickets/396_comment.prl

Discussion

  • Rainer Müller

    Rainer Müller - 2022-07-29
    • Description has changed:

    Diff:

    --- old
    +++ new
    @@ -4,4 +4,4 @@
          and is stil lactive
         */    ! and ends here 
    
    -see testsuite/tickets
    +see testsuite/tickets/396_comment.prl
    
     
  • Rainer Müller

    Rainer Müller - 2022-08-16

    There are other situations for bad comment recognition ...

    /* any text " quotation start */
    

    the end of comment is not recognized also with single quote

     
  • Anonymous

    Anonymous - 2024-01-15
    • status: open --> accepted
    • assigned_to: Marcel Schaible
     
  • Marcel Schaible

    Marcel Schaible - 2024-01-16

    Agreed. I think we need a different approach for handling comments in preprocessor. At the moment there is a semi-complete parser for comments in the PP. I will remove this and handle only the necessary cases in the PP and pass the comments to the compiler.

     
  • Marcel Schaible

    Marcel Schaible - 2025-11-30
    • status: accepted --> open
     
  • Marcel Schaible

    Marcel Schaible - 2025-11-30
    • status: open --> pending
     
  • Marcel Schaible

    Marcel Schaible - 2025-11-30

    Should be fixed with new preprocessor.

     

Anonymous
Anonymous

Add attachments
Cancel





MongoDB Logo MongoDB