Re: [Openoss-devel] Please avoid using valueType as a field name in JOSIF Models (PM Model)

[Flauw, M. <Mar...@hp...>]

Craig,

I was thinking of the latter: having SID Import prefix the valueType attribute by an underscore, but I can put a CR on the SID also.

Best regards

Marc

From: Craig Gallen [mailto:gal...@go...] On Behalf Of cg...@op...
Sent: Tuesday, July 31, 2012 3:53 PM
To: Flauw, Marc; cg...@op...; Yuv...@te...
Cc: ope...@li...
Subject: RE: Please avoid using valueType as a field name in JOSIF Models (PM Model)

Hi,

Thanks for that.

In theory we could underscore valueType in the attribute access code but it will involve quite a lot of rework, testing and also loss of backwards compatibility. More importantly it will moves us away from the OSS/J design pattern which I wanted to preserve if at all possible.

To my knowledge 'valueType' doesn't seem to be a generic term for field names  in the SID since it is used with different type variables. Would it be impossibly difficult to change the 25 field names to more closely reflect the types they represent. Perhaps this could be done as part of the expedited interfaces project.

Alternatively, could the UML importer put an underscore _valueType whenever it does an import of the valueType field name

Craig

From: Flauw, Marc [mailto:Mar...@hp...]<mailto:[mailto:Mar...@hp...]>
Sent: 31 July 2012 14:24
To: cg...@op...<mailto:cg...@op...>; Yuv...@te...<mailto:Yuv...@te...>
Cc: ope...@li...<mailto:ope...@li...>
Subject: RE: Please avoid using valueType as a field name in JOSIF Models (PM Model)

Hi Craig,

We fixed the PM attribute, but there are 26 attributes named valueType all together in the SID.

Is there a way to work around, like putting an underscore in front of the attribute?

Best regards

Marc

From: Craig Gallen [mailto:gal...@go...]<mailto:[mailto:gal...@go...]> On Behalf Of cg...@op...<mailto:cg...@op...>
Sent: Tuesday, July 31, 2012 11:08 AM
To: Flauw, Marc; 'Yuval Stein'
Cc: ope...@li...<mailto:ope...@li...>
Subject: Please avoid using valueType as a field name in JOSIF Models (PM Model)

Marc, Yuval,

I have found a problem in the PM dependency model. As you know the Java API we are using for the RI / CTK is based upon the OSS/J design patterns. This means that every Java value type we generate has a reserved field VALUE_TYPE and an operator getValueType().

As a result it is important that 'valueType' is not used as a name for an attribute of an Entity, DataType or Facade in the model. This has not been a problem to date but I have found an issue in the PM Dependencies model;

org.tmforum.tip.cbe.perf.spec.PerformanceIndicatorSpecification
has the field valueType;

// A kind of value that the PerformanceIndicator can take on, such as numeric, text, and so forth.
org.tmforum.tip.cbe.perf.IndicatorType valueType

Could we please change the name of the field in the model from valueType to indicatorType

Thanks

Craig