Re: [Openoss-devel] Abstract Facades in common model

[Craig G. (opennms) <cg...@op...>]

Hi,

We discussed this today at the SII call and want to continue the 
discussion to reach a resolution. There are two issues.

If we make an interface concrete in the common model, it will show up as 
concrete in all of the generated interfaces since the common model XSD's 
and WSDLs are imported upstream. If we don't want the file management 
interfaces to be inherited by all interfaces upstream, we need to choose 
whether to include them or not and this can only be done by creating 
another 'common model'  a model explicitly and only for the interface. 
We include it if we need it.

Craig




On 28/06/2012 05:31, Pierre Gauthier wrote:
> Hi,
>
> What would be the consequence of making the common model "concrete" with the
> assumption that the specific APIs would extend this concrete model.
>
> Pierre
> On Jun 27, 2012, at 10:32 AM, Craig Gallen (opennms) wrote:
>
>> Hi,
>>
>> Yes, The problem is that in every  model, the generated marshalling and
>> marshalling code expects there to be a corresponding set of JAXB classes
>> which are generated from the model xsd/wsdl which the soap generator
>> creates. In a number of models, abstract interfaces are created but
>> these are extended by WSDL which is actually in the model. However in
>> the new common model case, there is only an abstract interface and no
>> concrete interface.
>>
>> In this case the current soap generator decides not to generate any wsdl
>> for the abstract interface and this leaves the corresponding marshalling
>> code without essential classes.  At a minimum we need the soap generator
>> to generate abstract interfaces in the common model even if there is no
>> concrete interface in the model
>>
>> This may lead to a further discussion about possibly having more than
>> one 'common model' if we want to avoid including abstract interfaces in
>> TIP interfaces which don't need them.
>>
>> Hope this helps
>> Cheers
>>
>> Craig
>>
>>
>>
>>
>>
>>
>>
>>
>>
>>
>> On 27/06/2012 09:25, Flauw, Marc wrote:
>>> Hi Craig,
>>>
>>> So if my understanding is correct, you are asking for a change in the SOAP generator.
>>>
>>> Is it needed to generate wsdl for abstract service interfaces in all cases?
>>> I would assume that if the concrete service interface is present, then everything would be generated in the wsdl of the concrete service interface.
>>>
>>> Do you confirm the only case not covered is the common Model one, i.e. an abstract service interface with no derived concrete interface in the same project?
>>>
>>> Best regards
>>>
>>> Marc
>>>
>>> -----Original Message-----
>>> From: Craig Gallen [mailto:gal...@go...] On Behalf Of Craig Gallen (opennms)
>>> Sent: Tuesday, June 26, 2012 4:59 PM
>>> To: Flauw, Marc
>>> Cc: openoss-devel
>>> Subject: Re: Abstract Facades in common model
>>>
>>> Hi,
>>>
>>> We need to generate the wsdl for the abstract ManagementJobInterface because the rest of the build of the common model marshalling and unmarshalling for hte RI/CTK expects there to be jaxb classes generated from the ManagementJobInterface. These will be abstract classes which the later concrete classes extend
>>>
>>> Cheers
>>> Craig
>>>
>>>
>>>
>>>
>>>
>>> On 26/06/2012 06:43, Flauw, Marc wrote:
>>>> Craig,
>>>>
>>>> I think you refer to the ManagementJobInterface. It is true this is an abstract interface and it will be inherited by concrete ones in the interfaces using it.
>>>>
>>>> I am not sure to understand why we need to generate the wsdl for it.
>>>>
>>>> Best regards
>>>>
>>>> Marc
>>>>
>>>> -----Original Message-----
>>>> From: Craig Gallen [mailto:cg...@we...]
>>>> Sent: Tuesday, June 26, 2012 3:56 AM
>>>> To: Flauw, Marc; openoss-devel
>>>> Subject: Abstract Facades in common model
>>>>
>>>> Hi,
>>>>
>>>>
>>>> The Common model contains an abstract facade but the soap generator does not generate this if there is no super facade. We should be generating the abstract faecal as abstract WSDL otherwise the Common model does not compile correctly.
>>>>
>>>> Craig
>>
>>
>> ------------------------------------------------------------------------------
>> Live Security Virtual Conference
>> Exclusive live event will cover all the ways today's security and
>> threat landscape has changed and how IT managers can respond. Discussions
>> will include endpoint security, mobile security and the latest in malware
>> threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
>> _______________________________________________
>> Openoss-devel mailing list
>> Ope...@li...
>> https://lists.sourceforge.net/lists/listinfo/openoss-devel
>>
>