[openorb-users] Minor Delegate.java corrections

[Jacek C. <jc...@ag...>]

I'm using OpenORB 1.4.0 in the context of Location Forward and spotted 
some minor problems in ...orb.core.Delegate class

In 'is_a' operation there is the following bit of code:

for ( ;; )
{
  ...
  else
  {
   ...
   catch (final ForwardRequest e )
   {
     IOR fwd = ((Delegate)((ObjectImpl)e.forward)._get_delegate().ior();
     state.receiveRedirect( self, fwd, false );
     failed = false;
     return false;
   }
   finally
   {
   ...


Why the operation does not try to follow the forward request? I think it 
would be better if instead of 'return false' there was a 'continue' 
statement.

for ( ;; )
{
  ...
  else
  {
   ...
   catch (final ForwardRequest e )
   {
     IOR fwd = ( ( Delegate ) ( ( ObjectImpl ) e.forward 
)._get_delegate() ).ior();
     state.receiveRedirect( self, fwd, false );
     failed = false;
     continue;
   }
   finally
   {
   ...

The same is true for all 'on reference' operations. What do you think?

-- 
   Jacek Cala
___________________________________________________________________
Distributed Systems Research Group   Department of Computer Science
AGH - University of Science and Technology           Krakow, Poland
tel.: +48 12 6173491 ext. 71                   fax.: +48 12 6339406